@Amitjoki No worries please go through with it. Although, I did take a look at your code and I don't think you need to add new methods for this issues, and also as far as I have understood you don't need to display the year as well. As @Nuria correctly mentioned above you can take an example from Dashboard list of metrics. While you are at it so take a look at https://github.com/wikimedia/analytics-wikistats2/blob/master/src/components/dashboard/MetricListWidget.vue#L38, this might reduce your code even more. Try to extract information from already computed functions. For better understanding of the description please also look at T187389, you might be able to relate to this description more. Thanks.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 30 2018
Hey all, this task would be really interesting.
@fdans - I had a quick question, any reason why we didn't opt for pre-processors (SASS/SCSS or LESS) to handle dynamic values and variables in CSS rather can just plain CSS? I understand that this is purely opinionated and it comes down to the preference of the designer/developer but still wanted to know the motivation behind one over the other.
@mforns - Can we think of adding this as a possible sub-task for the project T189210 for GSoC 2018. What are your thoughts on this?
@Amitjoki I admire your enthusiasm, but whenever you take a task please share it in comments or claim to work on the task. I was about to submit a patch for the same.
Mar 29 2018
Mar 28 2018
Mar 27 2018
Mar 26 2018
Mar 24 2018
@mforns I have made the suggested changes. If there is anything else that can improve this proposal please let me know. I'll share my ideas on new improvements as soon as I can, really soon though. Cheers!
Mar 22 2018
@mforns Thanks a lot for reviewing this. I'll make the suggested changes as soon as I can :)
@JAllemandou Thanks a lot.
@mforns On it :-)
@mforns Thanks for the review :)
Mar 21 2018
Yes, I feel the same. Since https://en.wikipedia.org/wiki/Unknown does not have anything related (for now :P ) to a Country (name). So I guess I would go about replacing '--' with 'Unknown' in the patch. Please let me know if there are any other issues :) Thanks.
Mar 19 2018
Mar 18 2018
Mar 17 2018
Mar 16 2018
@mforns This is interesting. Will try my best. Whatever option we go with it should be more convenient to the user to relate to. Maybe want to keep this for the GSoC coding period but lets see if I can get it done before.
Thanks @mforns. I agree about the line break, will make it look a bit more uniform and cleaner. On it!
I was thinking the same :) Plus I don't think that we have any other reasonably good option besides that.
Hey, we know now that we can't place the legend (with the date and the values of the point) anywhere over the line graph as it hinders with the hovering and also makes the line color lighter than usual which might be confusing to the user. At the moment I see one possible solution which is to move the label/valuePopup div to a new position maybe where it does not intersect with the line graph but still remain noticeable to the user. Any suggestions?
Mar 14 2018
@mforns which search placeholder and input are mentioned here, the one in TopicExplorer or the one in WikiSelector ?
@mforns do you currently have something on mind instead of "--" ?
Mar 13 2018
There are many ways to go about solving this bug. One is to provide a uniform left and right margin and adjust the class height a bit. Responsiveness checks out as well. Looks like this locally. @mforns
Mar 12 2018
@mforns - I would be interested to work on this project for GSoC 2018. I have explored some of the sub-tasks that have been listed above and have some really interesting ideas on how we can improve the frontend of Wikistats2. I've a lot of experience with the skillsets required for this project such as VueJS and normal JS for instance. Thanks.