Currently NavigationTiming only records the user's Country. In order to narrow down the metrics to a state-level, we also need to record state/region.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Gilles | T101345 [DRAFT] Performance Team Goals July - September 2015 (Q1 2015/2016) | |||
| Resolved | • Gilles | T101819 Track state (region) | |||
| Resolved | ori | T103720 parsing legacy GeoIP cookies fails (no regex match), enwiki geonotice broken for users with those legacy cookies |
Event Timeline
Comment Actions
Change 216938 had a related patch set uploaded (by Gilles):
Report IP's region code in geoiplookup
Comment Actions
Change 216939 had a related patch set uploaded (by Gilles):
Record region when available
Comment Actions
Change 217231 had a related patch set uploaded (by Gilles):
Parse region in geoip cookie
Comment Actions
Change 218805 had a related patch set uploaded (by Ori.livneh):
Parse region in geoip cookie
Comment Actions
If window.Geo is used outside CentralNotice, should we perhaps move the code that deals with it somewhere else? BTW, now would be a great time to do so, since I'm refactoring bannerController just now... Thanks!!
Comment Actions
+1 to what @AndyRussG said, this raises already existing red flags for me. Considering how important the Varnish optimization is to us, and that CN is using *only* the country information from the GeoIP cookie, the encapsulation and coupling are becoming increasingly wrong.
Creating new task T102848 to track this.
Comment Actions
@awight cool, thanks for creating the task! (BTW, I have no objections to the region change per se. :) )
Comment Actions
Change 219229 had a related patch set uploaded (by Ori.livneh):
Record region when available
Comment Actions
- https://gerrit.wikimedia.org/r/216939 (branch master): WMF-deploy-2015-06-16_(1.26wmf10)
- https://gerrit.wikimedia.org/r/219229 (branch wmf/1.26wmf10): WMF-deploy-2015-06-16_(1.26wmf10)