| • Mattflaschen-WMF | |
| Aug 7 2015, 7:43 AM |
| F3059394: Screen Shot 2015-12-08 at 4.00.18 PM.png | |
| Dec 9 2015, 12:12 AM |
| F3059415: Screen Shot 2015-12-08 at 4.10.30 PM.png | |
| Dec 9 2015, 12:12 AM |
Since we're filtering the history, the user doesn't actually get the number they asked for (50, 100, etc.). This isn't the end of the world; if they click through the 'next' links they will see everything they're intended to see, but it's still wrong.
This can be fixed by letting HistoryPager do the re-querying as needed.
See also T108289: Contributions apparently could have wrong pagination, which should probably be fixed similarly but in ContributionsQuery (since ContribsPager is in core).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix history pagination and give user the number of entries they requested | mediawiki/extensions/Flow | master | +478 -548 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T85563 StructuredDiscussions history page issues (tracking) | |||
| Open | None | T114456 Main topic list pagination can only paginate at most 500 topics (less sometimes, apparently due to moderation) | |||
| Open | None | T108291 Give the user the number of history items they asked for | |||
| Resolved | • Mattflaschen-WMF | T108279 Board history pagination controls are missing |
Change 245621 had a related patch set uploaded (by Mattflaschen):
WIP: Fix history pagination and give user the number of entries they requested
I did this because it was affecting testing of https://gerrit.wikimedia.org/r/245621 .
Change 245621 merged by jenkins-bot:
Fix history pagination and give user the number of entries they requested
Checked in betalabs.
I thought that the fix should apply to the case when a non-admin user requests 20 items per page will get only one due to filtering of suppressed?
vs Admin user requesting and getting 20 items:
Yeah, for some reason this isn't working properly (anymore?) for this case.
E.g. http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:ET10&limit=20&action=history only shows 8 currently. There are well more than 20 the user has permission to see.