Page MenuHomePhabricator
Create Task
Maniphest T108699

WMF-specific links and emails should be in LocalSettings
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

DonationInterface has links to https://wikimediafoundation.org/wiki/Ways_to_Give/en and problemsdonating@wikimedia.org sprinkled throughout templates and i18n messages. These should be tokenized and any language parameter should be explicitly indicated as with $wgDonationInterfaceAppealWikiTemplate.

There's nothing functional about this, but if we want to have other people using DI, we should do this.

Details

SubjectRepoBranchLines +/-
Parameterize support email in messagesmediawiki/extensions/DonationInterfacemaster+567 -556
Fix error msg with otherways URL, add instructionsmediawiki/extensions/DonationInterfacemaster+6 -5
Escape special chars in Mustache URL paramsmediawiki/extensions/DonationInterfacemaster+10 -10
Parameterize 'Donor Policy' URL in messagesmediawiki/extensions/DonationInterfacemaster+84 -79
Parameterize 'Other ways to give' URL in messagesmediawiki/extensions/DonationInterfacemaster+195 -195
Move some WMF-specific links to settingsmediawiki/extensions/DonationInterfacemaster+46 -10
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Aug 11 2015, 3:55 PM
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added projects: Fundraising-Backlog, MediaWiki-extensions-DonationInterface.
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2015, 3:55 PM
• atgo added a project: Fundraising-Backlog-Old.Aug 11 2015, 5:20 PM
• atgo subscribed.
• DStrine updated the task description. (Show Details)Aug 11 2015, 9:17 PM
• DStrine set Security to None.
• DStrine moved this task from Triage to FY 2022-2023 on the Fundraising-Backlog board.
gerritbot subscribed.Oct 2 2015, 6:33 PM

Change 243225 had a related patch set uploaded (by Ejegg):
Move some WMF-specific links to settings

https://gerrit.wikimedia.org/r/243225

gerritbot added a project: Patch-For-Review.Oct 2 2015, 6:33 PM
gerritbot added a comment.Oct 5 2015, 9:52 PM

Change 243225 merged by jenkins-bot:
Move some WMF-specific links to settings

https://gerrit.wikimedia.org/r/243225

awight mentioned this in rEDOI70e410e520ad: Move some WMF-specific links to settings.Oct 5 2015, 9:53 PM
Ejegg mentioned this in rMEXT1cc88f31d240: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Oct 5 2015, 9:53 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 5 2015, 10:00 PM
awight added a project: good first task.Oct 9 2015, 3:00 PM
awight subscribed.

The patch looks great, but perhaps we want to point to local wiki pages in DonationInterface.php?

• atgo unsubscribed.Mar 30 2016, 10:05 PM
• DStrine removed a project: Fundraising-Backlog-Old.Aug 5 2016, 8:40 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 5 2016, 8:40 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:38 PM
Framawiki moved this task from Backlog to Doing on the good first task board.Dec 2 2017, 1:39 PM
Ejegg added a project: Fundraising Sprint Owls.Jul 31 2018, 1:26 AM
Ejegg set the point value for this task to 2.
Ejegg moved this task from FY 2022-2023 to Current Sprint on the Fundraising-Backlog board.

Moving this into sprint - it's the only sane way to wrangle all the URLs

gerritbot added a comment.Jul 31 2018, 3:37 PM

Change 449477 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Parameterize 'Donor Policy' URL in messages

https://gerrit.wikimedia.org/r/449477

gerritbot added a comment.Jul 31 2018, 4:00 PM

Change 449480 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Escape special chars in Mustache URL params

https://gerrit.wikimedia.org/r/449480

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Owls board.Jul 31 2018, 6:36 PM
Ejegg claimed this task.Jul 31 2018, 6:39 PM
Ejegg triaged this task as Medium priority.
Ejegg added subscribers: MBeat33, Pcoombe.

@MBeat33 Is there any real difference between the donate@ and problemsdonating@ email addresses? We've got problemsdonating@ in the config now, but donate@ is used in some of the i18n messages.

@Pcoombe are you using the message donate_interface-easydonate anywhere on donatewiki? I'm hoping to change it to take the email address as a parameter rather than an embedded part of the message.

MBeat33 added a comment.Jul 31 2018, 6:54 PM

Thanks, @Ejegg problemsdonating@ is an old delegated Gmail account - retiring it is on my TDL. Messages sent to both addresses should reach Zendesk. But we still review the spam folders at Gmail periodically to forward anything useful to Zendesk that gets stuck there. Basically, donate@ is more active and more recent, so is always a better option to use.

Ejegg moved this task from Doing to Review on the Fundraising Sprint Owls board.Jul 31 2018, 8:23 PM
gerritbot added a comment.Jul 31 2018, 8:54 PM

Change 449610 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Fix error msg with otherways URL, add instructions

https://gerrit.wikimedia.org/r/449610

gerritbot added a comment.Jul 31 2018, 10:11 PM

Change 449474 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Parameterize 'Other ways to give' URL in messages

https://gerrit.wikimedia.org/r/449474

gerritbot added a comment.Jul 31 2018, 10:11 PM

Change 449477 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Parameterize 'Donor Policy' URL in messages

https://gerrit.wikimedia.org/r/449477

gerritbot added a comment.Jul 31 2018, 10:12 PM

Change 449480 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Escape special chars in Mustache URL params

https://gerrit.wikimedia.org/r/449480

gerritbot added a comment.Jul 31 2018, 10:36 PM

Change 449610 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Fix error msg with otherways URL, add instructions

https://gerrit.wikimedia.org/r/449610

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Jul 31 2018, 11:00 PM
Pcoombe added a comment.Aug 1 2018, 1:40 PM
In T108699#4466461, @Ejegg wrote:

@Pcoombe are you using the message donate_interface-easydonate anywhere on donatewiki? I'm hoping to change it to take the email address as a parameter rather than an embedded part of the message.

We're not using that anywhere. Thanks for checking!

Pcoombe added a comment.Aug 1 2018, 1:42 PM
In T108699#4466564, @MBeat33 wrote:

Thanks, @Ejegg problemsdonating@ is an old delegated Gmail account - retiring it is on my TDL. Messages sent to both addresses should reach Zendesk. But we still review the spam folders at Gmail periodically to forward anything useful to Zendesk that gets stuck there. Basically, donate@ is more active and more recent, so is always a better option to use.

That's good to know @MBeat33. We still use problemsdonating@ on https://donate.wikimedia.org/wiki/Problems_donating, I'll see about changing it.

MBeat33 added a comment.Aug 1 2018, 2:03 PM

Thank you, @Pcoombe, I was hoping we could fix that - much appreciated.

gerritbot added a comment.Aug 1 2018, 7:35 PM

Change 449799 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Parameterize support email in messages

https://gerrit.wikimedia.org/r/449799

Ejegg added a comment.EditedAug 1 2018, 7:37 PM

@Pcoombe OK, here's the final list of messages that will need to take the email as a parameter in the future:

donate_interface-processing-error (most common error message in DonationInterface)
donate_interface-error-no-form (used in GatewayFormChooser)
donate_interface-question-comment (can't find usage in DonationInterface)
donate_interface-monthly-cancel (used in mustache)
donate_interface-easydonate (can't find usage, pcoombe says not on donatewiki)
donate_interface-unsub-delay (used in unsub extension, usage already sends param)
donate_interface-unsub-fail (ditto)
donate_interface-unsub-warning (ditto)
donate_interface-bank_transfer_message (used in lame HTML generation)

gerritbot added a comment.Aug 1 2018, 10:21 PM

Change 449799 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Parameterize support email in messages

https://gerrit.wikimedia.org/r/449799

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Owls board.Aug 3 2018, 2:44 AM
Pcoombe added a comment.Aug 6 2018, 2:09 PM

Thanks @Ejegg. We use donate_interface-monthly-cancel in donatewiki, I've added the email parameter there ready.

There's a list of all the DonationInterface messages used in banners and donatewiki at T166346

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Owls board.Aug 6 2018, 11:50 PM
Ejegg closed this task as Resolved.Aug 7 2018, 8:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL