Page MenuHomePhabricator
Create Task
Maniphest T109556

ApiQueryContentTranslation not respecting the limit parameter
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

ApiQueryContentTranslation is a ApiQueryGeneratorBase type class. But it does not take limit parameter as of now. It outputs all translations in one go. If the user has lot of translations, this will result a long list rendered in one go, with all api hits for images starting. This is not ideal since 100 such translations will initiate a 100 api hits for image/descriptions. We need to paginate it for example, load 10 translation and then while page scrolls load next set etc.

The dashboard loading should be fast as much as possible

Details

SubjectRepoBranchLines +/-
Dashboard: Show empty list information when suggestions or translations are emptymediawiki/extensions/ContentTranslationmaster+57 -34
API: Support limit and offset params for suggestion and translation queriesmediawiki/extensions/ContentTranslationmaster+92 -6
Implement limit parameter in ApiQueryContentTranslationmediawiki/extensions/ContentTranslationmaster+48 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

• santhosh created this task.Aug 19 2015, 6:02 AM
• santhosh raised the priority of this task from to High.
• santhosh updated the task description. (Show Details)
• santhosh added projects: Technical-Debt, ContentTranslation, LE-CX6-Sprint 3.
• santhosh subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 6:02 AM
• santhosh added a project: ContentTranslation-Release6.Aug 19 2015, 6:02 AM
• santhosh set Security to None.
Amire80 moved this task from Needs Triage to CX6 on the ContentTranslation board.Aug 19 2015, 7:07 AM
Amire80 moved this task from Backlog to Bugs on the ContentTranslation-Release6 board.Aug 19 2015, 8:19 AM
Arrbee added a parent task: T87439: [Tracking] Suggest articles to translate from the dashboard.Aug 19 2015, 8:24 AM
leila added a project: GapFinder.Aug 19 2015, 4:25 PM
leila removed a project: GapFinder.Aug 20 2015, 7:43 PM
Arrbee lowered the priority of this task from High to Medium.Aug 26 2015, 12:21 PM
Arrbee subscribed.
Arrbee assigned this task to Nikerabbit.Sep 2 2015, 7:13 AM
Arrbee raised the priority of this task from Medium to High.
Nikerabbit lowered the priority of this task from High to Medium.Sep 3 2015, 12:52 PM
Nikerabbit moved this task from Backlog to In Review on the LE-CX6-Sprint 3 board.
Nikerabbit edited a custom field.
gerritbot subscribed.Sep 3 2015, 12:59 PM

Change 235720 had a related patch set uploaded (by Nikerabbit):
Implement limit parameter in ApiQueryContentTranslation

https://gerrit.wikimedia.org/r/235720

gerritbot added a project: Patch-For-Review.Sep 3 2015, 12:59 PM
gerritbot added a comment.Sep 7 2015, 5:32 AM

Change 235720 merged by jenkins-bot:
Implement limit parameter in ApiQueryContentTranslation

https://gerrit.wikimedia.org/r/235720

Amire80 mentioned this in rECTX0c3164856310: Implement limit parameter in ApiQueryContentTranslation.Sep 7 2015, 5:32 AM
Diffusion mentioned this in rMEXT17742b88fc23: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 7 2015, 5:32 AM
• santhosh added a comment.Sep 7 2015, 5:45 AM

https://gerrit.wikimedia.org/r/235720 merged, that means, we show 100 items in the page now. Once we are done with refactorings of https://gerrit.wikimedia.org/r/#/c/232019/ we can proceed with 'infinite scroll' to load the remaining translations.

ReleaseTaggerBot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 7 2015, 6:00 AM
Arrbee edited projects, added LE-CX6-Sprint 4; removed LE-CX6-Sprint 3.Sep 9 2015, 6:37 AM
Arrbee moved this task from Backlog to In Review on the LE-CX6-Sprint 4 board.Sep 9 2015, 6:40 AM
Nikerabbit added a project: OKR-Work.Sep 9 2015, 7:26 AM
Nikerabbit moved this task from In Review to Blocked on the LE-CX6-Sprint 4 board.Sep 9 2015, 11:44 AM
Arrbee moved this task from Blocked to In Progress on the LE-CX6-Sprint 4 board.Sep 11 2015, 7:02 AM
Nikerabbit added a project: Essential-Work.Sep 15 2015, 7:13 AM
gerritbot added a comment.Sep 22 2015, 3:48 AM

Change 239322 had a related patch set uploaded (by Santhosh):
API: Support limit and offset params for suggestion and translation queries

https://gerrit.wikimedia.org/r/239322

gerritbot added a comment.Sep 22 2015, 10:54 AM

Change 239322 merged by jenkins-bot:
API: Support limit and offset params for suggestion and translation queries

https://gerrit.wikimedia.org/r/239322

• santhosh mentioned this in rECTXc685547167ca: API: Support limit and offset params for suggestion and translation queries.Sep 22 2015, 10:54 AM
Diffusion mentioned this in rMEXT7cee07b73757: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 22 2015, 10:54 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 22 2015, 11:00 AM
Arrbee added a project: LE-CX6-Sprint break.Sep 23 2015, 7:26 AM
Arrbee moved this task from Backlog to In Progress on the LE-CX6-Sprint break board.
• santhosh moved this task from In Progress to In Review on the LE-CX6-Sprint break board.Sep 23 2015, 12:15 PM
Arrbee removed a project: Essential-Work.Sep 28 2015, 7:10 AM
gerritbot added a comment.Sep 28 2015, 7:11 AM

Change 240068 had a related patch set uploaded (by Nikerabbit):
Dashboard: Show empty list information when suggestions or translations are empty

https://gerrit.wikimedia.org/r/240068

Nikerabbit moved this task from In Review to QA on the LE-CX6-Sprint break board.Sep 30 2015, 9:05 AM
gerritbot added a comment.Sep 30 2015, 9:07 AM

Change 240068 merged by jenkins-bot:
Dashboard: Show empty list information when suggestions or translations are empty

https://gerrit.wikimedia.org/r/240068

• santhosh mentioned this in rMEXTf4b1f2fd607b: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 30 2015, 9:09 AM
Nikerabbit mentioned this in rECTX0246d316cf20: Dashboard: Show empty list information when suggestions or translations are….Sep 30 2015, 9:09 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 10:01 AM
Arrbee added a comment.Sep 30 2015, 12:21 PM

Verified that the list is loaded in sets as the user scrolls and reaches the end of the suggestions

Arrbee moved this task from QA to Done on the LE-CX6-Sprint break board.Sep 30 2015, 12:21 PM
• santhosh closed this task as Resolved.Oct 6 2015, 9:31 AM
Arrbee moved this task from In Progress to Done on the LE-CX6-Sprint 4 board.Oct 7 2015, 4:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL