AuthManager should retain the MobileFrontend watermark at the top of the login screen
Closed, ResolvedPublic
Actions

Description

See parent task and T110431#1604967. Might well be a no-op now that it doesn't replace the login form.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	REL1_27	+38 -7	Update for AuthManager
	mediawiki/extensions/MobileFrontend	master	+38 -7	Update for AuthManager

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Deskana	T75616 Tracking: API/backend issues blocking Wikipedia app development
Resolved		Anomie	T32788 Allow triggering of user password reset email via the API
Open		None	T90925 General authentication improvements for MediaWiki
Resolved		Anomie	T48179 Allow a challenge stage during authentication
Open		None	T5709 Refactoring to make external authentication and identity systems easier
Resolved		Tgr	T43201 UserLoadFromSession considered evil
Resolved		Anomie	T67493 Session is started by EditAction (problem for extensions using UserLoadFromSession hook)
Open	Feature	None	T55156 Provide option to force a login session to end within a certain time
Open		None	T89459 Modernize MediaWiki authentication system (AuthManager)
Open		None	T110291 Update all extensions to use AuthManager
Resolved		demon	T135498 Release AuthManager with MediaWiki 1.27
Resolved		Tgr	T138910 Backport AuthManager-related changes to 1.27
Resolved		None	T130340 [Reading Infrastructure 2015-16 Q4] Enable two-factor authentication via AuthManager on the Wikimedia cluster
Resolved		• Mattflaschen-WMF	T68699 Increase "remember me" login cookie expiry from 30 days to 1 year on Wikimedia wikis
Resolved		Tgr	T135504 Enable AuthManager in WMF production
Resolved		Anomie	T110282 Update extensions which are deployed on the Wikimedia cluster to use AuthManager
Resolved		Tgr	T111483 AuthManager should retain the MobileFrontend watermark at the top of the login screen

Event Timeline

Tgr created this task.Sep 4 2015, 2:52 AM

Tgr raised the priority of this task from to Medium.

Tgr updated the task description. (Show Details)

Tgr added projects: Reading-Infrastructure-Team-Old (Don't use), MediaWiki-Authentication-and-authorization, MobileFrontend.

Tgr added subscribers: Aklapper, Tgr.

Liuxinyu970226 set Security to None.Sep 4 2015, 9:25 AM

Liuxinyu970226 added a subscriber: Liuxinyu970226.

bd808 moved this task from Backlog to AuthManager Backlog on the MediaWiki-Authentication-and-authorization board.Sep 9 2015, 4:17 PM

We only use the normal login page so if there is an issue here it is in the mediawiki login form (e.g. it doesn't load JavaScript with the right target)

Let me know if there is anything specific you need done in the extension!

The only thing that looks suspicious is that you're using the UserLoginForm and UserCreateForm hooks. These hooks are deprecated under AuthManager, so it would be good to move away from using them.

All those hooks do is add an image to the top of the form. This is important as it gives context to where you are logging in.

<div class="watermark"><img src="$1"></div>
where $1 is the value of $wgMobileFrontendLogo

If you are deprecating these, you need to provide a new way to add that image. I consider that a blocker to rolling this out.

• Jdlrobson renamed this task from Make sure MobileFrontend works with AuthManager to AuthManager should retain the MobileFrontend watermark at the top of the login screen.May 11 2016, 9:13 PM

Change 288334 had a related patch set uploaded (by Gergő Tisza):
Update for AuthManager

https://gerrit.wikimedia.org/r/288334

gerritbot added a project: Patch-For-Review.May 11 2016, 11:55 PM

Change 288334 merged by jenkins-bot:
Update for AuthManager

https://gerrit.wikimedia.org/r/288334

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-05-17_(1.28.0-wmf.2)).May 17 2016, 2:00 AM

Anomie closed this task as Resolved.May 17 2016, 4:10 PM

Anomie assigned this task to Tgr.

Liuxinyu970226 removed a subscriber: Liuxinyu970226.May 19 2016, 5:12 AM

Change 296508 had a related patch set uploaded (by Gergő Tisza):
Update for AuthManager

https://gerrit.wikimedia.org/r/296508

Change 296508 merged by jenkins-bot:
Update for AuthManager