Page MenuHomePhabricator
Create Task
Maniphest T112168

Notification icon flashes from white to black to white
Closed, ResolvedPublic
Actions

Description

I see this on pages that have an enabled Flow board, like for instance:
https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Flow/Developer_test_page

If I have a new message (and only then), the icon on the red badge flashes from white to black to white.

Screenshot of it happening (ignore the pink background, that's intentional):

Screen Shot 2015-09-10 at 16.55.35.png (1×2 px, 887 KB)

Details

SubjectRepoBranchLines +/-
Avoid flashes: late debounce causes annoying flashesmediawiki/extensions/Echowmf/1.26wmf22+5 -0
Avoid flashes: late debounce causes annoying flashesmediawiki/extensions/Echomaster+5 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

TheDJ created this task.Sep 10 2015, 8:30 PM
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added projects: Notifications, StructuredDiscussions.
TheDJ subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 10 2015, 8:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TheDJ added a comment.Sep 10 2015, 8:37 PM

on second try, it seems that i have it on all pages, it's just infinitely faster on non Flow pages, so that I hardly notice the flash

Legoktm renamed this task from Notification icon flashes from white to black to white on Flow boards to Notification icon flashes from white to black to white.Sep 10 2015, 11:59 PM
Legoktm merged a task: T112215: Icons in the notifications bar flash black while page is loading.
Legoktm set Security to None.
Legoktm added a parent task: T112104: Echo icon FOUC (tracking).
Legoktm added subscribers: Mooeypoo, • Deskana.
• Deskana updated the task description. (Show Details)Sep 11 2015, 12:04 AM
• Tbayer subscribed.Sep 11 2015, 6:10 AM

I've seen the same thing happening on e.g. https://en.wikipedia.org/wiki/Main_Page .

Josve05a subscribed.Sep 11 2015, 7:13 AM

sv.wp is complaining (as a collective) about this.

Legoktm subscribed.Sep 11 2015, 7:49 AM

This affects all skins except MonoBook (which used to have a different flashing problem...T111821).

gerritbot subscribed.Sep 11 2015, 11:09 AM

Change 237619 had a related patch set uploaded (by Esanders):
Avoid flashes: late debounce causes annoying flashes

https://gerrit.wikimedia.org/r/237619

gerritbot added a project: Patch-For-Review.Sep 11 2015, 11:09 AM
gerritbot added a comment.Sep 11 2015, 11:13 AM

Change 237619 merged by jenkins-bot:
Avoid flashes: late debounce causes annoying flashes

https://gerrit.wikimedia.org/r/237619

eranroz mentioned this in rMEXTbace4532306c: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 11 2015, 11:13 AM
Esanders mentioned this in rECHO381b7be7d83f: Avoid flashes: late debounce causes annoying flashes.Sep 11 2015, 11:13 AM
eranroz closed this task as Resolved.Sep 11 2015, 11:40 AM
eranroz claimed this task.
Aklapper mentioned this in T108190: Split notifications into Alerts and Messages.Sep 11 2015, 11:57 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 11 2015, 12:00 PM
gerritbot added a comment.Sep 11 2015, 3:29 PM

Change 237673 had a related patch set uploaded (by Legoktm):
Avoid flashes: late debounce causes annoying flashes

https://gerrit.wikimedia.org/r/237673

gerritbot added a comment.Sep 11 2015, 4:15 PM

Change 237673 merged by jenkins-bot:
Avoid flashes: late debounce causes annoying flashes

https://gerrit.wikimedia.org/r/237673

Diffusion mentioned this in rMW20b349ebc707: Updated mediawiki/core Project: mediawiki/extensions/Echo….Sep 11 2015, 4:15 PM
Legoktm mentioned this in rECHO36ef13631462: Avoid flashes: late debounce causes annoying flashes.Sep 11 2015, 4:15 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 11 2015, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL