Currently, adding Bug: T123 to the commit message of a Gerrit change will add a tag "Patch-For-Review" to the related task. Great!
However, the tag stays when the patch is not under review anymore, even because it has been merged or abandoned. What would be the right solution? Just remove the Patch-For-Review tag or change it for another one?
Current behavior in Bugzilla is not doing anything with the 'PATCH_TO_REVIEW' status and leave it to the humans. However, it's no longer a status in Phab, so 'removing' is a more reasonable option.
Potential issue to think of when removing the tag: are there other patches which also are related to that bug still under review?
True, in Bugzilla the update is left for humans. Setting Low priority, then (only because I'm trying to keep as "Normal" only the tasks that require quick attention in Phabricator right after the Bugzilla migration).
the tag stays when the patch is not under review anymore, even because it has been merged or abandoned. What would be the right solution?
Very personal opinion: Waiting until we use Differential, because writing some custom code trying to keep track of the number of related changesets in Gerrit which have not yet been merged or abandoned and hence are still waiting for review does not sound like the best use of developer time. :)
I agree with Aklapper that keeping track of the number of related changes is not worth it.
If for the majority of people a task has only one related change, it wouldn't need too much coding work to drop the Patch-For-Review upon each merging/abandoning of a related change. That would do the ideal thing, if a task has only one related change. But it would be counter-intuitive, if most tasks have more than one related change.
Not sure.
Agreed. The current behavior is sensible. The real thing will come with the activation of Differential.
If it doesnt involve too much work, it would be nice to replicate the Bugzilla behaviour, where patch-for-review was a status. When the task is closed, the tag should be removed.
I'm strongly against this because removing that status once we have Differential will be complicated.
(Plus discussion is offtopic here and happened in T212.)
When the task is closed, the tag should be removed.
Not sure which specific steps you perform that you consider the tag a problem for closed tasks.
I dont do anything, except read emails consisting of someone else removing the tag, often long after the task has been closed.
can this be solved with herald?
also I don't think it would be too fragile for the bot to enumerate all the gerrit links on a task and check them all to see if any are still open. if none are open then remove the project.
I wrote a script that does this. I'll finish the getting token (T224099: Request for conduit token of Phabricator_maintenance user) and then run it everywhere and put it on cronjob to run it every hour or so for patches that has been changed in the last hour.