- cx-first-translation
- cx-tenth-translation
- cx-hundredth-translation
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T98880 Improve OAuth management interface | |||
Open | None | T125653 Create new types of notifications | |||
Resolved | Feature | Tgr | T61772 Add notification to inform oauthadmins that a new consumer request is waiting | ||
Resolved | Tgr | T62528 Notify owners when an OAuth app changes state | |||
Duplicate | None | T120100 Add Echo notifications to OAuth | |||
Resolved | Catrope | T116834 Write presentation models for all notification types | |||
Resolved | Mooeypoo | T116852 Write presentation models for notifications in ContentTranslation |
Event Timeline
Hmm, I'm not familiar with presentation models.
Is this supposed to be done in CX code or in Echo code or elsewhere?
Sorry for not providing much information. "Presentation models" are a thing in the newly rewritten notification formatter system in Echo. Documentation (WIP for now) is/will be at https://www.mediawiki.org/wiki/Echo_%28Notifications%29/New_formatter_system .
Is this supposed to be done in CX code or in Echo code or elsewhere?
It's CX code interfacing with Echo. We're going around and doing this conversion in all extensions that use Echo, we'd be happy to do the CX conversion ourselves as well.
Change 256372 had a related patch set uploaded (by Mooeypoo):
Convert notification to the new Echo Notifications Model
Change 256372 merged by jenkins-bot:
Convert notification to the new Echo Notifications Model
Change 256469 had a related patch set uploaded (by Mooeypoo):
FOLLOWUP I80edee5f0: Move Echo presentation model into CX namespace
@santhosh, thanks for the quick merge!
I actually made a little tiny booboo with this commit; I didn't notice that I wasn't using the ContentTranslation namespace, and as a result, the class name I used is way (waaay) too general and could potentially conflict at some point with other Echo notification model classes.... oops. Sorry about that!
I submitted a second patch to fix this -- my apologies for a silly mistake :)
Change 256469 merged by jenkins-bot:
FOLLOWUP I80edee5f0: Move Echo presentation model into CX namespace