Page MenuHomePhabricator

Convert Special:ProtectedPages to OOUI
Closed, ResolvedPublic

Description

The form (from an implementation point of view) doesn't look sooo difficult, it should be possible using the HorizontalLayout.

Before

Screen Shot 2018-03-26 at 1.52.14 PM.png (524×2 px, 96 KB)

After

Screen Shot 2018-04-20 at 9.28.19 AM.png (852×2 px, 105 KB)

Event Timeline

Florian raised the priority of this task from to Medium.
Florian updated the task description. (Show Details)
Florian added a project: UI-Standardization.

Change 376710 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] [WIP] Special:ProtectedPage: Use HTMLForm

https://gerrit.wikimedia.org/r/376710

@matmarex Separating the HTMLForm conversion and OOUI conversion into different patches this time. Your input would be helpful :)

Change 376710 merged by jenkins-bot:
[mediawiki/core@master] Special:ProtectedPages: Use HTMLForm

https://gerrit.wikimedia.org/r/376710

Do we want to do this now?

Old

Screen Shot 2018-03-26 at 1.52.14 PM.png (524×2 px, 96 KB)

New

Screen Shot 2018-03-26 at 1.52.03 PM.png (974×2 px, 116 KB)

@Prtksxna Looks mostly good! Yet we should make the bytes input smaller… We can also make this in a follow-up patch.

Change 422367 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] Special:ProtectedPages: Convert to OOUI

https://gerrit.wikimedia.org/r/422367

It's almost twice as big. I would love to have checkboxes in one line instead of mulitple lines.

It's almost twice as big. I would love to have checkboxes in one line instead of mulitple lines.

Makes sense, let's use a HTMLMultiSelectField here instead.

Change 424193 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] Special:ProtectedPages: Use MultiSelectField instead of checks

https://gerrit.wikimedia.org/r/424193

Change 424193 merged by jenkins-bot:
[mediawiki/core@master] Special:ProtectedPages: Use MultiSelectField instead of checks

https://gerrit.wikimedia.org/r/424193

After switching to MultiSelectField:

Screen Shot 2018-04-20 at 9.28.19 AM.png (852×2 px, 105 KB)

Change 422367 merged by jenkins-bot:
[mediawiki/core@master] Special:ProtectedPages: Convert to OOUI

https://gerrit.wikimedia.org/r/422367