Page MenuHomePhabricator
Create Task
Maniphest T117742

Convert Special:Tags to OOUI
Closed, ResolvedPublic
Actions

Description

Uses HTMLForm already.

Details

SubjectRepoBranchLines +/-
Converted Special:Tags to OOUImediawiki/coremaster+4 -4
Change Special:Tags to OOUImediawiki/coremaster+1 -1
Change all HTMLforms on Special:Tags including delete and deactivate for ooui]mediawiki/coremaster+4 -4
Changed #$form = new HTMLForm to HTMLForm 'ooui'mediawiki/coremaster+2 -1
Changed Special_Tags to OOuimediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Florian created this task.Nov 4 2015, 5:29 PM
Florian raised the priority of this task from to Medium.
Florian updated the task description. (Show Details)
Florian added a project: UI-Standardization.
Florian added subscribers: Ricordisamoa, Legoktm, Jdforrester-WMF and 4 others.
Volker_E moved this task from Unsorted to Conversion to OOUI on the UI-Standardization board.Jan 18 2016, 11:22 PM
Dips03 subscribed.Mar 12 2016, 8:59 AM
Dips03 unsubscribed.Mar 12 2016, 9:01 AM
sukeesh subscribed.Mar 12 2016, 9:04 AM
vaishali_jain claimed this task.Mar 12 2016, 11:06 AM
gerritbot subscribed.Mar 12 2016, 11:37 AM

Change 276954 had a related patch set uploaded (by Pankajeshkr):
Changed Special_Tags to OOui

https://gerrit.wikimedia.org/r/276954

gerritbot added a project: Patch-For-Review.Mar 12 2016, 11:37 AM
gerritbot added a comment.Mar 12 2016, 11:59 AM

Change 276957 had a related patch set uploaded (by Utk95):
Changed #$form = new HTMLForm to HTMLForm 'ooui'

https://gerrit.wikimedia.org/r/276957

gerritbot added a comment.Mar 14 2016, 11:39 AM

Change 276951 had a related patch set uploaded (by 01tonythomas):
Change Special:Tags to OOUI

https://gerrit.wikimedia.org/r/276951

gerritbot added a comment.Mar 14 2016, 12:28 PM

Change 276954 abandoned by Pankajeshkr:
Changed Special_Tags to OOui

https://gerrit.wikimedia.org/r/276954

gerritbot added a comment.Mar 14 2016, 1:36 PM

Change 276970 had a related patch set uploaded (by 01tonythomas):
Change all HTMLforms on Special:Tags including delete and deactivate for ooui]

https://gerrit.wikimedia.org/r/276970

gerritbot added a comment.Apr 4 2016, 12:15 PM

Change 276957 abandoned by Bartosz Dziewoński:
Changed #$form = new HTMLForm to HTMLForm 'ooui'

Reason:
Duplicate of https://gerrit.wikimedia.org/r/#/c/276951/

https://gerrit.wikimedia.org/r/276957

matmarex added a comment.Apr 4 2016, 1:48 PM

Remaining non-abandoned changes:

matmarex unsubscribed.Apr 4 2016, 1:48 PM
Jdlrobson added a project: Patch-Needs-Improvement.May 10 2016, 8:04 PM
01tonythomas added subscribers: matmarex, 01tonythomas.Dec 15 2016, 3:25 PM

Possible Google-Code-In-2016 task ? To complete those changes ? @matmarex -- thinking of mentoring ? :D

01tonythomas added a project: Google-Code-In-2016.Dec 17 2016, 8:41 AM

I'm adding in the GCI tag and moving this to 'missing-mentors' there.

01tonythomas moved this task from Proposed tasks to Missing mentors on the Google-Code-In-2016 board.Dec 17 2016, 8:41 AM
Aklapper added a comment.Dec 31 2016, 8:03 PM

Wondering if @Florian or @Legoktm (once available) could imagine mentoring this in GCI...?

gerritbot added a comment.Jan 1 2017, 3:55 PM

Change 276970 abandoned by Florianschmidtwelzow:
Change all HTMLforms on Special:Tags including delete and deactivate for ooui]

Reason:
See https://gerrit.wikimedia.org/r/#/c/276951/

https://gerrit.wikimedia.org/r/276970

Florian removed vaishali_jain as the assignee of this task.Jan 1 2017, 3:58 PM
Florian moved this task from Missing mentors to Imported in GCI Site on the Google-Code-In-2016 board.
Florian added a subscriber: vaishali_jain.

As the change https://gerrit.wikimedia.org/r/#/c/276951/2 is untouched since March last year, I unassign the task from @vaishali_jain and imported it as a GCI task (which I'll mentor): https://codein.withgoogle.com/dashboard/tasks/5836115925794816/

gerritbot added a comment.Jan 2 2017, 2:04 AM

Change 330083 had a related patch set uploaded (by Awu42):
Converted Special:Tags to OOUI

https://gerrit.wikimedia.org/r/330083

Volker_E subscribed.Jan 2 2017, 11:28 PM

Please provide a before/after screenshot!

gerritbot added a comment.Jan 3 2017, 9:30 AM

Change 276951 abandoned by TTO:
Change Special:Tags to OOUI

Reason:
Done in https://gerrit.wikimedia.org/r/330083

https://gerrit.wikimedia.org/r/276951

gerritbot added a comment.Jan 3 2017, 9:36 AM

Change 330083 merged by jenkins-bot:
Converted Special:Tags to OOUI

https://gerrit.wikimedia.org/r/330083

TTO closed this task as Resolved.Jan 3 2017, 9:39 AM
TTO assigned this task to Awu42.
TTO subscribed.

Tags OOUI.png (934×1 px, 65 KB)

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)).Jan 3 2017, 10:00 AM
TheDJ subscribed.EditedJan 3 2017, 12:14 PM

I think we should move the "create a new tag" interface into a special /create subpage. The form has no direct connection with the primary function of the special page, which is to list the known tags and we already do so for /delete, activate and deactivate actions

• JGirault subscribed.Jan 3 2017, 1:44 PM
In T117742#2912391, @TheDJ wrote:

I think we should move the "create a new tag" interface into a special /create subpage. The form has no direct connection with the primary function of the special page, which is to list the known tags and we already do so for /delete, activate and deactivate actions

I think this makes sense.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL