Page MenuHomePhabricator
Create Task
Maniphest T118637

Add feature flag to disable Special:UsersWhoWillBeRenamed and use on WMF cluster
Closed, ResolvedPublic
Actions

Description

Add a feature flag that enables/disables Special:UsersWhoWillBeRenamed (https://meta.wikimedia.org/wiki/Special:UsersWhoWillBeRenamed) on a per-wiki basis. Set that feature flag to disable the feature for WMF managed wikis.

It is empty and the sulfinalistion (renaming accounts) seems done.

Details

SubjectRepoBranchLines +/-
Add feature flag for Special:UsersWhoWillBeRenamedmediawiki/extensions/CentralAuthmaster+19 -2
Remove Special:UsersWhoWillBeRenamed and related codemediawiki/extensions/CentralAuthmaster+0 -806
Customize query in gerrit

Event Timeline

Steinsplitter created this task.Nov 14 2015, 11:24 AM
Steinsplitter raised the priority of this task from to Needs Triage.
Steinsplitter updated the task description. (Show Details)
Steinsplitter added a project: GlobalRename.
Steinsplitter added subscribers: Steinsplitter, Legoktm.
Restricted Application added a project: MediaWiki-extensions-CentralAuth. · View Herald TranscriptNov 14 2015, 11:24 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Steinsplitter updated the task description. (Show Details)Nov 14 2015, 11:24 AM
Steinsplitter set Security to None.
Steinsplitter updated the task description. (Show Details)
Keegan subscribed.Jan 13 2016, 9:24 PM

Agreed, time to remove it.

Keegan triaged this task as Medium priority.Jan 13 2016, 9:24 PM
Keegan moved this task from Backlog to Review requested on the GlobalRename board.Jan 13 2016, 9:43 PM
gerritbot subscribed.Jan 28 2016, 10:27 PM

Change 267162 had a related patch set uploaded (by BryanDavis):
Remove Special:UsersWhoWillBeRenamed and related code

https://gerrit.wikimedia.org/r/267162

gerritbot added a project: Patch-For-Review.Jan 28 2016, 10:27 PM
gerritbot added a comment.Jan 31 2016, 5:35 PM

Change 267162 abandoned by BryanDavis:
Remove Special:UsersWhoWillBeRenamed and related code

Reason:
Per Lagoktm this is not the desired approach.

https://gerrit.wikimedia.org/r/267162

bd808 renamed this task from Remove Special:UsersWhoWillBeRenamed to Add feature flag to disable Special:UsersWhoWillBeRenamed and use on WMF cluster.Jan 31 2016, 5:38 PM
bd808 updated the task description. (Show Details)
gerritbot added a comment.Jan 31 2016, 5:57 PM

Change 267550 had a related patch set uploaded (by BryanDavis):
Add feature flag for Special:UsersWhoWillBeRenamed

https://gerrit.wikimedia.org/r/267550

Keegan added a subscriber: Billinghurst.Feb 1 2016, 10:29 PM

@Billinghurst @Steinsplitter this will be switched off with this week's deploy.

Billinghurst unsubscribed.Feb 2 2016, 10:16 AM
TTO added subscribers: Billinghurst, TTO.Feb 19 2016, 11:19 AM
In T118637#1987903, @Keegan wrote:

@Billinghurst @Steinsplitter this will be switched off with this week's deploy.

What happened to this?

Reedy subscribed.Feb 19 2016, 11:23 AM

Patch wasn't merged, so can't be disabled yet

MarcoAurelio subscribed.Mar 2 2016, 10:41 PM

It is useless to have this special page now that the SUL finalisation process is finished. What's blocking this?

Billinghurst unsubscribed.Mar 4 2016, 10:29 AM
gerritbot added a comment.Aug 21 2016, 3:27 AM

Change 267550 abandoned by BryanDavis:
Add feature flag for Special:UsersWhoWillBeRenamed

https://gerrit.wikimedia.org/r/267550

MarcoAurelio moved this task from Backlog to GlobalRename on the MediaWiki-extensions-CentralAuth board.Dec 18 2016, 10:36 PM
TerraCodes subscribed.Jul 17 2017, 1:05 AM
In T118637#2082056, @MarcoAurelio wrote:

It is useless to have this special page now that the SUL finalisation process is finished. What's blocking this?

What is blocking this?

Liuxinyu970226 subscribed.Jul 17 2017, 1:42 AM
TerraCodes added a subscriber: bd808.EditedDec 4 2017, 12:16 PM

@bd808 could you please restore you patch, since I don't have the option to? (https://gerrit.wikimedia.org/r/#/c/267550)

Aklapper added a comment.EditedDec 4 2017, 10:40 PM

@TerraCodes: In general, please provide reasons for requests. (The Gerrit patch has a reason why it was abandoned at that time.) Do you refer to T118637#2082056? If so, say so. :)

MarcoAurelio added a comment.Dec 5 2017, 2:04 PM
In T118637#3442398, @TerraCodes wrote:
In T118637#2082056, @MarcoAurelio wrote:

It is useless to have this special page now that the SUL finalisation process is finished. What's blocking this?

What is blocking this?

Is that a question for me? I'm afraid I don't have the answer, hence why I asked first the same question. I think @Legoktm knows?

TerraCodes added a comment.Dec 6 2017, 8:52 AM
In T118637#3812585, @MarcoAurelio wrote:
In T118637#3442398, @TerraCodes wrote:
In T118637#2082056, @MarcoAurelio wrote:

It is useless to have this special page now that the SUL finalisation process is finished. What's blocking this?

What is blocking this?

Is that a question for me? I'm afraid I don't have the answer, hence why I asked first the same question. I think @Legoktm knows?

Nah, I wasn't asking you, just curious what was blocking it, since your question didn't get answered. (that I saw)

TerraCodes added a comment.Dec 6 2017, 8:53 AM
In T118637#3810993, @Aklapper wrote:

@TerraCodes: In general, please provide reasons for requests. (The Gerrit patch has a reason why it was abandoned at that time.) Do you refer to T118637#2082056? If so, say so. :)

I'm asking if https://gerrit.wikimedia.org/r/#/c/267550 can be restored, since I'm unable to restore it. I see a reason on https://gerrit.wikimedia.org/r/#/c/267162/ but not on the patch I asked to be restored?

gerritbot added a comment.Dec 19 2017, 11:49 PM

Change 267550 restored by BryanDavis:
Add feature flag for Special:UsersWhoWillBeRenamed

Reason:
Per request of TerraCodes

https://gerrit.wikimedia.org/r/267550

TerraCodes added a comment.Dec 29 2017, 8:05 AM

Thanks~

TerraCodes claimed this task.Mar 22 2018, 10:47 PM
Quiddity subscribed.Jun 2 2018, 7:10 PM
MarcoAurelio added a comment.Jun 28 2018, 6:00 PM

While the patch looks good to me, I'd appreciate if somebody else could have a look at it. Thanks!

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)); removed Patch-For-Review.Jun 28 2018, 8:44 PM
Jdforrester-WMF subscribed.

Should deploy as expected to meta in a fortnight's time.

Jdforrester-WMF closed this task as Resolved.Jun 28 2018, 8:44 PM
gerritbot added a comment.Jun 29 2018, 5:45 AM

Change 267550 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Add feature flag for Special:UsersWhoWillBeRenamed

https://gerrit.wikimedia.org/r/267550

MarcoAurelio added a comment.Jun 29 2018, 5:48 AM

The patch suffered a jenkins-bot failure due to a lack of memory, but if have just passed now.

Liuxinyu970226 unsubscribed.Jul 1 2018, 2:12 PM
MarcoAurelio moved this task from Review requested to Closed on the GlobalRename board.Sep 1 2018, 12:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL