Page MenuHomePhabricator
Create Task
Maniphest T119537

Links in Flow topic titles: html code displayed when page scrolls up
Closed, ResolvedPublic
Actions

Description

Follow up for comment in T59153: Allow links in Flow topic titles

  • Have a title with a link in it
  • Scroll up - the link exposes html code:

Screen Shot 2015-11-20 at 1.34.41 PM.png (251×805 px, 38 KB)

Details

SubjectRepoBranchLines +/-
Show topic title in plaintext in ToCmediawiki/extensions/Flowmaster+137 -74
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Nov 24 2015, 6:10 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Etonkovidova subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 24 2015, 6:10 PM
Etonkovidova mentioned this in T59153: Allow links in Flow topic titles.Nov 24 2015, 6:11 PM
Etonkovidova added a comment.Dec 4 2015, 5:20 PM

For testing after the fix - look also at T120324: XSS in Flow topic titles to check for the XSS case, e.g.

<script>alert(1)</script>
Etonkovidova mentioned this in T120324: XSS in Flow topic titles.Dec 4 2015, 5:21 PM
SBisson claimed this task.Dec 7 2015, 3:57 PM
SBisson triaged this task as High priority.
SBisson set Security to None.
SBisson moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
gerritbot subscribed.Dec 8 2015, 3:14 PM

Change 257605 had a related patch set uploaded (by Sbisson):
Show topic title in plaintext in ToC

https://gerrit.wikimedia.org/r/257605

gerritbot added a project: Patch-For-Review.Dec 8 2015, 3:14 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Dec 8 2015, 3:24 PM
Catrope moved this task from Needs Review to Code Review Started on the Collaboration-Team-Archive-2015-2016 board.Dec 8 2015, 11:39 PM
SBisson moved this task from Code Review Started to In Development on the Collaboration-Team-Archive-2015-2016 board.Dec 9 2015, 4:53 PM
SBisson moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Dec 14 2015, 2:32 PM
gerritbot added a comment.Dec 14 2015, 9:49 PM

Change 257605 merged by jenkins-bot:
Show topic title in plaintext in ToC

https://gerrit.wikimedia.org/r/257605

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 14 2015, 10:00 PM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Dec 15 2015, 1:55 PM
SBisson merged a task: T121520: Raw HTML shown in the header.
SBisson added a subscriber: Yurik.
Etonkovidova added a comment.Dec 16 2015, 1:24 AM

Checked in betalabs - all links look correctly when a page scrolls up and a topic is displayed in ToC.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Dec 16 2015, 1:24 AM
Catrope closed this task as Resolved.Dec 16 2015, 1:57 AM
Catrope subscribed.
Catrope merged a task: T121622: Links on Flow topics title are displayed as rough HTML.Dec 16 2015, 4:11 PM
Catrope added subscribers: Trizek-WMF, Trizek.
Trizek-WMF removed a subscriber: Trizek.Dec 16 2015, 4:28 PM
Trizek-WMF added a project: User-notice.Dec 16 2015, 4:30 PM
Trizek-WMF moved this task from To Triage to Announce in next Tech/News on the User-notice board.
Trizek-WMF moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Dec 17 2015, 10:48 AM
Johan moved this task from In current Tech/News draft to Recently announced in Tech/News on the User-notice board.Jan 7 2016, 1:23 PM
Johan moved this task from Recently announced in Tech/News to Already announced/Archive on the User-notice board.Jan 12 2016, 9:49 AM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL