Page MenuHomePhabricator
Create Task
Maniphest T121596

[Regression wmf.9] Context menu for template and code block is broken, showing no "Edit" button and template name is showing up as "Item"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open a page
  2. Add a template
  3. Observe the context menu for it

Expected:
The context menu should mention the template name and an edit button.

Observed:
The context menu shows as "Item" only, without any indication, if it's a template, a code block or something else. There is no edit button, too. However, for some objects it's possible to edit it by double clicking it (depending if the object supports this).

Screen Shot 2015-12-15 at 3.22.22 PM.png (81×435 px, 11 KB)

Following types has the same problem:

  • Templates
  • Code blocks

While these seems to work very well:

  • Formulas
  • Images
  • Comments
  • Gallery
  • Hieroglyphics
  • Diagram
  • Reference list
  • Reference
  • Links

Details

SubjectRepoBranchLines +/-
Fix inheritance of ve.ui.MWSyntaxHighlightDialogToolmediawiki/extensions/SyntaxHighlight_GeSHiwmf/1.27.0-wmf.9+2 -2
Fix inheritance of ve.ui.MWTransclusionDialogToolmediawiki/extensions/VisualEditorwmf/1.27.0-wmf.9+5 -5
Fix inheritance of ve.ui.MWTransclusionDialogToolmediawiki/extensions/VisualEditormaster+5 -5
Fix inheritance of ve.ui.MWSyntaxHighlightDialogToolmediawiki/extensions/SyntaxHighlight_GeSHimaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Dec 15 2015, 11:26 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 15 2015, 11:26 PM
Ryasmeen renamed this task from [Regression wmf 9] Context menu for template is broken , showing no "Edit" button and template name is showing up as "Item" to [Regression wmf 9] Context menu for template and code block is broken , showing no "Edit" button and template name is showing up as "Item" .Dec 15 2015, 11:32 PM
Ryasmeen renamed this task from [Regression wmf 9] Context menu for template and code block is broken , showing no "Edit" button and template name is showing up as "Item" to [Regression wmf .9] Context menu for template and code block is broken , showing no "Edit" button and template name is showing up as "Item" .
Ryasmeen set Security to None.
Florian triaged this task as High priority.Dec 19 2015, 12:26 AM
Florian updated the task description. (Show Details)
Florian added a project: Contributors-Team.
Florian added a subscriber: Jdforrester-WMF.
Florian claimed this task.Dec 19 2015, 1:12 AM
Florian added a project: SyntaxHighlight.Dec 19 2015, 1:21 AM
gerritbot subscribed.Dec 19 2015, 1:23 AM

Change 260171 had a related patch set uploaded (by Florianschmidtwelzow):
Fix inheritance of ve.ui.MWTransclusionDialogTool

https://gerrit.wikimedia.org/r/260171

gerritbot added a project: Patch-For-Review.Dec 19 2015, 1:23 AM
gerritbot added a comment.Dec 19 2015, 1:26 AM

Change 260172 had a related patch set uploaded (by Florianschmidtwelzow):
Fix inheritance of ve.ui.MWSyntaxHighlightDialogTool

https://gerrit.wikimedia.org/r/260172

Krenair subscribed.Dec 19 2015, 3:44 AM
gerritbot added a comment.Dec 19 2015, 12:00 PM

Change 260171 merged by jenkins-bot:
Fix inheritance of ve.ui.MWTransclusionDialogTool

https://gerrit.wikimedia.org/r/260171

Esanders closed this task as Resolved.Dec 19 2015, 12:02 PM
Esanders subscribed.
gerritbot added a comment.Dec 19 2015, 12:03 PM

Change 260172 merged by jenkins-bot:
Fix inheritance of ve.ui.MWSyntaxHighlightDialogTool

https://gerrit.wikimedia.org/r/260172

Florian added a subscriber: • demon.Dec 19 2015, 12:33 PM

@Esanders: we have a long time no mediawiki train deployment, are we able to SWAT deploy this? It's really annoying to edit with VE and this bug. However, this isn't a security bug and doesn't result in data loss :/

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 19 2015, 1:00 PM
Krenair merged a task: T119843: Editing Infobox display.Dec 21 2015, 4:18 PM
Krenair added subscribers: • Elitre, Juandev, Inez, Lieutenant_Jade.
matmarex merged a task: T122066: The context menu for templates says "Item" and does not have an Edit button.Dec 21 2015, 7:06 PM
matmarex added a subscriber: • Whatamidoing-WMF.
matmarex subscribed.
gerritbot added a comment.Dec 21 2015, 7:54 PM

Change 260429 had a related patch set uploaded (by Alex Monk):
Fix inheritance of ve.ui.MWSyntaxHighlightDialogTool

https://gerrit.wikimedia.org/r/260429

gerritbot added a comment.Dec 21 2015, 7:55 PM

Change 260430 had a related patch set uploaded (by Alex Monk):
Fix inheritance of ve.ui.MWTransclusionDialogTool

https://gerrit.wikimedia.org/r/260430

gerritbot added a comment.Dec 21 2015, 8:12 PM

Change 260430 merged by jenkins-bot:
Fix inheritance of ve.ui.MWTransclusionDialogTool

https://gerrit.wikimedia.org/r/260430

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 21 2015, 9:00 PM
gerritbot added a comment.Dec 22 2015, 12:19 AM

Change 260429 merged by jenkins-bot:
Fix inheritance of ve.ui.MWSyntaxHighlightDialogTool

https://gerrit.wikimedia.org/r/260429

matmarex added a comment.Dec 22 2015, 1:48 AM

The fix was backported and deployed to all Wikimedia wikis today.

Aklapper renamed this task from [Regression wmf .9] Context menu for template and code block is broken , showing no "Edit" button and template name is showing up as "Item" to [Regression wmf .9] Context menu for template and code block is broken, showing no "Edit" button and template name is showing up as "Item".Dec 22 2015, 11:46 AM
• Elitre awarded a token.Dec 22 2015, 12:14 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jan 13 2016, 4:32 PM
Jdforrester-WMF moved this task from TR1: Releases to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF renamed this task from [Regression wmf .9] Context menu for template and code block is broken, showing no "Edit" button and template name is showing up as "Item" to [Regression wmf.9] Context menu for template and code block is broken, showing no "Edit" button and template name is showing up as "Item".Jan 19 2016, 1:07 AM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL