Phabricator diffusion fails markup rendering for large files
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Paladox
	Jan 5 2016, 10:23 AM

Description

Steps to reproduce

Go to https://phabricator.wikimedia.org/diffusion/OMWC/browse/master/wmf-config/

then click on file InitialiseSettings.php : https://phabricator.wikimedia.org/diffusion/OMWC/browse/master/wmf-config/InitialiseSettings.php

Actual results

it is coming up with this error:

>>> UNRECOVERABLE FATAL ERROR <<<

Maximum execution time of 10 seconds exceeded

/srv/phab/libphutil/src/markup/render.php:0


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

Expected results

It should be able to display the file. If syntax highlighting times out it should fallback to no highlighting.

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T122875 Phabricator diffusion fails markup rendering for large files
Resolved	• mmodell	T126797 Next Phabricator Upgrade - 2016-03-03
Resolved	• mmodell	T120013 Next Phabricator Upgrade - 2016-02-18
Resolved	• mmodell	T122556 Figure out what upstream "Can Edit Task Policies" policy deprecation means for our Spaces/ACL setup
Resolved	• DStrine	T123317 Report to TPG on new Phabricator Functionality
Resolved	• csteipp	T125104 Evaluate the feasibility of phasing out the Phabricator Security extension
Resolved	• ksmith	T127019 Plan announcement of new major phabricator upgrade

Event Timeline

Paladox created this task.Jan 5 2016, 10:23 AM

Paladox raised the priority of this task from to Needs Triage.

Paladox updated the task description. (Show Details)

Paladox subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptJan 5 2016, 10:23 AM

Paladox added projects: Phabricator, Diffusion.Jan 5 2016, 10:23 AM

Paladox set Security to None.

Restricted Application added subscribers: Luke081515, scfc. · View Herald TranscriptJan 5 2016, 10:23 AM

The poor markup renderer choke on InitialiseSettings.php which is too large.

hashar moved this task from To Triage to Misc on the Phabricator board.Jan 5 2016, 10:27 AM

Yes. Could we have a back for large files to only render them in black colour only if it's goes pass the 10 sec. Gitblit manages to load the file so we should do the same with phabricator.

hashar unsubscribed.Jan 5 2016, 12:51 PM

greg updated the task description. (Show Details)Jan 6 2016, 7:01 PM

This is likely fixed in HEAD by 91a01e5.

epriestley mentioned this in T120013: Next Phabricator Upgrade - 2016-02-18.Feb 12 2016, 4:18 AM

Aklapper added a subtask: T126797: Next Phabricator Upgrade - 2016-03-03.Feb 13 2016, 1:22 PM