|· · ·|
|Declined||None||T74907 [Task] move git repositories that are dependencies of wikidata to gerrit|
|Resolved||• Addshore||T173818 [Epic] Kill the Wikidata build step|
|Resolved||• Addshore||T173940 Add all wikidata build extensions to make-wmf-branch script|
|Resolved||• Addshore||T173942 Move all wikidata build extensions to gerrit|
|Resolved||WMDE-leszek||T180454 Sort out the mess that is the DataTypes extension / library / npm packages in order to kill the build|
|Resolved||Ladsgroup||T127292 [Task] Move DataTypes repository from Github to gerrit|
|· · ·|
Just a note from IRC earlier, this looks more like an extension than a library, and thus the repo on gerrit @ data-values/data-types is probably in the wrong place and we need one under mediawiki-extensions-*
Given that there's code in here that extends MediaWiki classes, it's most definitely an extension in its current form. That still leaves us with an option to move the MediaWiki-specific code in to Wikibase and keep it as a library, or treat the entire thing as an extension.
This component seems a bit confusing. Indeed, there is a part there which clearly is an extension.
So options seem to be like @Legoktm said: either make it an extension or merge it (I believe merge it back) to Wikibase.
So the simplest thing seem to me to be making an extension, what do you say @Ladsgroup ? Simplest as avoiding discussion whether it should live in Wikibase or outside (I believe there were some reason to split it out off Wikibase a while back).
Probably cleaning up the JS part of this repo (https://github.com/wmde/DataTypes/pull/73) might be worth doing before any move.
On behalf of @Ladsgroup , I have created https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/DataTypes owned by group wikidata.
I have mirrored the repo to Gerrit with:
git clone --mirror https://github.com/wmde/DataTypes/ cd DataTypes git remote add gerrit ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataTypes git push --mirror gerrit
So you would still have all the GitHub refs/pull/* references used for pull requests and all the tags :]
@thiemowmde: regarding the description on the github mirror https://github.com/wikimedia/mediawiki-extensions-DataTypes it might be easiest if you provided the desired desc here, and we can ask @hashar to change it for us