Page MenuHomePhabricator

Editing conflict handling in Special:EditCollaborationHub
Closed, DuplicatePublic

Description

The editing interface for collaborationhubs does not check for or handle edit conflicts, because it can't unless this is all reimplemented from scratch.

Very basic functionality (check and warn if anything is found, even if all it is is a newer edit) should be sufficient for general use cases until something is more properly abstracted upstream.

Event Timeline

Of course I'm getting a little ahead of myself in that the editing interface doesn't actually exist yet, but by the the time that happens I'll forget this was even something we would want, let alone that it's not there.

Reasonable request, considering you *can* edit CollaborationHubContent pages, albeit by editing raw JSON. So edit conflict checking is an issue.

Discussed with @daniel. Because of how EditPage is set up, edit conflict check and edit conflict resolution are not abstracted from the wikitext editing interface. Meaning we would have to implement our own. There may be other things where this is the case as well. I recommend for now that we implement the most basic edit conflict check and that's it.

The long term solution may be T120414.

Just check and warn. Should be more than sufficient for how often edit conflicts are likely to happen... in the, er, currently intended use cases, but of course some crazy morons may start using it as a forum or something...

Isarra renamed this task from Editing interface for collaborationhubs does not check for or handle edit conflicts to Editing conflict handling in Special:EditCollaborationHub.Apr 3 2016, 7:50 AM
Isarra updated the task description. (Show Details)