Page MenuHomePhabricator
Create Task
Maniphest T138552

Php notice showing in Production (Undefined variable: talkButton)
Closed, ResolvedPublic0.5 Estimated Story PointsPRODUCTION ERROR
Actions

Description

The notice Undefined variable: talkButton in /srv/mediawiki/php-1.28.0-wmf.7/extensions/MobileFrontend/includes/skins/SkinMinerva.php on line 843 is currently being seen in production.

  • talkButton should always be set.

Details

SubjectRepoBranchLines +/-
Only generate talkButton if there is onemediawiki/extensions/MobileFrontendmaster+2 -3
Customize query in gerrit

Event Timeline

MaxSem created this task.Jun 23 2016, 10:47 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 23 2016, 10:47 PM
• Jhernandez added a project: Web-Team-Backlog.Jun 27 2016, 5:16 PM
Jdlrobson subscribed.Jun 27 2016, 5:17 PM

Needs investigation.

• jhobs triaged this task as Medium priority.Jun 30 2016, 8:25 PM
Jdlrobson renamed this task from Undefined variable: talkButton in /srv/mediawiki/php-1.28.0-wmf.7/extensions/MobileFrontend/includes/skins/SkinMinerva.php on line 843 to Php notice showing in Production (Undefined variable: talkButton).Jun 30 2016, 8:25 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson added projects: good first task, Reading-Web-Sprint-77-Segmentation-fault.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 30 2016, 8:26 PM
MBinder_WMF moved this task from Triaged but Future to 2016-17 Q2 on the Web-Team-Backlog board.Jul 6 2016, 9:43 PM
dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-77-Segmentation-fault board.Jul 13 2016, 4:39 PM
dr0ptp4kt moved this task from To Do to Needs Analysis on the Reading-Web-Sprint-77-Segmentation-fault board.
gerritbot subscribed.Jul 13 2016, 9:01 PM

Change 298876 had a related patch set uploaded (by Jdlrobson):
Only generate talkButton if there is one

https://gerrit.wikimedia.org/r/298876

gerritbot added a project: Patch-For-Review.Jul 13 2016, 9:01 PM
Jdlrobson claimed this task.Jul 13 2016, 9:02 PM
Jdlrobson added projects: Reading-Web-Sprint-76-Retrosprekfast, Unplanned-Sprint-Work.
Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-76-Retrosprekfast board.
Florian closed this task as Resolved.Jul 13 2016, 9:31 PM
gerritbot added a comment.Jul 13 2016, 9:39 PM

Change 298876 merged by jenkins-bot:
Only generate talkButton if there is one

https://gerrit.wikimedia.org/r/298876

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-19_(1.28.0-wmf.11)).Jul 13 2016, 10:00 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-76-Retrosprekfast board.Jul 13 2016, 10:39 PM
MBinder_WMF subscribed.Jul 18 2016, 5:04 PM

@Jdlrobson story points?

Jdlrobson set the point value for this task to 0.5.Jul 18 2016, 5:23 PM
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jul 20 2016, 1:46 AM
MBinder_WMF moved this task from 2016-17 Q2 to 2016-17 Q1 on the Web-Team-Backlog board.Jul 27 2016, 5:07 PM
MBinder_WMF moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-77-Segmentation-fault board.Aug 1 2016, 5:35 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits