Page MenuHomePhabricator
Create Task
Maniphest T139469

Catchable fatal error: Argument 2 passed to Monolog\Logger::debug() must be an instance of array, string given in /srv/mediawiki/php-1.28.0-wmf.8/vendor/monolog/monolog/src/Monolog/Logger.php on line 532
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

This is creating some log spam:

Catchable fatal error: Argument 2 passed to Monolog\Logger::debug() must be an instance of array, string given in /srv/mediawiki/php-1.28.0-wmf.8/vendor/monolog/monolog/src/Monolog/Logger.php on line 532

Details

SubjectRepoBranchLines +/-
Revert "Use debug() for stash messages to match core"mediawiki/extensions/VisualEditorwmf/1.28.0-wmf.8+1 -4
Revert "Use debug() for stash messages to match core"mediawiki/extensions/VisualEditormaster+1 -4
Revert "Use debug() for stash messages to match core"mediawiki/extensions/VisualEditorwmf/1.28.0-wmf.9+1 -4
Customize query in gerrit

Related Objects

Event Timeline

thcipriani created this task.Jul 6 2016, 3:03 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 6 2016, 3:03 PM
MaxSem added a project: VisualEditor.Jul 7 2016, 9:44 PM
MaxSem subscribed.

Found by live patching the beta cluster:

2016-07-07 21:30:38 [V37J-gpEEaoAABmz9v4AAAAE] deployment-mediawiki01 enwiki 1.28.0-alpha exception ERROR: [V37J-gpEEaoAABmz9v4AAAAE] /w/api.php   Exception from line 531 of /srv/mediawiki/php-master/vendor/monolog/monolog/src/Monolog/Logger.php: Context should be array! {"exception_id":"V37J-gpEEaoAABmz9v4AAAAE"}
[Exception Exception] (/srv/mediawiki/php-master/vendor/monolog/monolog/src/Monolog/Logger.php:531) Context should be array!
  #0 /srv/mediawiki/php-master/extensions/VisualEditor/ApiVisualEditor.php(148): Monolog\Logger->debug(string, string)
  #1 /srv/mediawiki/php-master/extensions/VisualEditor/ApiVisualEditor.php(623): ApiVisualEditor->storeInSerializationCache(Title, string, string, NULL)
  #2 /srv/mediawiki/php-master/includes/api/ApiMain.php(1406): ApiVisualEditor->execute()
  #3 /srv/mediawiki/php-master/includes/api/ApiMain.php(502): ApiMain->executeAction()
  #4 /srv/mediawiki/php-master/includes/api/ApiMain.php(473): ApiMain->executeActionWithErrorHandling()
  #5 /srv/mediawiki/php-master/api.php(83): ApiMain->execute()
  #6 /srv/mediawiki/w/api.php(3): include(string)
  #7 {main}
Jdforrester-WMF added subscribers: aaron, Jdforrester-WMF.Jul 7 2016, 9:54 PM

Is this new as of -wmf.8? If not, possibly caused by https://phabricator.wikimedia.org/rEVEDeee86a9873117dfc17cd43b53b411a626d9a50e0 or https://phabricator.wikimedia.org/rEVED838d5bc7e4301d0d5a9eca82a0a761a7a2414447 (but it doesn't look like @aaron changed anything about the logging?).

• AlexMonk-WMF added a project: VisualEditor-MediaWiki.Jul 7 2016, 9:55 PM
• AlexMonk-WMF subscribed.

https://gerrit.wikimedia.org/r/#/c/295313/

Jdforrester-WMF added a comment.Jul 7 2016, 9:58 PM

Ah, yes, I missed https://phabricator.wikimedia.org/rEVED693b28a4bba633a97a1e834efb6271256388e99e. Revert?

gerritbot subscribed.Jul 7 2016, 9:59 PM

Change 297907 had a related patch set uploaded (by Jforrester):
Revert "Use debug() for stash messages to match core"

https://gerrit.wikimedia.org/r/297907

gerritbot added a project: Patch-For-Review.Jul 7 2016, 9:59 PM
gerritbot added a comment.Jul 7 2016, 10:03 PM

Change 297908 had a related patch set uploaded (by MaxSem):
Revert "Use debug() for stash messages to match core"

https://gerrit.wikimedia.org/r/297908

gerritbot added a comment.Jul 7 2016, 10:09 PM

Change 297907 merged by jenkins-bot:
Revert "Use debug() for stash messages to match core"

https://gerrit.wikimedia.org/r/297907

gerritbot added a comment.Jul 7 2016, 10:12 PM

Change 297908 merged by jenkins-bot:
Revert "Use debug() for stash messages to match core"

https://gerrit.wikimedia.org/r/297908

MaxSem closed this task as Resolved.Jul 7 2016, 10:42 PM
MaxSem claimed this task.
ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)), MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Jul 7 2016, 11:00 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Jul 8 2016, 5:43 PM
Jdforrester-WMF set the point value for this task to 1.
Legoktm mentioned this in T139198: Argument 2 passed to Monolog\Logger::debug() must be an instance of array, string given.Jul 12 2016, 9:19 PM
gerritbot added a comment.Jul 13 2016, 12:26 AM

Change 298677 had a related patch set uploaded (by MaxSem):
Revert "Use debug() for stash messages to match core"

https://gerrit.wikimedia.org/r/298677

gerritbot added a comment.Jul 13 2016, 12:35 AM

Change 298677 merged by jenkins-bot:
Revert "Use debug() for stash messages to match core"

https://gerrit.wikimedia.org/r/298677

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)).Jul 13 2016, 1:00 AM
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jul 20 2016, 1:46 AM
Krinkle edited projects, added MediaWiki-Debug-Logger; removed MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)), MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), Patch-For-Review, MediaWiki-Logevents.Jul 26 2019, 5:04 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 26 2019, 5:04 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits