Page MenuHomePhabricator
Create Task
Maniphest T143073

Fatal error: Argument 1 passed to MessageHandle::__construct() must be an instance of Title, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

fatal error: Argument 1 passed to MessageHandle::__construct() must be an instance of Title, null given
in /srv/mediawiki/php-1.28.0-wmf.14/extensions/Translate/utils/MessageHandle.php on line 37

https://github.com/wikimedia/mediawiki-extensions-Translate/blob/wmf/1.28.0-wmf.14/utils/MessageHandle.php#L35

Details

SubjectRepoBranchLines +/-
Add channels for the Translate and TranslationsNotification extensionoperations/mediawiki-configmaster+2 -1
Enable T143073 debug log channeloperations/mediawiki-configmaster+1 -0
Guard against null $title in TranslateHooks::onAbuseFilterFilterActionmediawiki/extensions/Translatemaster+6 -1
MessageHandle: add debugging for bug T143073mediawiki/extensions/Translatemaster+5 -1
Customize query in gerrit

Revisions and Commits

rETRA extension-Translate
rETRA8e1992b2e720 Guard against null $title in TranslateHooks::onAbuseFilterFilterAction

Related Objects

Event Timeline

Dereckson created this task.Aug 16 2016, 12:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2016, 12:34 AM
KartikMistry subscribed.Aug 16 2016, 4:10 AM
• Nikerabbit triaged this task as Medium priority.Aug 16 2016, 5:37 AM
• Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.

This is super frustrating. The error message does not specify anything about the caller and there is no backtrace in logstash. In other words the only thing I can do is to remove the typehint, patch in a manual check and throw an exception with a backtrace.

• Nikerabbit added a comment.Aug 16 2016, 5:56 AM

Only clue is that it became more common on the 10th, so should check new changes that went into last weeks branch.

• Nikerabbit added a comment.Aug 16 2016, 6:02 AM

git diff origin/wmf/1.28.0-wmf.3..origin/wmf/1.28.0-wmf.4 reveals no likely suspects. Timing might just be a coincidence.

Glaisher subscribed.Aug 16 2016, 6:08 AM
In T143073#2556165, @Nikerabbit wrote:

git diff origin/wmf/1.28.0-wmf.3..origin/wmf/1.28.0-wmf.4 reveals no likely suspects. Timing might just be a coincidence.

That's the wrong version numbers. It's wmf.13 and wmf.14. https://gerrit.wikimedia.org/r/#/c/303372/4/TranslateHooks.php got introduced in wmf.14 so I guess it's related to that although the doc says it will be a Title object.

gerritbot subscribed.Aug 16 2016, 6:12 AM

Change 304972 had a related patch set uploaded (by Nikerabbit):
MessageHandle: add debugging for bug T143073

https://gerrit.wikimedia.org/r/304972

gerritbot added a project: Patch-For-Review.Aug 16 2016, 6:12 AM
• Nikerabbit added projects: Unplanned-Sprint-Work, Language-Q1-2016-17 Sprint 3.Aug 16 2016, 6:12 AM
Restricted Application added a project: Language-Engineering July-September 2016. · View Herald TranscriptAug 16 2016, 6:12 AM
• Nikerabbit moved this task from Backlog to In Progress on the Language-Q1-2016-17 Sprint 3 board.Aug 16 2016, 6:12 AM
gerritbot added a comment.Aug 16 2016, 6:13 AM

Change 304973 had a related patch set uploaded (by Glaisher):
Check for null $title in TranslateHooks::onAbuseFilterFilterAction

https://gerrit.wikimedia.org/r/304973

• Nikerabbit added a comment.Aug 16 2016, 6:16 AM

@Glaisher ah that makes sense, but we still have no idea who calls AbuseFilter filterAction with null title, so the debugging should be useful.

Arrbee added a project: MediaWiki Language Extension Bundle.Aug 16 2016, 7:12 AM
Arrbee moved this task from Backlog to 2016.08 on the MediaWiki Language Extension Bundle board.
Arrbee edited projects, added Language-Q1-2016-17 Sprint 4; removed Language-Q1-2016-17 Sprint 3, Unplanned-Sprint-Work.Aug 16 2016, 7:14 AM
Arrbee moved this task from Backlog to In Review on the Language-Q1-2016-17 Sprint 4 board.Aug 16 2016, 10:29 AM
gerritbot added a comment.Aug 17 2016, 7:09 AM

Change 304972 abandoned by Nikerabbit:
MessageHandle: add debugging for bug T143073

Reason:
See https://gerrit.wikimedia.org/r/304973

https://gerrit.wikimedia.org/r/304972

• Nikerabbit assigned this task to Glaisher.Aug 17 2016, 4:00 PM
gerritbot added a comment.Aug 20 2016, 5:28 PM

Change 304973 merged by jenkins-bot:
Guard against null $title in TranslateHooks::onAbuseFilterFilterAction

https://gerrit.wikimedia.org/r/304973

Glaisher closed this task as Resolved by committing rETRA8e1992b2e720: Guard against null $title in TranslateHooks::onAbuseFilterFilterAction.Aug 20 2016, 5:29 PM
Glaisher added a commit: rETRA8e1992b2e720: Guard against null $title in TranslateHooks::onAbuseFilterFilterAction.
gerritbot added a comment.Aug 20 2016, 5:30 PM

Change 305801 had a related patch set uploaded (by Glaisher):
Enable T143073 debug log channel

https://gerrit.wikimedia.org/r/305801

Glaisher reopened this task as Open.Aug 20 2016, 5:32 PM

Uh.. how did that happen??

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 20 2016, 6:00 PM
Amire80 moved this task from Backlog to CX10 on the Language-Engineering July-September 2016 board.Aug 21 2016, 7:48 PM
Amire80 moved this task from CX10 to Translate on the Language-Engineering July-September 2016 board.
• Nikerabbit moved this task from In Review to Done on the Language-Q1-2016-17 Sprint 4 board.Aug 22 2016, 6:46 AM

Done from Translate's side, but leaving open for now.

gerritbot added a comment.Aug 23 2016, 1:11 PM

Change 305801 merged by jenkins-bot:
Enable T143073 debug log channel

https://gerrit.wikimedia.org/r/305801

Stashbot subscribed.Aug 23 2016, 1:16 PM

Mentioned in SAL [2016-08-23T13:16:18Z] <hashar@tin> Synchronized wmf-config/InitialiseSettings.php: Enable T143073 debug log channel (duration: 02m 19s)

hashar mentioned this in T143894: Feedback for European SWAT window.Aug 25 2016, 2:04 PM
• Nikerabbit removed a project: Patch-For-Review.Aug 30 2016, 7:05 AM
Arrbee closed this task as Resolved.Aug 30 2016, 7:14 AM
• Nikerabbit added a comment.Aug 30 2016, 11:35 AM

Debug log says:

Got non-Title in AbuseFilterHooks::onUploadStashFile/AbuseFilterHooks::filterUpload/AbuseFilter::filterAction/Hooks::run/TranslateHooks::onAbuseFilterFilterAction

Can file a new task for fixing that.

Glaisher mentioned this in T144265: AbuseFilterFilterAction hook sometimes passes null instead of Title object.Aug 30 2016, 12:28 PM

Filed as T144265: AbuseFilterFilterAction hook sometimes passes null instead of Title object.

gerritbot added a comment.Jun 28 2017, 10:02 PM

Change 362094 had a related patch set uploaded (by Chad; owner: Chad):
[operations/mediawiki-config@master] Revert "Enable T143073 debug log channel"

https://gerrit.wikimedia.org/r/362094

gerritbot added a project: Patch-For-Review.Jun 28 2017, 10:02 PM
gerritbot added a comment.Jun 28 2017, 10:04 PM

Change 362094 abandoned by Chad:
Revert "Enable T143073 debug log channel"

Reason:
This one still seems to log from time to time

https://gerrit.wikimedia.org/r/362094

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
gerritbot added a comment.Sep 17 2019, 10:39 AM

Change 537363 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[operations/mediawiki-config@master] Add channels for the Translate and TranslationsNotification extension

https://gerrit.wikimedia.org/r/537363

gerritbot added a comment.Sep 17 2019, 11:27 AM

Change 537363 merged by jenkins-bot:
[operations/mediawiki-config@master] Add channels for the Translate and TranslationsNotification extension

https://gerrit.wikimedia.org/r/537363

Stashbot mentioned this in T221119: "This namespace is reserved for content page translations" when trying to translate a recently created translation unit.Sep 17 2019, 11:31 AM
Stashbot mentioned this in T144780: Translation Notification Bot sending the same message multiple times to every translator.

Mentioned in SAL (#wikimedia-operations) [2019-09-17T11:31:17Z] <urbanecm@deploy1001> Synchronized wmf-config/VariantSettings.php: SWAT: 290e207: Add channels for the Translate and TranslationsNotification extension (T221119, T144780, T143073) (duration: 00m 56s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits