Page MenuHomePhabricator

Record all hover events
Closed, ResolvedPublic2 Estimated Story Points


User Story:
As an analyst, I want the ability to look at all hover events

As per the results of [T141922], we want to log all hover events (vs only logging events with totalInteractionTime > 250ms)


  • dwelledButAbandoned events with a totalInteractionTime < 250 ms are logged
  • The Popups schema documentation is updated


  • Review the sampling rate given the increased number of events being logged

Event Timeline

Suggested acceptance criteria; When making this change we're likely to see more events. We should determine whether we need to change the sampling rate after this change.

MBinder_WMF set the point value for this task to 2.Sep 12 2016, 4:56 PM
phuedx removed the point value for this task.

@jhobs you were right, dismissed is after seeing the hovercard 😆 I got confused, sorry about the kickoff chat thing


Frequency of action types over time (after fix for XHR cancel _errors_), popups enabled.png (931×2 px, 96 KB)

Change 310315 had a related patch set uploaded (by Jhernandez):
Log all dwelledButAbandoned events

Change 310324 had a related patch set uploaded (by Jhernandez):
Update Schema to the last version

Change 310315 merged by jenkins-bot:
Log all dwelledButAbandoned events

Change 310324 merged by jenkins-bot:
Update Schema to the last version

@Jdlrobson @bmansurov @jhobs Want to signoff on this (since I worked on it?)

Beta cluster doesn't seem to have popups (:S wat) so I've updated staging, and I've verified myself there too.

mw.trackSubscribe('event', (topic, event) => console.log(topic, event.action, event)) type that in the console and quickly hover over links and see that the total interaction time is less than 250ms and it is logged.

bmansurov claimed this task.
bmansurov removed bmansurov as the assignee of this task.

Don't we usually not sign off until the changes have been deployed? This task is listed as a blocker for T136746 and resolving it would imply that T136746 could be merged/deployed, which is not yet the case.

Don't we sign off on tasks after we verify they work (either on beta cluster or reading web staging)?

Don't we sign off on tasks after we verify they work (either on beta cluster or reading web staging)?

Yeah, actually, I think you're right. Sorry, I've been thinking too much in a config change world this week! I would still say we might want to leave it Open until it's no longer a blocker for the config change, but I suppose the person SWATting the config could just SWAT any patches associated with this task as well.

jhobs claimed this task.

Resolving since MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)) train has started this week. T136746 should only be deployed to 1.28.0-wmf.20.

Question: Did this change affect only the test group, or both the test and the control group? Asking because I was surprised to find that the number of link interactions recorded per pageview is now much higher than in June/July (concretely[1], for anons on huwiki it rose from 1.4 measured earlier to 5.2 now for hovercards OFF, and from 1.0 in June/July to 4.6 now for hovercards ON).

If the switch to recording all hovers was indeed made for both test and control in the same way, that's actually fine (indeed it was what I had in mind when first bringing this up, because it enables direct comparison) - but the task description says otherwise.

# repeat for later timespan and new schema version,
# restricted to Firefox:
SELECT event_popupEnabled, 
count(DISTINCT event_linkInteractionToken)/count(DISTINCT event_pageToken) AS link_interactions_per_page
FROM log.Popups_15906495
WHERE wiki ='huwiki'
AND event_isAnon = 1
AND LEFT(timestamp, 8) >= '20160925'
AND LEFT(timestamp, 8) < '20161023'
AND INSTR(userAgent,'Firefox') AND NOT INSTR(userAgent,'Seamonkey')
AND (event_action = 'pageLoaded' OR event_linkInteractionToken IS NOT NULL)
GROUP BY event_popupEnabled;

| event_popupEnabled | link_interactions_per_page |
|                  0 |                     5.2049 |
|                  1 |                     4.5728 |
2 rows in set (4 min 19.53 sec)

@Tbayer All groups indeed. The title and description are not what happened, I'll update them

Jhernandez renamed this task from Record all hover events for test group to Record all hover events.Oct 28 2016, 5:09 PM
Jhernandez updated the task description. (Show Details)