Page MenuHomePhabricator

Generate links locally in NWE (new wikitext editor) in trivial cases
Closed, ResolvedPublic1 Estimate Story Points

Description

We round-trip to Parsoid to generate links as edge cases can require weird syntax, but if we can come up with a way to quickly filter for simple cases (i.e. [[text]]) we could do those locally.

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterGenerate internal links locally

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedEsanders
OpenNone
OpenNone
ResolvedJules78120
OpenNone
ResolvedDannyH
OpenNone
OpenEsanders
OpenNone
OpenEsanders
OpenNone
Resolvedppelberg

Event Timeline

Esanders created this task.Oct 3 2016, 8:32 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptOct 3 2016, 8:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF triaged this task as Low priority.Oct 4 2016, 6:59 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.

WikiEditor seems to think the only thing that needs escaping is two or more close square brackets, so this should be quite simple.

Change 550351 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Generate internal links locally

https://gerrit.wikimedia.org/r/550351

Change 550351 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Generate internal links locally

https://gerrit.wikimedia.org/r/550351

Ryasmeen added subscribers: matmarex, Ryasmeen.

@matmarex: What do I need to test here?

@Ryasmeen In new wikitext editor, closing the link inspector to insert an internal link should be instant, and should not display a popup with a progressbar while doing network requests.

ppelberg closed this task as Resolved.Tue, Dec 24, 6:26 PM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptTue, Dec 24, 6:26 PM