Security review for InterwikiSorting Extension
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	Oct 25 2016, 11:06 AM

Description

Project Information

Name of tool/project: InterwikiSorting (mediawiki extension)
Project home page: https://www.mediawiki.org/wiki/Extension:InterwikiSorting
Name of team requesting review: WMDE
Primary contact: WMDE / @Addshore
Target date for deployment: Unknown
Link to code repository / patchset: https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/InterwikiSorting,dashboards/default
Programming Language(s) Used: PHP

Description of the tool/project

An extension to provide inter language link sorting on all projects.
This is currently done by the Wikibase extension (and the InterwikiSorting extension has simply been factored out)

Description of how the tool will be used at WMF

The extension will be deployed to all sites (that Wikibase is installed on)

Dependencies

List dependencies, or upstream projects that this project relies on

None

Has this project been reviewed before?

please link to tasks or wiki pages of previous reviews

Only regular CR

Working test environment

please link or describe setup process for setting up a test environment

This extension is currently working along side the Cognate extension in this Labs test environment (which you can be given access to)

http://enwiktionary-cognate.wmflabs.org
http://dewiktionary-cognate.wmflabs.org
http://frwiktionary-cognate.wmflabs.org

Simply install as a regular mediawiki extension and configure.

Post-deployment

name of team responsible for tool/project after deployment and primary contact

WMDE / Wikidata / @Lydia_Pintscher

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Feature	None	T13996 A way to select which parts of Wiktionary articles to show
Open	Feature	None	T14213 Following a link to a language entry in Wiktionary should display only that entry
Open	Feature	None	T13998 A way to show only those languages on Wiktionary that the user is interested in
Open	Feature	None	T38881 Wiktionary needs usable API
Open		None	T31229 Extension to provide access via the dict protocol
Resolved		Lydia_Pintscher	T146637 Wikidata 2016 Q4 goals
Resolved		Lydia_Pintscher	T150179 Wikidata 2017 Q1 goals
Open		None	T109579 [Epic] Give more sister projects access to Wikidata
Resolved		Lydia_Pintscher	T986 Use structured data on Wiktionary
Resolved		Lydia_Pintscher	T988 Phase 1: Represent Wiktionary lexicon using structured data
Resolved		Lydia_Pintscher	T987 [Story] Phase 0: Automate interwiki language links for Wiktionary
Resolved		Lydia_Pintscher	T169708 Wikidata 2017 Q3 goals
Resolved		Lydia_Pintscher	T150178 Wikidata 2017 Q2 goals
Resolved		Lydia_Pintscher	T159316 Enable arbitrary access on English Wiktionary
Resolved		aude	T158323 enable sitelinks on Wikidata for Wiktionary pages outside main namespace (phase 1)
Resolved		Addshore	T150182 Deploy Cognate extension to production
Resolved		Addshore	T150183 Deploy InterwikiSorting extension to production
Resolved		Addshore	T155995 Deploy InterwikiSorting extension to beta
Resolved		Bawolff	T149083 Security review for InterwikiSorting Extension
Resolved		aude	T158324 Enable phase 1 for Wiktionary at beta cluster
Resolved		None	T158325 Enable phase 1 for Wiktionary at test Wikidata
Open		None	T166765 Investigate the case of custom namespaces

Event Timeline

Addshore created this task.Oct 25 2016, 11:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2016, 11:06 AM

Addshore added a project: User-Addshore.Oct 25 2016, 11:06 AM

Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.

Addshore moved this task from Active 🚁 to Watching 👀 on the User-Addshore board.

Addshore added a project: WMDE-TechWish.Oct 25 2016, 2:38 PM

Addshore moved this task from Proposed to Watching/Blocked/External on the WMDE-TechWish board.

I should not here in theory the deployment of this would be a noop, as this code is already running as part of WikibaseClient.
Some config needs to be adjusted (new names for config vars) but that is about it.

Is there a task tracking the deployment of this extension to Wikimedia production?

Addshore added a parent task: T33235: [DO NOT USE] Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) [superseded by #wikimedia-extension-review-queue].Nov 7 2016, 3:54 PM

Lydia_Pintscher added a parent task: T150183: Deploy InterwikiSorting extension to production.Nov 7 2016, 4:04 PM

Addshore removed a parent task: T33235: [DO NOT USE] Extensions awaiting code review to be deployed on Wikimedia wikis (tracking) [superseded by #wikimedia-extension-review-queue].Nov 7 2016, 4:16 PM

aude added a subscriber: Reedy.Nov 28 2016, 2:18 PM

aude subscribed.

aude added a project: MediaWiki-extensions-InterwikiSorting.Dec 2 2016, 1:55 PM

• dpatrick mentioned this in E432: Security review for InterwikiSorting Extension.Dec 21 2016, 12:25 AM

• dpatrick moved this task from Incoming to Scheduled on the deprecated-security-team-reviews board.

Security review of InterwikiSorting revision 7d48e09104136 (Jan 3, 2017)

Extension looks good. One small (non-security) comment:

In InterwikiSorter.php code comment references a doc file which doesn't seem to exist: @see Documentation of "sort" and "interwikiSortOrders" options in docs/options.wiki.

Thank you!

Addshore moved this task from Watching 👀 to Closing ✔️ on the User-Addshore board.Jan 17 2017, 2:27 PM

In T149083#2943893, @Bawolff wrote:

In InterwikiSorter.php code comment references a doc file which doesn't seem to exist: @see Documentation of "sort" and "interwikiSortOrders" options in docs/options.wiki.

Doc removed in https://gerrit.wikimedia.org/r/#/c/332886/

Addshore added a parent task: T155995: Deploy InterwikiSorting extension to beta.Jan 23 2017, 11:26 AM

Tobi_WMDE_SW moved this task from Watching/Blocked/External to Done on the WMDE-TechWish board.Jan 26 2017, 1:24 PM

Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.

Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:01 PM

sbassett moved this task from Waiting to Done on the deprecated-security-team-reviews board.Jul 9 2019, 8:23 PM

• chasemp removed a project: deprecated-security-team-reviews.Jan 8 2020, 4:12 PM

• chasemp added a project: Application Security Reviews.Jan 8 2020, 4:39 PM

• chasemp moved this task from Incoming to Our Part Is Done on the Application Security Reviews board.Jan 8 2020, 4:43 PM

• chasemp added a project: secscrum.Mar 10 2020, 8:11 PM

• chasemp moved this task from Incoming to Our Part Is Done on the secscrum board.Mar 10 2020, 8:19 PM