See example from new wikitext editor
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned In
- T185463: Review window too small for initial diff
- Mentioned Here
- rEVED39b82f7b0027: Revert 032fb292, a97eacd0
Event Timeline
Comment Actions
Change 318244 had a related patch set uploaded (by Esanders):
Set mode of save dialog after setting size so footer is correct height
Comment Actions
Fixed this case downstream by ensuring the mode is set after the size is set, but we should make a change upstream to ensure the footer is re-measured whenever the dialog is resized either by setSize or actions.setMode.
Comment Actions
Change 318244 merged by jenkins-bot:
Set mode of save dialog after setting size so footer is correct height
Comment Actions
I don't think this is resolved yet, as I've seen it recur a few times when editing, but I can't replicate right now, sorry.
Comment Actions
@Mooeypoo also ran into this issue with https://gerrit.wikimedia.org/r/#/c/365504/7/src/dialogs/SimpleProcessDialog.js@169 and we spent a lot of time debugging it before I found this task. I don't know why we did not fix it in 2016 when @Esanders described the solution…
Comment Actions
Change 431685 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] ProcessDialog: Fix footer height when actions or dialog size changes
Comment Actions
Change 431685 merged by jenkins-bot:
[oojs/ui@master] ProcessDialog: Fix footer height when actions or dialog size changes
Comment Actions
I am pretty sure we don't have any hacks to remove. It seems that when we ran into this issue (your one patch in 2016, and I vaguely recall something else more recent but I can't find the commit for it), we managed to resolve it by reordering some operations. There is no point in trying to reorder them back.
Comment Actions
Hmm, I was probably thinking about rEVED39b82f7b0027: Revert 032fb292, a97eacd0, but that was a different bug.