Page MenuHomePhabricator
Create Task
Maniphest T149480

Extension:Approved Revs is missing a way to query via the API
Closed, ResolvedPublic
Actions

Description

wiki?title=Special:ApprovedRevs&limit=500&offset=0&show=unapprove works, but I don't want to scrape HTML, so let's create an API module for this ApprovedRevs extention.

Details

SubjectRepoBranchLines +/-
Register SpecialApprovedRevsPage as a query page to expose via API et almediawiki/extensions/ApprovedRevsmaster+13 -4
Customize query in gerrit

Event Timeline

Gryllida created this task.Oct 29 2016, 12:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2016, 12:10 PM
Peachey88 added a project: MediaWiki-extensions-Other.Oct 29 2016, 12:10 PM
Reedy removed subscribers: Umherirrender, Addshore, Florian, MarkAHershberger.Oct 29 2016, 12:10 PM
Reedy subscribed.Oct 29 2016, 12:13 PM

It may be worth "just" making ApprovedRevs a query page... And then it can work under the api list=querypage

gerritbot subscribed.Oct 29 2016, 12:22 PM

Change 318676 had a related patch set uploaded (by Reedy):
Register SpecialApprovedRevsPage as a query page to expose via API et al

https://gerrit.wikimedia.org/r/318676

gerritbot added a project: Patch-For-Review.Oct 29 2016, 12:22 PM
Reedy added a comment.Oct 29 2016, 12:23 PM
In T149480#2753930, @Reedy wrote:

It may be worth "just" making ApprovedRevs a query page... And then it can work under the api list=querypage

Apparently it already is. Just isn't registered as such

gerritbot added a comment.Oct 30 2016, 8:46 PM

Change 318676 merged by Yaron Koren:
Register SpecialApprovedRevsPage as a query page to expose via API et al

https://gerrit.wikimedia.org/r/318676

Reedy removed a project: Patch-For-Review.Oct 30 2016, 8:47 PM

Question whether it's worth writing a proper API module... I'm thinking, that at least for this purpose, it's not worth it...?

Reedy renamed this task from Extension:Approved Revs is missing an API module to Extension:Approved Revs is missing a way to query via the API.Nov 2 2016, 12:12 AM
Gryllida closed this task as Resolved.Nov 2 2016, 12:13 AM
Gryllida assigned this task to Reedy.
Peachey88 edited projects, added MediaWiki-extensions-Approved-Revs; removed MediaWiki-extensions-Other.Sep 16 2018, 8:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits