Page MenuHomePhabricator
Create Task
Maniphest T151061

<legend> labels no longer shown in Chrome (55.0.2883.35) and friends
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Nov 18 2016, 3:19 PM
Tags
Referenced Files
F4741838: pasted_file
Nov 18 2016, 3:40 PM
F4741840: pasted_file
Nov 18 2016, 3:40 PM
F4741758: pasted_file
Nov 18 2016, 3:19 PM
F4741751: pasted_file
Nov 18 2016, 3:19 PM
F4741741: pasted_file
Nov 18 2016, 3:19 PM
F4741756: pasted_file
Nov 18 2016, 3:19 PM
F4741754: pasted_file
Nov 18 2016, 3:19 PM
F4741746: pasted_file
Nov 18 2016, 3:19 PM
Subscribers
Aklapper
Esanders
gerritbot
hashar
Jay8g
Jdforrester-WMF
Luke081515
View All 12 Subscribers

Description

Our neat <legend> labels are no longer shown in Chrome (55.0.2883.35) and friends. Other form elements shift around in confusing ways. This definitely was not happening a couple weeks ago.

https://doc.wikimedia.org/oojs-ui/master/demos/https://en.wikipedia.org/wiki/The_Fighting_Temeraire?veaction=edithttps://en.wikipedia.org/wiki/Special:ActiveUsers
Chrome
pasted_file (943×1 px, 85 KB)
pasted_file (943×1 px, 387 KB)
pasted_file (943×1 px, 189 KB)
Firefox
pasted_file (959×1 px, 72 KB)
pasted_file (959×1 px, 356 KB)
pasted_file (959×1 px, 155 KB)

Details

SubjectRepoBranchLines +/-
OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85mediawiki/vendorwmf/1.29.0-wmf.4+1 -1
OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85mediawiki/corewmf/1.29.0-wmf.4+1 -1
OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85mediawiki/coremaster+1 -1
FieldsetLayout: Temporarily remove use of `<legend>` due to Chrome 55 bugoojs/uimaster+2 -2
OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85mediawiki/vendormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Nov 18 2016, 3:19 PM
Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes, Aklapper. · View Herald TranscriptNov 18 2016, 3:19 PM
matmarex mentioned this in T116354: Special:ActiveUsers' user interface is awkward (can't filter to arbitrary user groups).Nov 18 2016, 3:19 PM
TheDJ subscribed.Nov 18 2016, 3:29 PM

Unchecking float on the legend element seems to invert the behavior (legend is visible, but none of the fieldset contents is.

matmarex added a comment.Nov 18 2016, 3:40 PM

Minimal test case:

<style>
legend { float: left; }
</style>
<fieldset>
<legend>derp</legend>
<p>bleh bleh</p>
</fieldset>

Actual:

pasted_file (82×538 px, 2 KB)

Expected (Firefox screenshot):
pasted_file (92×539 px, 2 KB)

matmarex claimed this task.Nov 21 2016, 4:20 PM
matmarex added a project: Upstream.Nov 21 2016, 4:50 PM

Upstream bug report: https://bugs.chromium.org/p/chromium/issues/detail?id=661230 (we are not the first to encounter this).

Jdforrester-WMF moved this task from Backlog to Doing on the OOUI board.Nov 29 2016, 11:09 PM
gerritbot subscribed.Dec 5 2016, 12:54 AM

Change 325243 had a related patch set uploaded (by Bartosz Dziewoński):
FieldsetLayout: Temporarily remove use of <legend> due to Chrome 55 bug

https://gerrit.wikimedia.org/r/325243

gerritbot added a project: Patch-For-Review.Dec 5 2016, 12:54 AM
matmarex added a comment.Dec 5 2016, 12:54 AM

Chrome 55 went stable on Thursday, so this suddenly is a bit more pressing. (I only noticed on Saturday, because the original schedule said it'll be next Tuesday, and I thought it can be trusted.) I'll have the fixes SWAT-deployed tomorrow.

(Upstream task got merged into https://bugs.chromium.org/p/chromium/issues/detail?id=670837 for some reason.)

gerritbot added a comment.Dec 5 2016, 12:58 AM

Change 325244 had a related patch set uploaded (by Bartosz Dziewoński):
OOjs UI: Backport I7513c3233b07780bab7a90de8a3b249a8d33448f

https://gerrit.wikimedia.org/r/325244

gerritbot added a comment.Dec 5 2016, 12:58 AM

Change 325245 had a related patch set uploaded (by Bartosz Dziewoński):
OOjs UI: Backport I7513c3233b07780bab7a90de8a3b249a8d33448f

https://gerrit.wikimedia.org/r/325245

gerritbot added a comment.Dec 5 2016, 12:59 AM

Change 325246 had a related patch set uploaded (by Bartosz Dziewoński):
OOjs UI: Backport I7513c3233b07780bab7a90de8a3b249a8d33448f

https://gerrit.wikimedia.org/r/325246

gerritbot added a comment.Dec 5 2016, 12:59 AM

Change 325247 had a related patch set uploaded (by Bartosz Dziewoński):
OOjs UI: Backport I7513c3233b07780bab7a90de8a3b249a8d33448f

https://gerrit.wikimedia.org/r/325247

matmarex added a comment.Dec 5 2016, 1:03 AM

(Of course I7513c3233b07780bab7a90de8a3b249a8d33448f is the wrong Change-Id, the right one is I73f95965694ec7fb0fa9a474742286e1105e5c85. I made a mistake when copy-pasting into the commit message. Corrected in PS2.)

hashar subscribed.Dec 5 2016, 2:00 PM

As I understand it Chrome 55 has an issue with the <legend/> tag and the patches above change OOJS/ui to generate a <div/> instead. I can see how it can lead to other breakages for anything that assumes a legend element (skin, gadgets, whatever extension relying on it etc).

gerritbot added a comment.Dec 5 2016, 4:28 PM

Change 325243 merged by jenkins-bot:
FieldsetLayout: Temporarily remove use of <legend> due to Chrome 55 bug

https://gerrit.wikimedia.org/r/325243

gerritbot added a comment.Dec 5 2016, 4:40 PM

Change 325245 merged by jenkins-bot:
OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85

https://gerrit.wikimedia.org/r/325245

gerritbot added a comment.Dec 5 2016, 4:45 PM

Change 325244 merged by jenkins-bot:
OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85

https://gerrit.wikimedia.org/r/325244

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)), MW-1.29-release-notes.Dec 5 2016, 5:00 PM
gerritbot added a comment.Dec 5 2016, 8:15 PM

Change 325246 merged by jenkins-bot:
OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85

https://gerrit.wikimedia.org/r/325246

gerritbot added a comment.Dec 5 2016, 8:15 PM

Change 325247 merged by jenkins-bot:
OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85

https://gerrit.wikimedia.org/r/325247

Stashbot subscribed.Dec 5 2016, 8:23 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-05T20:23:16Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.4/vendor/oojs/oojs-ui/php/layouts/FieldsetLayout.php: SWAT: [[gerrit:325247|OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85]] T151061 (duration: 00m 46s)

Stashbot added a comment.Dec 5 2016, 8:25 PM

Mentioned in SAL (#wikimedia-operations) [2016-12-05T20:25:40Z] <thcipriani@tin> Synchronized php-1.29.0-wmf.4/resources/lib/oojs-ui/oojs-ui-core.js: SWAT: [[gerrit:325246|OOjs UI: Backport I73f95965694ec7fb0fa9a474742286e1105e5c85]] T151061 (duration: 00m 46s)

matmarex closed this task as Resolved.Dec 5 2016, 8:38 PM
matmarex removed a project: Patch-For-Review.

Fixed and deployed.

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Dec 5 2016, 9:00 PM
matmarex mentioned this in T124932: Look into not serving OOUI styles for IE 6 and 7.Mar 2 2017, 12:16 AM
Volker_E moved this task from Doing to OOjs-UI-0.22.4 on the OOUI board.Oct 13 2017, 6:34 PM
Volker_E edited projects, added OOUI (OOjs-UI-0.22.4); removed MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), OOUI.
matmarex mentioned this in T255270: FieldsetLayout broken in Chrome == 55.Jun 12 2020, 5:14 PM
Esanders merged a task: T255270: FieldsetLayout broken in Chrome == 55.Jun 12 2020, 5:45 PM
Esanders added subscribers: Esanders, Jdforrester-WMF, Volker_E.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits