Maniphest T153039

CI: Support running phan for extensions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Dec 13 2016, 7:21 AM

Tags

Referenced Files

	F5273414: pasted_file
	Jan 12 2017, 12:48 AM

Subscribers

View All 9 Subscribers

Tokens

"Like" token, awarded by Addshore."Like" token, awarded by Samwilson.

Description

Set up and document a standardized way for extensions to run phan, locally and via CI.

Details

	Subject	Repo	Branch	Lines +/-
	Phan for extensions	integration/config	master	+47 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T153039 CI: Support running phan for extensions
		Resolved		EBernhardson	T153040 Migrate phan for CirrusSearch to jenkins

Event Timeline

Legoktm created this task.Dec 13 2016, 7:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2016, 7:21 AM

I filed T153040 as a subtask, and hopefully resolving that will also give us a framework we can copy for other extensions.

Samwilson awarded a token.Dec 13 2016, 7:37 AM

Nikerabbit subscribed.Dec 13 2016, 8:31 AM

WMDE-leszek subscribed.Dec 14 2016, 8:12 AM

For manual use I have added phan configs to a bunch of WMDE extensions.

https://gerrit.wikimedia.org/r/#/c/328917/
https://gerrit.wikimedia.org/r/#/c/330257/
https://gerrit.wikimedia.org/r/#/c/330260/
https://gerrit.wikimedia.org/r/#/c/330261/
https://gerrit.wikimedia.org/r/#/c/330263/

It would be great to have this running on jenkins for these extensions once there is a job ready.

Addshore added a project: User-Addshore.Jan 3 2017, 7:37 PM

Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.

Change 330396 had a related patch set uploaded (by Addshore):
Phan for extensions

https://gerrit.wikimedia.org/r/330396

gerritbot added a project: Patch-For-Review.Jan 4 2017, 11:54 AM

Change 330396 merged by jenkins-bot:
Phan for extensions

https://gerrit.wikimedia.org/r/330396

Addshore moved this task from Watching 👀 to Back Burner 🏛️ on the User-Addshore board.Jan 4 2017, 6:30 PM

Patches involced

https://gerrit.wikimedia.org/r/330396
https://gerrit.wikimedia.org/r/#/c/331791/
https://gerrit.wikimedia.org/r/#/c/331795/
https://gerrit.wikimedia.org/r/#/c/331796/

pasted_file (401×536 px, 37 KB)

Patches introducing phan configs to extensions can be found @

https://gerrit.wikimedia.org/r/#/c/330257/
https://gerrit.wikimedia.org/r/#/c/328917/
https://gerrit.wikimedia.org/r/#/c/330260/
https://gerrit.wikimedia.org/r/#/c/330263/

The CI template is "extension-phan-generic" and the job is "mwext-php70-phan-jessie"

Thanks to @hashar @Tarrow @Legoktm @ Wikimedia-Developer-Summit (2017) [=

Super nice thank you! ;-}

Addshore moved this task from Back Burner 🏛️ to Closing ✔️ on the User-Addshore board.Jan 17 2017, 2:27 PM

• Deskana closed subtask T153040: Migrate phan for CirrusSearch to jenkins as Resolved.Jan 17 2017, 6:24 PM

phuedx mentioned this in T133664: Statically analyse MinervaNeue codebases with Phan.Jul 21 2017, 6:43 PM