Factor ChangeOps instantiation logic out of Api\EditEntity
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-leszek
	Dec 29 2016, 4:00 PM

Description

Code deserializing change op JSON into ChangeOps should be moved out from Api\EditEntity into class (or several classes) implementing change op deserializer interface (T153950).

Api\EditEntity will then uses these classes without knowing any details on serialization, defined fields etc.
This will also allow extensions to add custom entity types (that do not have attributes that have been currently hard-coded in EditEntity).

Details

Subject	Repo	Branch	Lines +/-
Move ChangeOp initialization logic to entity type definitions	mediawiki/extensions/Wikibase	master	+225 -408
Introduce EntityChangeOpProvider	mediawiki/extensions/Wikibase	master	+200 -0
Add ChangeOpDeserializer for properties	mediawiki/extensions/Wikibase	master	+166 -0
Add ChangeOpDeserializer for site link changes	mediawiki/extensions/Wikibase	master	+845 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Feature	None	T13996 A way to select which parts of Wiktionary articles to show
Open	Feature	None	T14213 Following a link to a language entry in Wiktionary should display only that entry
Open	Feature	None	T13998 A way to show only those languages on Wiktionary that the user is interested in
Open	Feature	None	T38881 Wiktionary needs usable API
Open		None	T31229 Extension to provide access via the dict protocol
Open		None	T109579 [Epic] Give more sister projects access to Wikidata
Resolved		Lydia_Pintscher	T986 Use structured data on Wiktionary
Resolved		Lydia_Pintscher	T988 Phase 1: Represent Wiktionary lexicon using structured data
Resolved		Lydia_Pintscher	T146637 Wikidata 2016 Q4 goals
Resolved		Lydia_Pintscher	T150179 Wikidata 2017 Q1 goals
Resolved		Lydia_Pintscher	T146662 [Story] new entity type for Lexemes (baseline)
Resolved		Lydia_Pintscher	T148139 Implement a base version of the Lexeme Entity type
Resolved		WMDE-leszek	T152491 Allow the EditEntity API module to work with all types of entities
Resolved		Lydia_Pintscher	T155699 Integrate WikibaseLexeme with EditEntity API module
Resolved		Jakob_WMDE	T154288 Factor ChangeOps instantiation logic out of Api\EditEntity
Resolved		Ladsgroup	T153950 Add ChangeOpDeserializer interface for services providing ChangeOps to Api\EditEntity

Event Timeline

WMDE-leszek created this task.Dec 29 2016, 4:00 PM

WMDE-leszek added a subtask: T153950: Add ChangeOpDeserializer interface for services providing ChangeOps to Api\EditEntity.

SamanthaNguyen moved this task from Unsorted to Needs refactor on the Technical-Debt board.Jan 3 2017, 9:53 PM

Jakob_WMDE claimed this task.Jan 9 2017, 2:54 PM

Jakob_WMDE moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.

Change 331882 had a related patch set uploaded (by Jakob):
[WIP][DRAFT]Extract ChangeOp initialization logic from EditEntity.

https://gerrit.wikimedia.org/r/331882

gerritbot added a project: Patch-For-Review.Jan 12 2017, 5:42 PM

Ricordisamoa renamed this task from Factor ChangeOps instantiation logic out of Api\EdtiEntity to Factor ChangeOps instantiation logic out of Api\EditEntity.Jan 12 2017, 6:07 PM

Ricordisamoa subscribed.

thiemowmde closed subtask T153950: Add ChangeOpDeserializer interface for services providing ChangeOps to Api\EditEntity as Resolved.Jan 18 2017, 11:37 AM

Bumping to high as we need this in order to use API to edit WikibaseLexeme's entities.

Change 334148 had a related patch set uploaded (by WMDE-leszek):
Add ChangeOpDeserializer for properties

https://gerrit.wikimedia.org/r/334148

WMDE-leszek moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Feb 23 2017, 1:53 PM

WMDE-leszek mentioned this in T158864: Reuse code for parsing site link badge data in SetSiteLink API class.Feb 23 2017, 3:46 PM

WMDE-leszek added a parent task: T155699: Integrate WikibaseLexeme with EditEntity API module.Mar 6 2017, 12:34 PM

Change 334145 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Add ChangeOpDeserializer for site link changes

https://gerrit.wikimedia.org/r/334145

Change 334148 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Add ChangeOpDeserializer for properties

https://gerrit.wikimedia.org/r/334148

Change 342429 had a related patch set uploaded (by WMDE-leszek):
[mediawiki/extensions/Wikibase] Introduce EntityChangeOpProvider

https://gerrit.wikimedia.org/r/342429

Addshore unsubscribed.Mar 14 2017, 1:42 PM

Change 342429 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Introduce EntityChangeOpProvider

https://gerrit.wikimedia.org/r/342429

Change 331882 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Move ChangeOp initialization logic to entity type definitions

https://gerrit.wikimedia.org/r/331882

WMDE-leszek closed this task as Resolved.Mar 15 2017, 8:07 AM

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.

Factor ChangeOps instantiation logic out of Api\EditEntityClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Factor ChangeOps instantiation logic out of Api\EditEntity
Closed, ResolvedPublic
Actions

Related Objects
Search...