Page MenuHomePhabricator
Create Task
Maniphest T163114

Regression: Fix config to disable related pages where it's not wanted
Closed, ResolvedPublic
Actions

Description

The fix for T162213 accidentally enabled related pages for projects on Thursday 13th 4PM PST that didn't want to. The issue was promptly identified but we were unable to address it until the next SWAT window. Due to the datacenter switch-over, this is blocked until the week of the 24th.

Acceptance Criteria:

  • Remove Related Pages from German and Russian wikipedias

Testing Criteria:

  1. Visit the mobile website for Russian Wikipedia any day after April 13
  2. Select any article
  3. Scroll to the bottom of the article and ensure no "related pages" section appears
  4. Repeat the above for German wikipedia
  1. Visit the mobile website for English Wikipedia any day after April 13
  2. Select any article
  3. Scroll to the bottom of the article and ensure "related pages" section appears
  4. Repeat the above for Hebrew wikipedia

Details

SubjectRepoBranchLines +/-
Workaround issue of overriding whitelist config variableoperations/mediawiki-configmaster+7 -6
Correctly enforce config for related pagesoperations/mediawiki-configmaster+2 -0
Customize query in gerrit

Revisions and Commits

rOMWC Wikimedia - MediaWiki Config
rOMWC1a75877790c8 Paper over "Notice: Undefined variable…

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Apr 17 2017, 3:24 PM
gerritbot subscribed.Apr 17 2017, 3:25 PM

Change 348472 had a related patch set uploaded (by Jdlrobson):
[operations/mediawiki-config@master] Correctly enforce config for related pages

https://gerrit.wikimedia.org/r/348472

gerritbot added a project: Patch-For-Review.Apr 17 2017, 3:25 PM
Jdlrobson added a project: Wikimedia-Site-requests.Apr 17 2017, 3:25 PM
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptApr 17 2017, 3:25 PM
Jdlrobson mentioned this in T162213: Verify Related pages is no longer a desktop beta feature.Apr 17 2017, 3:27 PM
Jdlrobson moved this task from Needs Analysis to Blocked Externally on the Reading-Web-Sprint-95 board.
Jdlrobson updated the task description. (Show Details)Apr 17 2017, 3:39 PM
ovasileva moved this task from Incoming to 2016-17 Q4 on the Web-Team-Backlog board.Apr 17 2017, 4:35 PM
ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)Apr 17 2017, 4:41 PM
ovasileva edited projects, added Reading-Web-Sprint-96; removed Reading-Web-Sprint-95.
ovasileva moved this task from 2016-17 Q4 to Upcoming on the Web-Team-Backlog board.
Jdlrobson moved this task from Needs Analysis to Blocked Externally on the Reading-Web-Sprint-96 board.Apr 17 2017, 7:51 PM
Jdlrobson moved this task from Upcoming to 2016-17 Q4 on the Web-Team-Backlog board.Apr 19 2017, 6:38 PM
Jdlrobson moved this task from Blocked Externally to To Do on the Reading-Web-Sprint-96 board.Apr 21 2017, 6:05 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-96 board.Apr 24 2017, 5:11 PM
MBinder_WMF added a comment.Apr 24 2017, 5:14 PM

Discussed in standup: probably don't need to story-point this because it will just go in with a bunch of other swat'd tasks, and the estimate-able work is in the swat and not the content.

Jdlrobson claimed this task.Apr 24 2017, 6:01 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Reading-Web-Sprint-96 board.
gerritbot added a comment.Apr 24 2017, 11:07 PM

Change 348472 merged by jenkins-bot:
[operations/mediawiki-config@master] Correctly enforce config for related pages

https://gerrit.wikimedia.org/r/348472

Stashbot subscribed.Apr 24 2017, 11:41 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-24T23:41:51Z] <twentyafterfour@naos> Synchronized wmf-config/: deploy https://gerrit.wikimedia.org/r/#/c/348472/ refs T163114 (duration: 01m 05s)

Jdlrobson moved this task from Needs Code Review to Blocked Externally on the Reading-Web-Sprint-96 board.Apr 24 2017, 11:44 PM
Jdlrobson removed a project: Patch-For-Review.Apr 24 2017, 11:48 PM
Jdlrobson added a subscriber: greg.

The SWAT didn't help. I'm not sure what the config is doing but it's not behaving how I'd expect it

wmgRelatedArticlesFooterWhitelistedSkins and thus wgRelatedArticlesFooterWhitelistedSkins should be defined to an empty list for anything in the dblist related-articles-footer-blacklisted-skins (ruwiki and dewiki)

Instead of this dewiki and ruwiki are defaulting to what's in extension.json which is ['minerva']

@greg who's the best person to talk to to understand how the config is actually working? We've got two communities who are getting a feature they don't want so I'm quite keen to remedy this asap, but I have no idea how :-(

• mmodell added a commit: rOMWC1a75877790c8: Paper over "Notice: Undefined variable….Apr 25 2017, 12:21 AM
greg added a comment.Apr 25 2017, 9:24 PM

@Jdlrobson come to -releng or -operations, mostly.

Jdlrobson added a comment.Apr 26 2017, 3:48 AM

Looks like we may have a lead :) T126306

Jdlrobson added a comment.Apr 26 2017, 5:58 PM

T142663 could also be causing this problem.

gerritbot added a comment.Apr 26 2017, 5:58 PM

Change 350459 had a related patch set uploaded (by Jdlrobson):
[operations/mediawiki-config@master] Workaround issue of overriding whitelist config variable

https://gerrit.wikimedia.org/r/350459

gerritbot added a project: Patch-For-Review.Apr 26 2017, 5:58 PM
Tgr subscribed.Apr 26 2017, 6:03 PM
In T163114#3212857, @Jdlrobson wrote:

Looks like we may have a lead :) T126306

That affects changes to the private repo only. There are not symlinks involved here.

The problem is probably that both default and related-articles-footer-blacklisted-skins match and they are either merged or only the first one is used, I don't remember which. InitializeSettings should really be documented somewhere.

gerritbot added a comment.Apr 26 2017, 6:54 PM

Change 350459 merged by jenkins-bot:
[operations/mediawiki-config@master] Workaround issue of overriding whitelist config variable

https://gerrit.wikimedia.org/r/350459

Stashbot added a comment.Apr 26 2017, 6:58 PM

Mentioned in SAL (#wikimedia-operations) [2017-04-26T18:58:35Z] <thcipriani@naos> Synchronized wmf-config/CommonSettings.php: SWAT: [[gerrit:350459|Workaround issue of overriding whitelist config variable]] T163114 (duration: 00m 53s)

Jdlrobson reassigned this task from Jdlrobson to ABorbaWMF.Apr 26 2017, 7:03 PM
Jdlrobson moved this task from Blocked Externally to Needs QA on the Reading-Web-Sprint-96 board.
Jdlrobson added subscribers: ABorbaWMF, Reedy.

@ABorbaWMF Can you run through the tests again?

@Reedy found a workaround solution and T142663 is the bad guy here.

Jdlrobson removed a project: Patch-For-Review.Apr 27 2017, 2:34 AM
ABorbaWMF moved this task from Needs QA to Ready for Signoff on the Reading-Web-Sprint-96 board.Apr 27 2017, 7:53 PM

Ok, tested on a variety of browsers and devices.

Related pages do not appear on Russian and German Wikipedias.

Related pages do appear on English and Hebrew Wikipedias.

Jdlrobson closed this task as Resolved.Apr 27 2017, 10:16 PM

Signing off

FriedhelmW reopened this task as Open.Mar 27 2021, 10:31 AM
FriedhelmW subscribed.

Related pages appears on German Wikipedia in Timeless skin, see for example https://de.wikipedia.org/wiki/Stern?useskin=timeless.

RhinosF1 subscribed.Mar 27 2021, 10:36 AM
In T163114#6951058, @FriedhelmW wrote:

Related pages appears on German Wikipedia in Timeless skin, see for example https://de.wikipedia.org/wiki/Stern?useskin=timeless.

This was resolved 3 years ago and about an issue then. I would open a seperate task as you're reporting a new occurence and it now seems unique to timeless.

CorrectHorseBatteryStaple added projects: RelatedArticles, Timeless.Mar 27 2021, 10:37 AM
RhinosF1 closed this task as Resolved.Mar 27 2021, 10:38 AM
RhinosF1 removed projects: Timeless, RelatedArticles.

Will open a seperate task as it seems like a seperate issue. This 3 year old one doesn't seem relevant.

RhinosF1 mentioned this in T278611: Request to disable RelatedArticles on Timeless skin on German Wikipedia.Mar 27 2021, 10:42 AM

Split to T278611: Request to disable RelatedArticles on Timeless skin on German Wikipedia

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits