Page MenuHomePhabricator

RevisionSlider for mobile view
Closed, DuplicatePublic

Assigned To
None
Authored By
Florian
May 20 2017, 8:27 AM
Referenced Files
F8222051: image.png
May 31 2017, 5:15 PM
F8130750: image.png
May 20 2017, 8:27 AM
Tokens
"Cookie" token, awarded by Charlie_WMDE."Pterodactyl" token, awarded by Lea_WMDE.

Description

When opening the dif view of a page in the mobile view when the RevisionSlider extension is enabled, you get the following view:

image.png (575×1 px, 36 KB)

Unfortunately, the RevisionSlider is not visible at all. In fact, it would probably be not fully working, but it should at least be possible to view it in mobile (e.g. as a beta feature or whatever).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 354641 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/MobileFrontend@master] Run DiffViewHeader in mobile mode, too

https://gerrit.wikimedia.org/r/354641

Change 354642 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/RevisionSlider@master] WIP: Enable RevisionSlider for mobile diff pages

https://gerrit.wikimedia.org/r/354642

Change 355434 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/MobileFrontend@master] Run DiffViewHeader in mobile mode, too

https://gerrit.wikimedia.org/r/355434

Change 354641 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Refactor Special:MobileDiff

https://gerrit.wikimedia.org/r/354641

Change 355434 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Run DiffViewHeader in mobile mode, too

https://gerrit.wikimedia.org/r/355434

Jdlrobson renamed this task from RevisionSlider is not visible on the mobile diff view to RevisionSlider is not visible on the mobile diff view (beta only).Jun 2 2017, 6:12 PM

@Jdlrobson just FYI if beta only is about the RevisionSlider being beta - it got out of beta and has been a per default enabled feature since the week before the hackathon. We just have not gotten around to marking it correctly in all places yet.

A small update here: The RevisonSlider for the MobileDiff view is still WIP. We have to finish some general last UI improvements and refactoring in the main version before we get back got the mobile version.

Lea_WMDE renamed this task from RevisionSlider is not visible on the mobile diff view (beta only) to RevisionSlider for mobile view.Mar 23 2018, 1:33 PM

Un-assigning myself, as I'm not working on at the moment.

Change #354642 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/RevisionSlider@master] Enable RevisionSlider for mobile diff pages

Reason:

RevisionSlider appears on mobile now.

https://gerrit.wikimedia.org/r/354642