Page MenuHomePhabricator
Create Task
Maniphest T166151

"No results found" message not visible when keyboard active when triggered from the **Article** view
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
cooltey
Authored By
Kaartic
May 23 2017, 4:55 PM
Tags
Referenced Files
F18424488: Screenshot_2018-05-21-19-58-45.png
May 21 2018, 2:35 PM
F18424485: Screenshot_2018-05-21-20-00-58.png
May 21 2018, 2:35 PM
F8391978: Screenshot_20170606-204130.png
May 21 2018, 1:32 PM
F8391977: Screenshot_20170606-204143.png
May 21 2018, 1:32 PM
F8174874: Screenshot_20170524-143556.png
May 25 2017, 11:45 AM
F8169326: "No Results Found" message not found.png
May 23 2017, 4:55 PM
Subscribers
ABorbaWMF
Aklapper
gerritbot
Jcasariego
Kaartic
RHo

Description

While trying to search using the search icon displayed while reading an article, the "No Results Found" message that is displayed is not completely visible.

Steps to reproduce

  1. Open the Main Page (probably by opening a new tab)
  2. Tap the search icon
  3. Type random letters so that results aren't found

Expected results
"No Results Found" message displayed is visible even when keyboard is active

Actual results
"No Results Found" message is only partially visible when keyboard is active. It is completely visible only when keyboard is hidden.

Screen shot

"No Results Found" message not found.png (960×540 px, 53 KB)

Note: This also applies for the empty search illustration and message that appears when user invokes search from an article page (clear all recent searches to see this initial message):

Screenshot_20170524-143556.png (1×1 px, 100 KB)

Related ticket: T137116

Environments observed
App version : 2.5.195-alpha-2017-05-22
Android version : 5.1.1
Device vendor : Samsung
Device model : Galaxy J2 (SM-J200G)

Details

SubjectRepoBranchLines +/-
Split off SearchFragment into its own Activityapps/android/wikipediamaster+94 -306
Customize query in gerrit

Related Objects

Event Timeline

Kaartic created this task.May 23 2017, 4:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 23 2017, 4:55 PM
• NHarateh_WMF added a project: Android-app-Bugs.May 24 2017, 3:24 PM
• NHarateh_WMF set the point value for this task to 1.
• NHarateh_WMF moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.
RHo renamed this task from "No results found" message not visible when keyboard active to "No results found" message not visible when keyboard active when triggered from Article tabs.May 25 2017, 11:45 AM
RHo updated the task description. (Show Details)
RHo mentioned this in T137116: Create an interesting design for an empty Search screen..
• Mholloway subscribed.May 25 2017, 12:43 PM
Jcasariego subscribed.Jul 17 2017, 4:28 PM
RHo closed this task as Resolved.May 21 2018, 1:32 PM
RHo claimed this task.
RHo subscribed.

Resolved in T137116

Screenshot_20170606-204130.png (1×1 px, 110 KB)
Screenshot_20170606-204143.png (1×1 px, 86 KB)
Kaartic added a comment.May 21 2018, 2:35 PM

@RHo I don't think it's fixed yet. I could reproduce this with the steps to reproduce noted in the task description.

Screenshot_2018-05-21-20-00-58.png (800×480 px, 53 KB)

Screenshot_2018-05-21-19-58-45.png (800×480 px, 46 KB)

RHo renamed this task from "No results found" message not visible when keyboard active when triggered from Article tabs to "No results found" message not visible when keyboard active when triggered from the **Article** view.May 21 2018, 2:37 PM
RHo reopened this task as Open.
RHo triaged this task as Medium priority.
RHo updated the task description. (Show Details)

sorry @Kaartic my bad, it's weird that this is only happening for searches via article but not from the Explore feed.

RHo mentioned this in T194958: [BUG] Empty state illustrations on Reading lists and History moving when search is triggered.May 21 2018, 2:41 PM
RHo moved this task from Bug Backlog to Needs Triage on the Wikipedia-Android-App-Backlog board.
LGoto edited projects, added Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog.May 21 2018, 4:16 PM
• Mholloway unsubscribed.May 22 2018, 12:29 AM
Kaartic added a comment.Jun 28 2018, 10:36 AM

This seems to be partially solved in T194958 but the issue seems to be coming back in the following case:

  1. Open the app
  2. Tap on the search bar to search Wikipedia
  3. Tap on the 'MORE' button to view the language list (or the language button if the app is currently made to handle only one language)
  4. Come Back (with/without changing the languages) to the search screen

Expected results

The empty search history/the no results found illustration continue remain centered after the above steps.

Actual results

After the steps, the empty search history/the no results found illustration aren't centered.

Kaartic mentioned this in T194528: JavaScript requirement of beta features is not specified correctly .Jul 1 2018, 1:14 PM
• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme); removed Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake).Aug 13 2018, 5:14 PM
Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme). · View Herald TranscriptAug 13 2018, 5:14 PM
• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme); removed Wikipedia-Android-App-Backlog.Aug 14 2018, 3:56 PM
cooltey claimed this task.Oct 25 2018, 12:22 AM
cooltey moved this task from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.
gerritbot subscribed.Oct 26 2018, 12:44 AM

Change 469811 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Views are not able to be scrolled after returning to the Search page

https://gerrit.wikimedia.org/r/469811

gerritbot added a project: Patch-For-Review.Oct 26 2018, 12:44 AM
cooltey moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Oct 26 2018, 12:50 AM
Dbrant moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Nov 29 2018, 4:21 PM
Dbrant moved this task from QA signoff to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Nov 29 2018, 5:18 PM
gerritbot added a comment.Nov 29 2018, 7:27 PM

Change 469811 merged by jenkins-bot:
[apps/android/wikipedia@master] Split off SearchFragment into its own Activity

https://gerrit.wikimedia.org/r/469811

cooltey moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Nov 29 2018, 10:23 PM
ABorbaWMF moved this task from QA signoff to Ready for signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Dec 5 2018, 3:14 AM
ABorbaWMF subscribed.

Fixed on 2.7.268-alpha-2018-12-04

Dbrant closed this task as Resolved.Dec 7 2018, 6:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL