Page MenuHomePhabricator

Jcasariego (Jorge Casariego)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 6 2017, 2:32 PM (124 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Jcasariego [ Global Accounts ]

Recent Activity

Jan 9 2018

Jcasariego added a comment to T182661: Random dice icon in FAB should be larger .

@RHo currently "back button" and "save button" have 40x40dp.

Jan 9 2018, 6:34 PM · Android-app-feature-UX-Debt, Reading Epics (Feed 2.0), Wikipedia-Android-App-Backlog
Jcasariego added a comment to T167314: Create EventLogging dev setting.

@Niedzielski after doing a git pull the bug has gone. So, no more error :)

Jan 9 2018, 6:05 PM · Patch-For-Review, good first bug, Technical-Debt, Wikipedia-Android-App-Backlog

Jan 5 2018

Jcasariego added a comment to T167314: Create EventLogging dev setting.

@Niedzielski I was trying to see how the developer settings works but after tap seven times on the circular Wikipedia logo I got the following error:

Jan 5 2018, 3:18 PM · Patch-For-Review, good first bug, Technical-Debt, Wikipedia-Android-App-Backlog

Dec 27 2017

Jcasariego added a comment to T180000: Enable page titles to be shown completely.

I'll see how it look with this titles!

Dec 27 2017, 1:38 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt

Dec 26 2017

Jcasariego added a comment to T180385: Enable sharing of ‘On this day’ event content.

Yes... now I understand the difference between one task and the other. Thanks for clarifying!

Dec 26 2017, 9:15 PM · Android-app-feature-UX-Debt, Reading Epics (Feed 2.0), Wikipedia-Android-App-Backlog
Jcasariego added a comment to T180000: Enable page titles to be shown completely.

Hi @Dbrant , according to the documentation when Autosizing is enabled, this scales the text uniformly on horizontal and vertical axes, ignoring the text size attribute.

Dec 26 2017, 7:21 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt
Jcasariego added a comment to T180385: Enable sharing of ‘On this day’ event content.

Hi @RHo I've been reading this task and I find it very similar to T180391

Dec 26 2017, 2:16 PM · Android-app-feature-UX-Debt, Reading Epics (Feed 2.0), Wikipedia-Android-App-Backlog

Dec 23 2017

Jcasariego added a comment to T180391: Enable secondary actions on articles shown within On this day.

@RHo this is how it looks with the new component:

Dec 23 2017, 1:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape), Patch-For-Review, good first bug, Reading Epics (Feed 2.0)

Dec 22 2017

Jcasariego added a comment to T180391: Enable secondary actions on articles shown within On this day.

@RHo I didn't see the comment about re-using the same component built when tapping on overflows of articles saved to a reading list. I thought it was to use the same design that I used in the proposal 1. I'll see how is implemented and I'll update the design.

Dec 22 2017, 4:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape), Patch-For-Review, good first bug, Reading Epics (Feed 2.0)
Jcasariego added a comment to T180391: Enable secondary actions on articles shown within On this day.

This is how it looks using a long-press re-using the same component built when tapping on overflows

Dec 22 2017, 2:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape), Patch-For-Review, good first bug, Reading Epics (Feed 2.0)

Dec 21 2017

Jcasariego added a comment to T180391: Enable secondary actions on articles shown within On this day.

Great @RHo - I'll make an update using a long-press and I'll show you what it looks like.

Dec 21 2017, 11:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape), Patch-For-Review, good first bug, Reading Epics (Feed 2.0)
Jcasariego added a comment to T180391: Enable secondary actions on articles shown within On this day.

Hi @RHo , I was implementing the proposed solution with a small overflow on each inset article card.

Dec 21 2017, 4:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape), Patch-For-Review, good first bug, Reading Epics (Feed 2.0)
Jcasariego claimed T180391: Enable secondary actions on articles shown within On this day.
Dec 21 2017, 4:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape), Patch-For-Review, good first bug, Reading Epics (Feed 2.0)

Dec 11 2017

Jcasariego added a comment to T179334: Replace anonymous classes with lambdas.

Hello @Dbrant , I would like to take this task.

Dec 11 2017, 4:10 PM · Patch-For-Review, good first bug, Wikipedia-Android-App-Backlog

Nov 21 2017

Jcasariego added a comment to T177879: Display storage space and file size in appropriate units.

@Dbrant @Aklapper: Volunteers can take any of these tasks with tags "Easy" and "Google-Code-in-2017." or just those with the "Easy" tag?

Nov 21 2017, 3:41 PM · Patch-For-Review, good first bug, Wikipedia-Android-App-Backlog, Android-app-feature-Compilations

Oct 10 2017

Jcasariego claimed T121410: Improve error handling in Featured Article widget..
Oct 10 2017, 8:50 PM · Patch-For-Review, WorkType-NewFunctionality, good first bug, Wikipedia-Android-App-Backlog

Sep 13 2017

Jcasariego claimed T175674: [BUG] Next button color in article editing is using incorrect old color .
Sep 13 2017, 7:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩), Patch-For-Review, good first bug, Android-app-Bugs

Aug 17 2017

Jcasariego updated subscribers of T164926: For reading lists with description text that exceeds the 2-lines, use an ellipsis to indicate truncation in the reading list list-item.

Thanks @Mholloway for your help in this task. I've never try changing GoneIfEmptyTextView by a TextView and that was precisely the problem.

Aug 17 2017, 1:15 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩), Patch-For-Review, good first bug, Android-app-Bugs, Android-app-feature-UX-Debt

Aug 14 2017

Jcasariego claimed T172701: Offline message should be displayed in a better way in landscape mode.
Aug 14 2017, 8:08 PM · Patch-For-Review, Android-app-Bugs, good first bug, Wikipedia-Android-App-Backlog

Aug 11 2017

Jcasariego claimed T173092: [BUG] "Got it" button on Reading list onboarding tutorial should be blue.
Aug 11 2017, 2:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩), Patch-For-Review, good first bug, Android-app-Bugs

Aug 10 2017

Jcasariego added a comment to T172701: Offline message should be displayed in a better way in landscape mode.

Simplest solution - put it in a scrollable view.

Yeah, but I find scrolling for an error view to be a bit overkill. There should be something even simpler?

Aug 10 2017, 1:29 AM · Patch-For-Review, Android-app-Bugs, good first bug, Wikipedia-Android-App-Backlog

Aug 7 2017

Jcasariego added a comment to T69628: i18n translations strings for 'yes' and 'no' are used in multiple questions.

Currently, the yes-no strings in the Android app are used to confirm the following dialog box questions:

Aug 7 2017, 7:31 PM · Patch-For-Review, good first bug, Android-app-Bugs, WorkType-Maintenance, I18n, Wikipedia-Android-App-Backlog
Jcasariego claimed T69628: i18n translations strings for 'yes' and 'no' are used in multiple questions.
Aug 7 2017, 7:14 PM · Patch-For-Review, good first bug, Android-app-Bugs, WorkType-Maintenance, I18n, Wikipedia-Android-App-Backlog
Jcasariego claimed T164926: For reading lists with description text that exceeds the 2-lines, use an ellipsis to indicate truncation in the reading list list-item.
Aug 7 2017, 3:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩), Patch-For-Review, good first bug, Android-app-Bugs, Android-app-feature-UX-Debt

Jul 26 2017

Jcasariego claimed T170757: [BUG] Buttons on login screens have incorrect dimensions .
Jul 26 2017, 4:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.20x-Dookie💩), Patch-For-Review, good first bug, Android-app-Bugs

Jul 24 2017

Jcasariego added a comment to T150860: RandomSummaryClient is redundant.

Luckily it wasn't so much,, but the good thing about all this was that I understood a little more of the base code!

Jul 24 2017, 8:24 PM · good first bug, Technical-Debt, Wikipedia-Android-App-Backlog

Jul 20 2017

Jcasariego added a comment to T150860: RandomSummaryClient is redundant.

Hey @Mholloway I have some questions to try to understand a little more about this task.

Jul 20 2017, 10:12 PM · good first bug, Technical-Debt, Wikipedia-Android-App-Backlog

Jul 5 2017

Jcasariego added a comment to T162839: Update visual design of user education UI for first time adding to a reading list.

Should work now, pinged on global edit rules.

Works! Thank you.

Jul 5 2017, 4:19 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪), Patch-For-Review, good first bug, Android-app-feature-UX-Debt

Jun 30 2017

Jcasariego claimed T166432: "No results" message overlaps other error messages in search results view.
Jun 30 2017, 1:59 PM · Patch-For-Review, Android-app-Bugs, Wikipedia-Android-App-Backlog

Jun 21 2017

Jcasariego placed T164957: Show complete license info for images shown in full screen up for grabs.
Jun 21 2017, 10:40 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme), Patch-For-Review

Jun 20 2017

Jcasariego updated subscribers of T162839: Update visual design of user education UI for first time adding to a reading list.

I want to show you here an example adding bullet points in the same TextView and another doing separately in an extra TextView

Jun 20 2017, 9:05 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪), Patch-For-Review, good first bug, Android-app-feature-UX-Debt

Jun 15 2017

Jcasariego added a comment to T162839: Update visual design of user education UI for first time adding to a reading list.

This is the result with the new illustration

Jun 15 2017, 11:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪), Patch-For-Review, good first bug, Android-app-feature-UX-Debt

Jun 14 2017

Jcasariego added a comment to T162839: Update visual design of user education UI for first time adding to a reading list.

@RHo I was working on the design and here is the first version of the dialog:

Jun 14 2017, 9:24 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪), Patch-For-Review, good first bug, Android-app-feature-UX-Debt
Jcasariego claimed T162839: Update visual design of user education UI for first time adding to a reading list.
Jun 14 2017, 12:09 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪), Patch-For-Review, good first bug, Android-app-feature-UX-Debt

Jun 9 2017

Jcasariego added a comment to T162839: Update visual design of user education UI for first time adding to a reading list.

Great! I was curious because I've seen links to Zeplin in several tasks. If there is no problem I'd like to have access to see detail of mocks and assets :)

Jun 9 2017, 3:42 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪), Patch-For-Review, good first bug, Android-app-feature-UX-Debt
Jcasariego added a comment to T162839: Update visual design of user education UI for first time adding to a reading list.

Hey @RHo, access to Zeplin is just for Wikimedia members?

Jun 9 2017, 1:29 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.19x-Cookie🍪), Patch-For-Review, good first bug, Android-app-feature-UX-Debt

Jun 8 2017

Jcasariego removed a watcher for Wikipedia-Android-App-Backlog: Jcasariego.
Jun 8 2017, 5:22 PM
Jcasariego added a comment to T164957: Show complete license info for images shown in full screen.

Thanks @RHo , now I have a little more clear. I'll investigate how it works on iOS before starting to update something.

Jun 8 2017, 1:29 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme), Patch-For-Review

Jun 7 2017

Jcasariego claimed T166080: Update API calls for new default pilimit.
Jun 7 2017, 11:58 PM · Patch-For-Review, Technical-Debt, good first bug, Wikipedia-Android-App-Backlog
Jcasariego added a comment to T164957: Show complete license info for images shown in full screen.

I have a question, I'd like to know if all the images in Wikipedia are Creative Commons or Public License type, and if an image have Creative Common license, then it is always "BY-SA" type?

Jun 7 2017, 10:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme), Patch-For-Review

May 26 2017

Jcasariego added a comment to T152413: Retrofit SuggestionsTask.

Finally, I solved it by doing something that I already did several times :D

May 26 2017, 5:48 AM · Patch-For-Review, good first bug, Technical-Debt, Wikipedia-Android-App-Backlog

May 25 2017

Jcasariego added a comment to T137116: Create an interesting design for an empty Search screen..

Sorry @Mholloway, but I didn't see that you already did the update of this yesterday :/

No worries, I did a quick patch while I was looking over Rita's feedback but it hadn't gotten any review feedback yet. I can revive that one, or if you've got a patch ready to go, please feel free to push it up and I'll review and merge!

May 25 2017, 11:47 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Patch-For-Review, good first bug, Design, Android-app-feature-UX-Debt
Jcasariego added a comment to T137116: Create an interesting design for an empty Search screen..

Great @RHo . I'll update the attribute and then push it up

May 25 2017, 6:21 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Patch-For-Review, good first bug, Design, Android-app-feature-UX-Debt
Jcasariego added a comment to T152413: Retrofit SuggestionsTask.

@Mholloway I'm working on this task but I have some questions

May 25 2017, 6:10 PM · Patch-For-Review, good first bug, Technical-Debt, Wikipedia-Android-App-Backlog
Jcasariego updated subscribers of T152413: Retrofit SuggestionsTask.
May 25 2017, 5:36 PM · Patch-For-Review, good first bug, Technical-Debt, Wikipedia-Android-App-Backlog
Jcasariego added a comment to T137116: Create an interesting design for an empty Search screen..

Sorry @Mholloway, but I didn't see that you already did the update of this yesterday :/

May 25 2017, 2:52 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Patch-For-Review, good first bug, Design, Android-app-feature-UX-Debt
Jcasariego added a comment to T137116: Create an interesting design for an empty Search screen..
  • "Search and explore...." text has a shorter line-height (looks like ~20dp) than the expected 24dp for the Material Subhead secondary text-style

Sorry, but I don't understanding to which text are you referring? Is it the text "Search..." in the Toolbar or the text below the image?

I'm referring to the text below the image:

May 25 2017, 2:42 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Patch-For-Review, good first bug, Design, Android-app-feature-UX-Debt
Jcasariego added a comment to T137116: Create an interesting design for an empty Search screen..
Visual design:
  • Background is using #FFF instead of the expected base80 color (#EAECF0)

I updated with base80 color and this is the result

May 25 2017, 1:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Patch-For-Review, good first bug, Design, Android-app-feature-UX-Debt

May 22 2017

Jcasariego added a comment to T165895: Remove splash screen.

I think Wikipedia is using the same approach that Google Drive, Google Photos, Twitter, Evernote and others that first show the logo while de app is downloading all the necessary data.

May 22 2017, 4:12 PM · Technical-Debt, Design, Wikimedia-Hackathon-2017, Wikipedia-Android-App-Backlog

May 20 2017

Jcasariego claimed T164957: Show complete license info for images shown in full screen.
May 20 2017, 2:52 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme), Patch-For-Review

May 16 2017

Jcasariego added a comment to T137116: Create an interesting design for an empty Search screen..

Thanks @RHo

May 16 2017, 10:23 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Patch-For-Review, good first bug, Design, Android-app-feature-UX-Debt

May 9 2017

Jcasariego claimed T152413: Retrofit SuggestionsTask.
May 9 2017, 11:57 PM · Patch-For-Review, good first bug, Technical-Debt, Wikipedia-Android-App-Backlog

May 6 2017

Jcasariego claimed T137116: Create an interesting design for an empty Search screen..

@RHo I could take this task. Does the final result have to be like the image Search Wikipedia - empty state v2.png?

May 6 2017, 9:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Patch-For-Review, good first bug, Design, Android-app-feature-UX-Debt

May 5 2017

Jcasariego added a comment to T163389: Reading list page on/offline toggle button could use a wider (48dp) touch target.

No problem @Mholloway Time to looking for another task!

May 5 2017, 9:33 PM · Patch-For-Review, good first bug, Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog

May 4 2017

Jcasariego added a comment to T163389: Reading list page on/offline toggle button could use a wider (48dp) touch target.

I think we could do the same with @+id/page_list_item_status_icon, because it is also using 40dp x 40dp

May 4 2017, 2:36 PM · Patch-For-Review, good first bug, Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog
Jcasariego claimed T163389: Reading list page on/offline toggle button could use a wider (48dp) touch target.
May 4 2017, 2:00 PM · Patch-For-Review, good first bug, Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog

May 3 2017

Jcasariego added a comment to T152406: Retrofit ImageLicenseFetchTask.

for this task I created a new class called MwQueryImageLicensePage to manage all the images license.

May 3 2017, 7:20 PM · Patch-For-Review, good first bug, Technical-Debt, Wikipedia-Android-App-Backlog

May 2 2017

Jcasariego claimed T152406: Retrofit ImageLicenseFetchTask.
May 2 2017, 6:14 PM · Patch-For-Review, good first bug, Technical-Debt, Wikipedia-Android-App-Backlog

Apr 27 2017

Jcasariego added a watcher for Android-app-feature-UX-Debt: Jcasariego.
Apr 27 2017, 6:52 PM

Apr 26 2017

Jcasariego claimed T152405: Retrofit GetDescriptionsTask.

I'll try to get more familiar with the codebase doing this task. I'll begin refactoring GetDescriptionsTask using Retrofit

Apr 26 2017, 5:49 PM · Patch-For-Review, good first bug, Technical-Debt, Wikipedia-Android-App-Backlog

Apr 24 2017

Jcasariego added a member for Wikipedia-Android-App-Backlog: Jcasariego.
Apr 24 2017, 7:14 PM
Jcasariego claimed T103685: require confirmation for deleting one item from history.

It's ok to add this as alert?

Apr 24 2017, 2:51 PM · Patch-For-Review, WorkType-NewFunctionality, good first bug, Wikipedia-Android-App-Backlog

Apr 21 2017

Jcasariego added a comment to T161340: Android app does not link to OSM license.

@Mholloway I updated the code with the change suggested. Now, without a drawable the code in fragment_nearby.xml is a lot simpler

Apr 21 2017, 5:06 PM · Patch-For-Review, good first bug, Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Android-app-Bugs

Apr 19 2017

Jcasariego moved T161340: Android app does not link to OSM license from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.
Apr 19 2017, 4:50 PM · Patch-For-Review, good first bug, Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Android-app-Bugs

Apr 18 2017

Jcasariego added a comment to T161340: Android app does not link to OSM license.

Thanks @RHo for all the clarifications. @Nirzar I've added the changes.

Apr 18 2017, 8:37 PM · Patch-For-Review, good first bug, Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Android-app-Bugs

Apr 17 2017

Jcasariego removed a watcher for Wikipedia-iOS-App-Backlog: Jcasariego.
Apr 17 2017, 7:32 PM
Jcasariego added a comment to T161340: Android app does not link to OSM license.

I was working on how to implement the text with outline around it and I didn't find an easy way. I did 2 examples to show you what I was doing.

Apr 17 2017, 7:28 PM · Patch-For-Review, good first bug, Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Android-app-Bugs

Apr 12 2017

Jcasariego added a watcher for Wikipedia-iOS-App-Backlog: Jcasariego.
Apr 12 2017, 9:55 PM
Jcasariego claimed T161340: Android app does not link to OSM license.

As this will be my first time contribution, I'm gonna pick this task

Apr 12 2017, 7:49 PM · Patch-For-Review, good first bug, Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴), Android-app-Bugs

Apr 6 2017

Jcasariego removed a member for Wikipedia-Android-App-Backlog: Jcasariego.
Apr 6 2017, 4:34 PM
Jcasariego added a member for Wikipedia-Android-App-Backlog: Jcasariego.
Apr 6 2017, 4:33 PM
Jcasariego added a watcher for Wikipedia-Android-App-Backlog: Jcasariego.
Apr 6 2017, 4:31 PM
Jcasariego added a watcher for Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴): Jcasariego.
Apr 6 2017, 4:12 PM
Jcasariego added a watcher for Android-app-Bugs: Jcasariego.
Apr 6 2017, 3:42 PM