Page MenuHomePhabricator

Show complete license info for images shown in full screen
Closed, ResolvedPublic1 Estimated Story Points

Description

NOTE: Bumping to the top to discuss after switching to PCS media endpoint (see T193275)

Image license attribution is not completely shown (and sometime inaccurate) when image is opened in full screen

Steps to reproduce:

  1. Open an article (eg., French presidential election, 2017
  2. Tap on an image to open in full screen
  3. Open another image which is FAL (eg., an image on the Mushroom Stones article

Actual:
Step 2 - Image license info only shows an icon for "CC"

main-MainActivity-05102017183532.png (1×1 px, 2 MB)

Step 3 - Image license is incorrectly showing as "CC" when it should be "FAL"

Expected:

  • The complete license should be rendered in the corresponding icons. In the screenshot example there should be 3 icons (CC-BY-SA)

image.png (278×836 px, 152 KB)
(from iOS app)

  • In the case of GFDL, LFDL, FAL or Fair use images:
    • Use the one simplified ribbon logo followed by the license

Example - ribbon icon applied across all free and fair use image licenses (68×705 px, 9 KB)

  • There is a "•" (Bullet Unicode U+2022) as the separator between the license name text and the author:

image.png (1×1 px, 2 MB)
(eg. from iOS)

See related tickets:

Assets:

I've attached the following assets as a folder of SVGs and PDFs in black and white.

Image license icons (274×519 px, 20 KB)

List of more license examples

Event Timeline

Hey @RHo,

I have a question, I'd like to know if all the images in Wikipedia are Creative Commons or Public License type, and if an image have Creative Common license, then it is always "BY-SA" type?

I read that there are 7 types of licenses normally used in Creative Commons such as BY, BY-SA, BY-NC, etc.

So, if in Wikipedia the licenses are always of the type "BY-SA", I can update the code to add the icons (CC-BY-SA) if the type of license is CC

RHo updated the task description. (Show Details)

Hi @Jcasariego – unfortunately it's a little more complicated than that. For example, this image of Tom Scholz is CC BY 3.0 (but not ShareAlike = SA).
I've updated the task description with more details which hopefully gives a better idea of the scope of this task.

You can also find additional examples and context on the corresponding iOS ticket T127377: Provide license name (or more specific icons) in app.

Thanks @RHo , now I have a little more clear. I'll investigate how it works on iOS before starting to update something.

Jcasariego added a subscriber: Jcasariego.
RHo moved this task from Bug Backlog to Needs Triage on the Wikipedia-Android-App-Backlog board.
RHo updated the task description. (Show Details)

Change 440913 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] [WIP] Show complete license info for images shown in full screen

https://gerrit.wikimedia.org/r/440913

Change 440913 abandoned by Sharvaniharan:
Show complete license info for images shown in full screen

Reason:
Will create a new patch making use of PCS media end-point

https://gerrit.wikimedia.org/r/440913

Change 440913 restored by Sharvaniharan:
Show complete license info for images shown in full screen

https://gerrit.wikimedia.org/r/440913

Change 440913 abandoned by Sharvaniharan:
Show complete license info for images shown in full screen

https://gerrit.wikimedia.org/r/440913

Change 468676 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] [WIP]Show complete license info for images shown in full screen

https://gerrit.wikimedia.org/r/468676

Change 468676 merged by jenkins-bot:
[apps/android/wikipedia@master] Show complete license info for images shown in full screen

https://gerrit.wikimedia.org/r/468676

ABorbaWMF added a subscriber: ABorbaWMF.

LGTM on 2.7.266-alpha-2018-11-27

I did find a related issue while testing this T210544