I set up a category to play around with ordered and unordered lists and noticed the following:

preview for List1:

preview for planet:

I don't see anything in the wikitext that would make these different

Not seeing in description list:

As I mentioned in an earlier task comment this seems tricky with how we currently cut off previews.

Does anybody have an idea of how we'd actually do this without introducing a monospace font? :)

In T168941#3382566, @Jdlrobson wrote:

As I mentioned in an earlier task comment this seems tricky with how we currently cut off previews.

Does anybody have an idea of how we'd actually do this without introducing a monospace font? :)

We answered this question during grooming/estimation: @Nirzar has approved removing the vertical margins from list items in previews. They should occupy a line, meaning that our truncation mechanism will still work.

Change 362454 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/Popups@master] Enforce no top&bottom margins on lists on page previews

https://gerrit.wikimedia.org/r/362454

Change 362454 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Enforce no top&bottom margins on lists on page previews

https://gerrit.wikimedia.org/r/362454

👍

With my local PP client pointed at the Beta Cluster's RESTBase instance, I see the following:

You'll note that the text truncation mechanism is working correctly and that there's no over-/underflow of the last list element.

@phuedx, @pmiazga added test plan. A question though, in https://en.wikipedia.beta.wmflabs.org/wiki/Category:Page_previews_debug, the definition list is the only one that displays the correct preview.

Also, the preview looks great for https://en.wikipedia.beta.wmflabs.org/wiki/Planet, but not for https://en.wikipedia.beta.wmflabs.org/wiki/Intro_of_planet_articles, not sure what's going on.

In T168941#3402152, @ovasileva wrote:

... A question though, in https://en.wikipedia.beta.wmflabs.org/wiki/Category:Page_previews_debug, the definition list is the only one that displays the correct preview.

It looks like the changes aren't propagating to RESTBase on the Beta Cluster /cc @mobrovac @Pchelolo @GWicke

@phuedx I have just deployed RESTBase in BetaCluster, so it matches the latest code deploy.

Here is what I am seeing:

^ @ABorbaWMF: Is that a thumbs up or a thumbs down?

In T168941#3404494, @mobrovac wrote:

@phuedx I have just deployed RESTBase in BetaCluster, so it matches the latest code deploy.

It seems this still isn't functioning correctly? Note the middle four screenshots. That said, if the issues is just restbase acting up on the beta cluster, with all the other examples being okay, I suppose we're done?

I updated the "Intro of planet artices" page at 9:33 AM, 6th July 2017 (UTC) and the RESTBase response hasn't updated after 16 minutes [0].

{
  "title": "Intro of planet articles",
  "displaytitle": "Intro of planet articles",
  "pageid": 186832,
  "extract": "A planet is an astronomical body orbiting a star or stellar remnant that",
  "extract_html": "<p>A <b>planet</b> is an astronomical body orbiting a star or stellar remnant that</p>",
  "lang": "en",
  "dir": "ltr",
  "timestamp": "2017-07-03T18:37:12Z"
}

/cc @mobrovac

@ABorbaWMF unrelated question: what browser is that? the outline for popover is missing. we use double shadow to create the outline.. if that's a very old browser then it's fine but if it's latest safari then I'm worried about the border :(

@mobrovac beta cluster doesn't seem to be responding to edits. Can you help us debug this?

Compare
https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/summary/Intro_of_planet_articles
with
https://en.wikipedia.beta.wmflabs.org/wiki/Special:ApiSandbox#action=query&format=json&prop=extracts&titles=Intro%20of%20planet%20articles&exsentences=3

@Nirzar I was using crossbrowsertesting and Safari 10

In T168941#3412196, @Nirzar wrote:

@ABorbaWMF unrelated question: what browser is that? the outline for popover is missing. we use double shadow to create the outline.. if that's a very old browser then it's fine but if it's latest safari then I'm worried about the border :(

Confirmed. That's Safari 10+ – I see it in Safari 10.1.1 on macOS Sierra (10.12.5).

@Jdlrobson created T169912 to track not working beta cluster as it seems unrelated to this. Will have a look today.

Sorry for the hold-up folks, RB in Beta works as expected now.

❤️

Null-editing the pages in the Page Previews debug category seems to have resolve the issue with the middle two articles:

and

@ovasileva: Over to you!