Page MenuHomePhabricator

Adapt 'Watchlisted pages' filter group (or create similar one) for Watchlist
Closed, ResolvedPublic

Description

The 'Watchlisted pages' filter group will be useful on the Watchlist, but needs to be adapted for this new setting. (Or, quite possibly, it may be best to make an entirely new group with new URL parameter, since there are some significant behavioral changes and this will make adapting the URL easier.)

Required changes

  • The group moves to the top of the filter list (above the ORES filters).
  • The title of the group becomes "Watchlist activity" (instead of "Watchlisted pages")
  • The "On Watchlist" filter is eliminated (because everything here is on Watchlist)
  • The "Not on Watchlist" filter is eliminated (obviously).
  • A new filter is added, "Seen changes". This filter identifies all changes to pages the user has not visited since the changes occurred.
  • The "New Watchlist changes" filter is renamed "Unseen changes"
  • Together, the Seen and Unseen filters constitute total coverage for this page.
  • New filter descriptions and other language are shown below.

New UI language

Watchlist activity

Unseen changes
Changes to pages you haven't visited since the changes occurred.
Seen changes
Changes to pages you have visited since the changes occurred.

Related Objects

Event Timeline

Mattflaschen-WMF renamed this task from Adapt 'Watchlisted pages' filter group for Watchlist to Adapt 'Watchlisted pages' filter group (or create similar one) for Watchlist .Jul 19 2017, 11:37 PM
Mattflaschen-WMF updated the task description. (Show Details)

@Pginer-WMF please look this over.

The details described make sense. My only concern is about the consistency on the terms.
In different places we refer to the new changes on pages the user has not visited in a different way:

  • Visited/Not visited. The "Mark all pages as visited" identifies the pages with new activity as "visited".
  • New/Old. The Watchlist-related filters in the Recent Changes page include a "New Watchlist changes" filter (mentioning "visited" in the description).
  • Changed/Unchanged. The introduction text in the Watchlist page ("Pages that have been changed since you last visited them are shown...") makes reference to both "changed" and "visited".
  • Seen/Unseen. The proposed text for filters in the Watchlist page introduces a new concept of "seen" or "unseen" (mentioning "visited" in the description).

I don't have anything against any of those terms individually, but we may consider picking one as the primary term and use it consistently.

Change 372536 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] WLFilters: new 'watchist activity' filter group

https://gerrit.wikimedia.org/r/372536

Change 372536 merged by jenkins-bot:
[mediawiki/core@master] WLFilters: new 'watchlist activity' filter group

https://gerrit.wikimedia.org/r/372536

Etonkovidova added a subscriber: Etonkovidova.

A new filter is added, "Seen changes". This filter identifies all changes to pages the user has not visited since the changes occurred.

The 'Seen changes' does not seem to be working.

Change 373881 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] WLFilters: Fix seen/unseen filters

https://gerrit.wikimedia.org/r/373881

Change 373881 merged by jenkins-bot:
[mediawiki/core@master] WLFilters: Fix seen/unseen filters

https://gerrit.wikimedia.org/r/373881

Checked the last patch - 'Seen changes' filter works as expected.

QA Recommendation: Resolve

jmatazzoni closed this task as Resolved.Aug 26 2017, 6:21 PM