Page MenuHomePhabricator
Create Task
Maniphest T174724

[Regression] Page previews stopped working on wikis where jQuery 3 is not available
Closed, ResolvedPublic
Actions

Description

Webconsole:

Uncaught TypeError: e.getPageSummary(...).then(...).catch is not a function

Missing from:
https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures

Screenshot at 2017-09-01 00-03-34.png (1×1 px, 544 KB)

IRC report:

<CyanXerus82> Hello, the new preview features are not working for me. This started yesterday on the Catalan wikipedia but the other language it was still working, now tonight none are working. I've checked settings in preferences, I've cleared my caches and cookies, I've restarted computer. Is this feature temporarily unavailable?

Details

SubjectRepoBranchLines +/-
Revert usage of Promise A+ in actions.js#fetchmediawiki/extensions/Popupswmf/1.30.0-wmf.16+6 -5
Revert usage of Promise A+ in actions.js#fetchmediawiki/extensions/Popupsmaster+6 -5
Customize query in gerrit

Related Objects

Event Timeline

Dvorapa created this task.Aug 31 2017, 8:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2017, 8:43 PM
Vachovec1 subscribed.Aug 31 2017, 8:47 PM
Vachovec1 renamed this task from Page previews stopped working on Czech Wikipedia to [Regression] Page previews stopped working on Czech Wikipedia.Aug 31 2017, 9:07 PM
Vachovec1 added a project: Regression.
Vachovec1 added a comment.Aug 31 2017, 9:42 PM

Tested in Firefox and Chrome. Both the same - no page previews at all. Definitely a regression from today's MediaWiki rollout, because it's still working in two Firefox panels, which I have still opened (without touching the content) since (European) afternoon. Not one functional Page Preview in newly opened/actualized panels.

Quiddity renamed this task from [Regression] Page previews stopped working on Czech Wikipedia to [Regression] Page previews stopped working.Sep 1 2017, 7:06 AM
Quiddity triaged this task as Unbreak Now! priority.
Quiddity updated the task description. (Show Details)
Quiddity added subscribers: Quiddity, phuedx, ovasileva.
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptSep 1 2017, 7:06 AM
TheDJ subscribed.Sep 1 2017, 7:57 AM

It's using jQuery 3 specific catch on deferred, but that isn't available on all wikis yet pending T124742: Upgrade to jQuery 3.

This might also influence T172291: Launch page previews A/B test on enwiki and dewiki.

TheDJ mentioned this in T172291: Launch page previews A/B test on enwiki and dewiki.Sep 1 2017, 7:58 AM
Vachovec1 added a comment.Sep 1 2017, 8:43 AM

Confirming that Page previews are working for me on wikis where jQuery3 is enabled (tested on nl.wiki, pl.wiki). They are not working on wikis without jQuery3 (tested on it.wiki, es.wiki, fr.wiki).

ovasileva added projects: Web-Team-Backlog, Readers-Web-Kanbanana-Board-Old.Sep 1 2017, 9:44 AM
• Jhernandez subscribed.Sep 1 2017, 10:06 AM

This seems to have been introduced here https://gerrit.wikimedia.org/r/#/c/373327/ where I upgraded a promise usage to the jQuery 3 version, as @TheDJ mentions. I incorrectly understood that it was available already and migrated the code. As specified in T124742: Upgrade to jQuery 3 we are just starting to roll it out, so the code should be using the old promise behavior that works on v2 and v3 until rollout is complete.

I'll create a patch to fix it now.

gerritbot subscribed.Sep 1 2017, 10:13 AM

Change 375357 had a related patch set uploaded (by Jhernandez; owner: Jhernandez):
[mediawiki/extensions/Popups@master] Revert usage of Promise A in actions.js#fetch

https://gerrit.wikimedia.org/r/375357

gerritbot added a project: Patch-For-Review.Sep 1 2017, 10:13 AM
gerritbot added a comment.Sep 1 2017, 10:36 AM

Change 375360 had a related patch set uploaded (by Jhernandez; owner: Jhernandez):
[mediawiki/extensions/Popups@wmf/1.30.0-wmf.16] Revert usage of Promise A in actions.js#fetch

https://gerrit.wikimedia.org/r/375360

Jdlrobson renamed this task from [Regression] Page previews stopped working to [Regression] Page previews stopped working on wikis where jQuery 3 is not available.Sep 1 2017, 11:46 AM
gerritbot added a comment.Sep 1 2017, 12:05 PM

Change 375357 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Revert usage of Promise A in actions.js#fetch

https://gerrit.wikimedia.org/r/375357

ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Sep 1 2017, 12:10 PM
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Sep 1 2017, 1:00 PM
Jdlrobson mentioned this in T174786: Provide a reliable test environment that mimics production for running integration tests.Sep 1 2017, 1:14 PM
Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Sep 1 2017, 2:48 PM
gerritbot added a comment.Sep 1 2017, 2:58 PM

Change 375360 merged by jenkins-bot:
[mediawiki/extensions/Popups@wmf/1.30.0-wmf.16] Revert usage of Promise A in actions.js#fetch

https://gerrit.wikimedia.org/r/375360

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)); removed MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Sep 1 2017, 3:00 PM
Stashbot subscribed.Sep 1 2017, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-01T15:00:58Z] <reedy@tin> Synchronized php-1.30.0-wmf.16/extensions/Popups/: T174724 (duration: 00m 46s)

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Sep 1 2017, 3:08 PM
Jdlrobson subscribed.

Fixed in production now.

For future reference, I've documented what to do in this kind of situation here:
https://www.mediawiki.org/wiki/Reading/Web/What_to_do_with_an_UBN

Jdlrobson lowered the priority of this task from Unbreak Now! to High.Sep 1 2017, 3:08 PM
• Jhernandez assigned this task to ovasileva.Sep 1 2017, 3:13 PM

Excellent, just verified on https://ca.wikipedia.org/wiki/Portada, all working well!

Off to @ovasileva to re-check and close the task.

ovasileva closed this task as Resolved.Sep 1 2017, 3:24 PM

Ok, testing through workflow on eswiki:

Logged-in:

  • previews appearing when user preference set to enable
  • previews not appearing when preference is disabled

Anon:

  • previews appear

plwiki: previews appearing

enwiki: previews not appearing as anon, previews appearing in user preferences
dewiki: same as enwiki

looks good! Thanks all for saving the day.

TheDJ merged a task: T174754: TypeError: e.getPageSummary(...).then(...).catch is not a function.Sep 13 2017, 6:49 PM
TheDJ added subscribers: He7d3r, mb, Enterprisey.
Liuxinyu970226 unsubscribed.Sep 15 2017, 3:18 AM
MBinder_WMF moved this task from Incoming to 2017-18 Q1 on the Web-Team-Backlog board.Oct 10 2017, 7:28 PM
Dvorapa moved this task from Backlog to Done on the Page-Previews board.Mar 2 2018, 3:53 PM
Restricted Application added a subscriber: Kizule. · View Herald TranscriptMar 2 2018, 3:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL