Page MenuHomePhabricator

Infobox styling disappears in firefox
Closed, DeclinedPublic

Description

Background:

when printing an article with an infobox spanning multiple pages, the styling disappears on page n+1 (see screenshot)

Steps to recreate:

  1. Go to http://reading-web-staging.wmflabs.org/wiki/Mexico_City
  2. print article as PDF

expected behavior: infobox retains styling from first page
observed behavior: infobox does not retain styling from first page

Related Objects

Event Timeline

ovasileva created this task.Sep 4 2017, 3:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2017, 3:01 PM
ovasileva triaged this task as High priority.
Jdlrobson updated the task description. (Show Details)Sep 5 2017, 2:20 PM
Jdlrobson moved this task from To Triage to Needs Analysis on the Readers-Web-Backlog board.

At first glance this looks like a bug with Mozilla. We should investigate a bit more and see if we can determine which circumstances this happens and why.

My guess is there is very little we can do here.

maybe I'm not following the steps correct but I can't reproduce this on production. that indicates not a mozilla bug?

I was actually able to reproduce in production (Firefox 55.0.3(

Example PDF from staging (http://reading-web-staging.wmflabs.org/wiki/Mexico_City)

Example PDF from production (https://en.wikipedia.org/wiki/Mexico_City)

NOTE: the smaller version of the font sizes is also appearing in staging here.
ovasileva lowered the priority of this task from High to Normal.
ovasileva moved this task from Triage to Needs Analysis on the Proton board.Sep 6 2017, 6:59 PM

I created a MTC (attached) and the issue appears to be because of

table {border-collapse: collapse; }

What are the implications of removing this?

Nirzar added a comment.Sep 6 2017, 8:28 PM

implication is it creates gaps in TD TH cells and borders :( i think you were the one who found that fix to the gap issue :)

So declined...?

Nirzar added a comment.Sep 6 2017, 8:30 PM

are you sure this is happening on production as well. if so, we should keep it in the backlog but move it out of current print work.

It's an issue with existing print styles - Try printing https://en.wikipedia.org/wiki/Colony_of_Virginia in Firefox. Notice how "Today part of" is not enclosed in a border.

Nirzar added a comment.Sep 6 2017, 8:36 PM

alright, confirmed!

Let's move to backlog Needs analysis as we don't know if this is us or firefox?

Moving to tracking then. Let's keep it open for now.

phuedx added a subscriber: phuedx.Sep 7 2017, 1:56 PM

Could we not add the upstream issue to the print styles' project page under a "Known Issues" heading? Finding tasks (and comments) in Phab isn't a great experience.

ovasileva moved this task from Needs Analysis to Tracking on the Proton board.Sep 11 2017, 11:58 AM
This comment was removed by ABorbaWMF.

removed previous comment - wrong browser.

@ovasileva I am still seeing this on Firefox on both staging and productions.

See https://phabricator.wikimedia.org/T174955#3587598

I like the suggestion from Sam here: https://phabricator.wikimedia.org/T174955#3588362

I think it is confusing keeping this open....