| nshahquinn-wmf | |
| Sep 7 2017, 12:40 AM |
| F9364977: Screen Shot 2017-09-06 at 17.37.12.png | |
| Sep 7 2017, 12:40 AM |
When you use syntax highlighting in the 2017 source editor and select some text, the selection highlighting completely covers the text. This affects all pages and all wikis.
This happens on (beta) Firefox, but not on Chrome.
Browser: Firefox 56.0b8
OS: macOS 10.12.6
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Disable WebkitTextFillColor in Firefox+OSX | mediawiki/extensions/CodeMirror | master | +9 -2 |
We feature-detect support for transparent text in ve.ui.CodeMirrorAction.js using 'WebkitTextFillColor' in document.body.style. If it isn't available we use 30% opacity for the unhighlighted text as a fallback technique (we can't use 0% or the cursor disappears). I imagine if we forced Firefox+OSX to fail this feature test (using $.client) it might work again.
Change 394337 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] Disable WebkitTextFillColor in Firefox OSX
Change 394337 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Disable WebkitTextFillColor in Firefox OSX
Shortly before I pass into the weekend I would like to thank you for applying the fix I requested.
However, when I start typing now, the fonts that are added look blurred, or fuzzy. This disappears after deleting the new text with CTRL-Z.
Could you please have another look into this? – Thx.
Firefox ESR 52.5.3 under El Capitan
I forgot I also have to change the status of this task in order to have it reviewed again.
Please don't repurpose existing tickets for new bugs. I tried to reproduce your report but there's not enough information. Please open a new bug with detailed information.