Page MenuHomePhabricator

Roll back changes to gadgets that affect boldface on Watchlist (and update legend and documentation)
Closed, ResolvedPublic

Description

  • Roll back all bold changes. So it will work the same as before (default not bold, bold available as an option).
  • The page-top legend should read:
    • On wikis that DO CUSTOM THINGS with bold: "Changes to pages you haven't visited since the changes occurred are shown with solid markers."
    • Wikis that DO NOT do custom things with bold: "Changes to pages you haven't visited since the changes occurred are in <strong>bold</strong>, with solid markers.",
  • On Preferences page, the Gadget description text will change to:
    • Display green collapsible arrows and green bullets for changed pages in your watchlist, page history and recent changes (unavailable with the improved Watchlist user interface).

Related tickets include T175807

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
Declined Mattflaschen-WMF
Declined Mattflaschen-WMF
DeclinedNone
ResolvedEsanders
OpenNone
OpenNone
OpenNone
ResolvedCatrope
ResolvedDannyH
ResolvedDannyH
OpenNone
ResolvedCatrope
ResolvedMooeypoo
ResolvedCatrope

Event Timeline

Mattflaschen-WMF added a subscriber: Mooeypoo.

Accidentally assigned due to being created as subtask.

So it looks like what I want to do here is:

@Mattflaschen-WMF does the above look sensible?

So it looks like what I want to do here is:

@Mattflaschen-WMF does the above look sensible?

Yes, and it works, except the legend issue mentioned below.

In addition (this is all stuff we decided in the meeting to do for accuracy; otherwise, the legend says it's bold (by default) when it's not, and the green indicator gadgets "don't work"):

The page-top legend should read:
On wikis that DO CUSTOM THINGS with bold: "Changes to pages you haven't visited since the changes occurred are shown with solid markers."

https://en.wikipedia.org/wiki/User:Mattflaschen-WMF/MediaWiki:Rcfilters-watchlist-showupdated . This should be copied to anywhere this custom bold stuff exists (look for WatchlistBase or WatchlistChangesBold in P5999)

Wikis that DO NOT do custom things with bold: "Changes to pages you haven't visited since the changes occurred are in <strong>bold</strong>, with solid markers.",

This is already in core.

On Preferences page, the Gadget description text will change to:
Display green collapsible arrows and green bullets for changed pages in your watchlist, page history and recent changes (unavailable with the improved Watchlist user interface).

https://en.wikipedia.org/wiki/User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistGreenIndicators and https://en.wikipedia.org/wiki/User:Mattflaschen-WMF/MediaWiki:Gadget-WatchlistGreenIndicatorsMono . I removed the period, since that is not the convention. Also, there is a minor pre-existing wording difference between these two, which I left (though I'm not sure if it's intentional for the skin difference or not).

Unfortunately, these all require translations, so not sure how we want to handle that.

Catrope closed this task as Resolved.Oct 2 2017, 9:13 PM
Catrope claimed this task.

All done

I ended up doing this slightly differently for https://en.wikipedia.org/wiki/MediaWiki:Rcfilters-watchlist-showupdated : it now says either "Changes to pages you haven't visited since the changes occurred are shown with solid markers." or "Changes to pages you haven't visited since the changes occurred are shown in bold, with solid markers." depending on whether the bolding gadget is enabled or not.

Mattflaschen-WMF added a comment.EditedOct 3 2017, 3:42 AM

@Trizek-WMF @Catrope updated the gadgets themselves (the actual CSS) on all wikis, but the text only on English Wikipedia (and test/test2).

Other wikis using the same gadget system as English Wikipedia (a gadget that makes it so by default, unseen changes are not bold; another opt-in gadget to make them bold) should make the updates given in my previous comment (https://phabricator.wikimedia.org/T176382#3645299) (for MediaWiki:Rcfilters-watchlist-showupdated, Catrope's version is better).

In general, they can do:

https://en.wikipedia.org/wiki/MediaWiki:Something => translate to their language => theirwiki.org/wiki/MediaWiki:Something for each of the three above:

If they're not sure if their wiki is affected, they can check P5999.

@Trizek-WMF So it would be helpful if you could notify them by wikitech-ambassador/newsletter/whatever makes sense.