Avoid error validation when searching for articles to translate
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pginer-WMF
	Oct 5 2017, 10:35 AM

Description

The dialog to select an article to translate (T111094) shows an red border around the input field when it becomes empty:

An empty search is a legitimate value that we should not be warning about, especially when we'll be showing some suggestions in that state.

More generally, in a search scenario I don't think we need to surface too much the idea that the user is doing something wrong. As long as the user is aware of the results that the search is producing, there is no need for alarming the user. More on empty results in a separate ticket (T177469)

Details

	Subject	Repo	Branch	Lines +/-
	Change empty result states	mediawiki/extensions/ContentTranslation	master	+103 -32

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T76456 Language Engineering tracker of trackers (tracking)
Open	None	T127695 Design polishing for Content Translation
Resolved	• Petar.petkovic	T177470 Avoid error validation when searching for articles to translate

Event Timeline

Pginer-WMF created this task.Oct 5 2017, 10:35 AM

Pginer-WMF mentioned this in T177402: CX source selector has no focus state.Oct 5 2017, 10:40 AM

Change 383176 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Change empty result states

https://gerrit.wikimedia.org/r/383176

gerritbot added a project: Patch-For-Review.Oct 9 2017, 7:10 PM

• Petar.petkovic claimed this task.Oct 9 2017, 7:11 PM

• Petar.petkovic moved this task from Backlog to For Review on the User-Petar.petkovic board.

Change 383176 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Change empty result states

https://gerrit.wikimedia.org/r/383176

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 23 2017, 12:00 PM

Arrbee moved this task from Needs Triage to Oct-Dec 2017 on the ContentTranslation board.Oct 27 2017, 6:46 AM

• Petar.petkovic removed a project: Language-Team.Oct 27 2017, 7:04 AM

• Petar.petkovic edited projects, added Language-2017-Oct-Dec; removed User-Petar.petkovic.Oct 31 2017, 8:17 AM

• Petar.petkovic moved this task from Backlog to QA on the Language-2017-Oct-Dec board.

Checked in enwiki (wmf.5).

@Petar.petkovic There is another instance of the Search text box

click on any articles in Suggestions
delete the pre-filled article title and the empty search will be indicated with the red outline

Screen Shot 2017-11-03 at 4.57.59 PM.png (384×772 px, 71 KB)

Yes, when user clicks on any suggested article old modal dialog appears, and you can actually change the article you were suggested and search for new one.

That is set to be changed once T178866: Align the suggestion confirm dialog with the new translation one gets done.

Etonkovidova closed this task as Resolved.Nov 9 2017, 2:00 AM

Nikerabbit removed a project: Patch-For-Review.Nov 9 2017, 7:50 AM

Nikerabbit moved this task from QA to Done on the Language-2017-Oct-Dec board.