Page MenuHomePhabricator

Avoid error validation when searching for articles to translate
Closed, ResolvedPublic


The dialog to select an article to translate (T111094) shows an red border around the input field when it becomes empty:

image.png (100×592 px, 2 KB)

An empty search is a legitimate value that we should not be warning about, especially when we'll be showing some suggestions in that state.

More generally, in a search scenario I don't think we need to surface too much the idea that the user is doing something wrong. As long as the user is aware of the results that the search is producing, there is no need for alarming the user. More on empty results in a separate ticket (T177469)

Event Timeline

Change 383176 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Change empty result states

Change 383176 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Change empty result states

Checked in enwiki (wmf.5).

@Petar.petkovic There is another instance of the Search text box

  • click on any articles in Suggestions
  • delete the pre-filled article title and the empty search will be indicated with the red outline

Screen Shot 2017-11-03 at 4.57.59 PM.png (384×772 px, 71 KB)

Yes, when user clicks on any suggested article old modal dialog appears, and you can actually change the article you were suggested and search for new one.

That is set to be changed once T178866: Align the suggestion confirm dialog with the new translation one gets done.