1. It happens on "add statement", works correctly for "add value"
2. Well, let's take "instance of".
3. Both don't work.
4. The value field doesn't get selected as previously.

(using Safari on macOS High Sierra)

Can this be some side-effect of T124742? The JavaScript console is full of deprecated notices (pointing to the statement view as well).

In T177485#3661914, @Sjoerddebruin wrote:

Can this be some side-effect of T124742? The JavaScript console is full of deprecated notices (pointing to the statement view as well).

There were no official breaking changes in jQuery 3 that aren't covered by jQuery Migrate (apart from Deferred now being async, but it sometimes being sync was already unsupported). The deprecation notices mean things are working.

If this bug is triggered by a change in jQuery 3, it will not have a deprecation warning for where it went wrong.

I would recommend trying to reproduce this error on https://test.wikidata.org and, if it happens there, to first temporarily disable wgUsejQueryThree on testwikidatawiki only to verify if that is indeed the cause.

In T177485#3661657, @thiemowmde wrote:

I tried to reproduce this, and even did a "git bisect" to find a possible regression, but was unable to locate one. Can you please provide more detailed steps to reproduce the issue? For example:

• What is the exact button you click to start your process? I assume you are clicking "add statement" to select a property that was not on the entity before.
• What exactly are you typing? (Please provide a real world example, e.g. you are typing "occ" to find "occupation".)
• Are you using the mouse or enter to select a property? Are you using the cursor keys?
• What happens, and what do you expect?

@thiemowmde

• manually undertaking "add statement" or "add qualifier" [type property name or number, select it with mouse (usually)]
• following selection of the property, there is no active cursor (it used to focus within the box for the addition of the item or data)

Typical example for me is

• putting a "serial ordinal" for given names
• following selection of the property I used to be able to just type the number as the cursor was focused in the corresponding field awaiting data input, now I have to click into the field to type the number.

This has been driving me nuts since Wednesday.

Go to extant "instance of" statement

Select Add Reference

Select property "stated in"

Text edit box for the reference appears but the focus does not move there

Click in the box, add the referece

Click +Add

Select another qualifer

Text edit box for the qualifier value appears, but again the focus does not move to the new text edit box

In T177485#3662700, @Billinghurst wrote:

In T177485#3661657, @thiemowmde wrote:

I tried to reproduce this, and even did a "git bisect" to find a possible regression, but was unable to locate one. Can you please provide more detailed steps to reproduce the issue? For example:

• What is the exact button you click to start your process? I assume you are clicking "add statement" to select a property that was not on the entity before.
• What exactly are you typing? (Please provide a real world example, e.g. you are typing "occ" to find "occupation".)
• Are you using the mouse or enter to select a property? Are you using the cursor keys?
• What happens, and what do you expect?

@thiemowmde

• manually undertaking "add statement" or "add qualifier" [type property name or number, select it with mouse (usually)]
• following selection of the property, there is no active cursor (it used to focus within the box for the addition of the item or data)

Typical example for me is

• putting a "serial ordinal" for given names
• following selection of the property I used to be able to just type the number as the cursor was focused in the corresponding field awaiting data input, now I have to click into the field to type the number.

Noting that "add value" for an existing property does not have this issue, it correctly has a cursor in field and takes text

Adding it to the list for the next sprint.

@thiemowmde triaged this task as Low priority.

@thiemowmde raised the priority of this task from Low to High.

Off-topic: I don't think lowering the priority of the task for the sole reason that additional information is expected is a good usage of this phabricator functionality.

I raised the priority to high, and you still have the nerve to complain? Seriously?

Guys, let's take it down a notch :)
We're taking this in the new sprint tomorrow and hopefully get it fixed soon.

Change 383362 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix: focus is not in value field after selecting a property

https://gerrit.wikimedia.org/r/383362

Change 383362 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix: focus is not in value field after selecting a property

https://gerrit.wikimedia.org/r/383362