Page MenuHomePhabricator
Create Task
Maniphest T186092

Installer auto-enables MinervaNeue but not required MobileFrontend, causing error
Closed, ResolvedPublic
Actions

Description

MinervaNeue depends on MobileFrontend. However (if you have a MinervaNeue directory), the installer auto-enables MinervaNeue, but not MobileFrontend.

This causes:

"PHP Fatal error: Uncaught Exception: MinervaNeue requires MobileFrontend to be installed. in /vagrant/mediawiki/includes/registration/ExtensionRegistry.php:267"

It should check for skin.json (where these requirements are defined), and if it exists, auto-enable the required dependencies (or don't auto-enable skins with such dependencies).

Tagging MinervaNeue for awareness, but I don't see an issue with the skin itself.

Related Objects
Search...

Event Timeline

• Mattflaschen-WMF created this task.Jan 31 2018, 4:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2018, 4:28 AM
• Niedzielski added a project: Web-Team-Backlog.Jan 31 2018, 3:15 PM
• Niedzielski moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson moved this task from Needs Prioritization to Tracking on the Web-Team-Backlog board.Jan 31 2018, 5:07 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
Jdlrobson moved this task from Backlog to Blocked on the MinervaNeue board.Jan 31 2018, 10:45 PM
Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Feb 7 2018, 5:50 PM
• Mattflaschen-WMF mentioned this in T187287: CliInstaller: Allow turning off auto-enabling of skins and extensions.Feb 14 2018, 6:43 AM
Legoktm added a parent task: T191743: Bundle MinervaNeue skin with MediaWiki.Apr 12 2018, 7:45 AM
CCicalese_WMF added a subtask: T196670: Enhance installer to support dependencies between skins and extensions.Jun 7 2018, 5:54 PM
• Gilles subscribed.Feb 21 2019, 2:58 PM
Jdlrobson subscribed.Jan 7 2020, 10:56 PM

FYI the mobilefrontend dependency will become a soft one if https://gerrit.wikimedia.org/r/559208 is reviewed and merged. I'm looking for reviewers interested in a non-wmf capacity.

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJan 7 2020, 10:56 PM
Jdlrobson mentioned this in T196670: Enhance installer to support dependencies between skins and extensions.Jan 7 2020, 10:58 PM
Jdlrobson moved this task from Blocked to Tracking on the MinervaNeue board.Jan 17 2020, 10:26 PM
Jdlrobson edited projects, added MinervaNeue (Tracking); removed MinervaNeue.
Jdlrobson closed this task as Resolved.Sep 16 2020, 10:56 PM
Jdlrobson claimed this task.

No longer a dependency between MobileFrontend and Minerva

Jdlrobson removed a subtask: T196670: Enhance installer to support dependencies between skins and extensions.Apr 13 2021, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits