Page MenuHomePhabricator
Create Task
Maniphest T191743

Bundle MinervaNeue skin with MediaWiki
Closed, ResolvedPublic
Actions

Description

  • Passed security review or already Wikimedia deployed
  • Voting CI structure tests
  • Runs MediaWiki-CodeSniffer
  • Runs phan (none of the other skins run phan yet, so it's probably ok to skip)
  • Supports MySQL, SQLite, and Postgres (no schema changes)
  • GPL v2 or later compatible license
  • Extension's default configuration provides optimal experience
  • Tested with web installer

Details

SubjectRepoBranchLines +/-
Add Minerva to 1.38mediawiki/tools/releasemaster+1 -0
Donate link is disabled by default for 3rd partiesmediawiki/skins/MinervaNeuemaster+1 -1
MinervaDonateLink is enabled in productionoperations/mediawiki-configmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

CCicalese_WMF created this task.Apr 8 2018, 6:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2018, 6:25 PM
CCicalese_WMF added a parent task: T178349: Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites.Apr 8 2018, 6:29 PM
Tgr subscribed.Apr 8 2018, 8:57 PM
Legoktm removed a project: MediaWiki-Installer.Apr 9 2018, 1:38 AM
Legoktm updated the task description. (Show Details)Apr 9 2018, 2:28 AM
Legoktm added a parent task: T191734: Bundle MobileFrontend extension with MediaWiki.
Legoktm edited parent tasks, added: T46852: Please bundle MobileFrontend and dependency in the MediaWiki distribution tarball; removed: T191734: Bundle MobileFrontend extension with MediaWiki.
Legoktm added a subtask: T191734: Bundle MobileFrontend extension with MediaWiki.
Legoktm added a subtask: T186092: Installer auto-enables MinervaNeue but not required MobileFrontend, causing error.Apr 12 2018, 7:45 AM
Legoktm updated the task description. (Show Details)Apr 16 2018, 12:33 AM
cicalese added a project: MinervaNeue.Apr 17 2018, 12:25 AM
pmiazga added a project: Web-Team-Backlog (Tracking).Apr 17 2018, 8:41 PM
• demon moved this task from Backlog to Extension bundling on the MW-1.31-release board.Apr 26 2018, 7:32 PM
Jdlrobson moved this task from Backlog to Blocked on the MinervaNeue board.Apr 26 2018, 11:38 PM
RazeSoldier closed subtask T193717: Error: Call to undefined method MobileContext::getConfigVariable() as Invalid.May 3 2018, 9:46 AM
CCicalese_WMF renamed this task from Bundle Minerva Neue skin with MW 1.31 to Bundle Minerva Neue skin with MW 1.32.Jun 7 2018, 3:57 PM
CCicalese_WMF edited parent tasks, added: T196650: Expand the set of bundled extensions and skins in MediaWiki 1.32; removed: T178349: Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites.
CCicalese_WMF edited projects, added MW-1.32-release; removed MW-1.31-release.
• Vvjjkkii reopened subtask T193717: Error: Call to undefined method MobileContext::getConfigVariable() as Open.Jul 1 2018, 1:12 AM
CommunityTechBot closed subtask T193717: Error: Call to undefined method MobileContext::getConfigVariable() as Invalid.Jul 1 2018, 7:29 AM
Legoktm moved this task from Backlog to Bundling additions on the MW-1.32-release board.Oct 9 2018, 12:40 AM
CCicalese_WMF renamed this task from Bundle Minerva Neue skin with MW 1.32 to Bundle Minerva Neue skin with MediaWiki.Nov 10 2018, 6:49 PM
CCicalese_WMF mentioned this in T209220: Expand the set of bundled extensions and skins in MediaWiki 1.34.Nov 10 2018, 6:58 PM
CCicalese_WMF edited parent tasks, added: T209220: Expand the set of bundled extensions and skins in MediaWiki 1.34; removed: T196650: Expand the set of bundled extensions and skins in MediaWiki 1.32.Nov 10 2018, 7:05 PM
CCicalese_WMF edited projects, added MW-1.33-release; removed MW-1.32-release.Nov 21 2018, 3:07 PM
MGChecker moved this task from Backlog to Bundling additions on the MW-1.33-release board.Dec 21 2018, 9:26 AM
Jdforrester-WMF edited projects, added MW-1.34-release; removed MW-1.33-release.Jun 7 2019, 9:00 PM
Krinkle moved this task from Blocker to Bundling additions on the MW-1.34-release board.Jun 15 2019, 12:28 AM
CCicalese_WMF edited projects, added MW-1.35-release; removed MW-1.34-release.Sep 13 2019, 4:24 PM
CCicalese_WMF edited parent tasks, added: T232854: Expand the set of bundled extensions and skins in MediaWiki 1.35; removed: T209220: Expand the set of bundled extensions and skins in MediaWiki 1.34.
CCicalese_WMF mentioned this in T232854: Expand the set of bundled extensions and skins in MediaWiki 1.35.Sep 13 2019, 4:29 PM
Krinkle moved this task from Blocker to Bundling on the MW-1.35-release board.Oct 11 2019, 10:45 PM
Jdlrobson moved this task from Blocked to Tracking on the MinervaNeue board.Jan 17 2020, 10:26 PM
Jdlrobson edited projects, added MinervaNeue (Tracking); removed MinervaNeue.
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptJan 17 2020, 10:26 PM
Jdforrester-WMF mentioned this in T246381: Expand the set of bundled extensions and skins in MediaWiki 1.36.Feb 27 2020, 9:15 PM
Jdforrester-WMF edited parent tasks, added: T246381: Expand the set of bundled extensions and skins in MediaWiki 1.36; removed: T232854: Expand the set of bundled extensions and skins in MediaWiki 1.35.Jul 8 2020, 10:05 AM
Jdforrester-WMF edited projects, added MW-1.36-release; removed MW-1.35-release.
Legoktm moved this task from Blocker to Bundling on the MW-1.36-release board.Jul 15 2020, 4:30 AM
Jdlrobson closed subtask T186092: Installer auto-enables MinervaNeue but not required MobileFrontend, causing error as Resolved.Sep 16 2020, 10:56 PM
Aklapper removed a parent task: T46852: Please bundle MobileFrontend and dependency in the MediaWiki distribution tarball.Nov 20 2020, 2:10 PM
Reedy renamed this task from Bundle Minerva Neue skin with MediaWiki to Bundle MinervaNeue skin with MediaWiki.Jan 29 2021, 2:48 AM
Jdforrester-WMF mentioned this in T279842: Expand the set of bundled extensions and skins in MediaWiki 1.37.Apr 10 2021, 10:47 PM
Jdforrester-WMF added a parent task: T279842: Expand the set of bundled extensions and skins in MediaWiki 1.37.
Jdforrester-WMF removed a parent task: T246381: Expand the set of bundled extensions and skins in MediaWiki 1.36.Apr 10 2021, 10:49 PM
Jdforrester-WMF edited projects, added MW-1.37-release; removed MW-1.36-release.Apr 10 2021, 10:53 PM
Jdforrester-WMF moved this task from Blocker to Bundling on the MW-1.37-release board.
CCicalese_WMF mentioned this in T196670: Enhance installer to support dependencies between skins and extensions.Apr 13 2021, 9:00 PM
Jdlrobson removed a subtask: T191734: Bundle MobileFrontend extension with MediaWiki.Apr 13 2021, 11:08 PM
JeffreyWang subscribed.May 10 2021, 6:23 PM
MarkAHershberger subscribed.May 10 2021, 6:23 PM
Jdforrester-WMF subscribed.Aug 25 2021, 5:55 PM

Hey there. This task is proposed as a blocker to MediaWiki 1.37, which will be cut in less than three weeks' time. Please consider whether this will make that deadline, and if not, move it to block the MediaWiki 1.38 release (MW-1.38-release) or remove as a blocker entirely.

Jdlrobson subscribed.Aug 25 2021, 6:35 PM

It would be really nice to bundle this as this should have been done a long time ago. I don't think there are any technical blockers?

Jdforrester-WMF updated the task description. (Show Details)Aug 25 2021, 6:45 PM
Jdforrester-WMF added a comment.Aug 25 2021, 6:50 PM
In T191743#7309773, @Jdlrobson wrote:

It would be really nice to bundle this as this should have been done a long time ago. I don't think there are any technical blockers?

The phan part has been done for a while now in T133664: Statically analyse MinervaNeue codebases with Phan.

For the default config being appropriate for third parties, just at a glance I'd have thought that MinervaDonateLink should be false not true, but that's probably me being fussy. Happy to declare it done enough.

I've not tested this with the Web installer but I assume it Just Works™?

Jdforrester-WMF updated the task description. (Show Details)Aug 25 2021, 6:51 PM
Tgr mentioned this in T290934: Expand the set of bundled extensions and skins in MediaWiki 1.38.Sep 14 2021, 12:19 AM
Tgr edited projects, added MW-1.38-release; removed MW-1.37-release.Sep 14 2021, 12:29 AM
Tgr added a parent task: T290934: Expand the set of bundled extensions and skins in MediaWiki 1.38.Sep 14 2021, 12:30 AM
Tgr moved this task from Blocker to Bundling on the MW-1.38-release board.Sep 14 2021, 5:30 AM
Jdlrobson removed a project: Web-Team-Backlog (Tracking).Sep 21 2021, 8:50 PM
gerritbot added a comment.Dec 10 2021, 7:19 PM

Change 745937 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/tools/release@master] Add Minerva to 1.38

https://gerrit.wikimedia.org/r/745937

gerritbot added a project: Patch-For-Review.Dec 10 2021, 7:19 PM
gerritbot added a comment.Dec 10 2021, 7:21 PM

Change 745940 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] MinervaDonateLink is enabled in production

https://gerrit.wikimedia.org/r/745940

gerritbot added a comment.Dec 10 2021, 7:25 PM

Change 745941 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Donate link is disabled by default for 3rd parties

https://gerrit.wikimedia.org/r/745941

gerritbot added a comment.Dec 14 2021, 12:46 AM

Change 745940 merged by jenkins-bot:

[operations/mediawiki-config@master] MinervaDonateLink is enabled in production

https://gerrit.wikimedia.org/r/745940

gerritbot added a comment.Dec 14 2021, 11:42 PM

Change 745941 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Donate link is disabled by default for 3rd parties

https://gerrit.wikimedia.org/r/745941

Jdlrobson updated the task description. (Show Details)Dec 14 2021, 11:43 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 15 2021, 12:00 AM
gerritbot added a comment.Dec 25 2021, 12:43 AM

Change 745937 merged by jenkins-bot:

[mediawiki/tools/release@master] Add Minerva to 1.38

https://gerrit.wikimedia.org/r/745937

Maintenance_bot removed a project: Patch-For-Review.Dec 25 2021, 1:10 AM
Zabe subscribed.Dec 26 2021, 1:03 PM
Jdforrester-WMF added a comment.Jan 4 2022, 4:01 PM

OK, someone now needs to send the e-mails to wikitech-l and mediawiki-l that all extension developers will now be implicitly expected to make their code compatible with MinervaNeue. Jon, I think that'd be best from you?

Jdlrobson closed this task as Resolved.Jan 7 2022, 8:08 PM
Jdlrobson claimed this task.

Done!

Jdforrester-WMF mentioned this in T305072: Expand the set of bundled extensions and skins in MediaWiki 1.39.Mar 30 2022, 3:14 PM
Izno removed a parent task: T279842: Expand the set of bundled extensions and skins in MediaWiki 1.37.Dec 28 2022, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits