Page MenuHomePhabricator

Language link changed from X to Y links to wrong URL
Closed, DuplicatePublic

Description

When changing a page X to Y that is connected to wikidata, the sitelinks is automatically updated, and the change is propagated correctly to other wikis generating "Language link changed from $1 to $2" message in recent changes. Additionally the change is propagated WRONGLY to the original site where there was a move - and links to invalid URLs for example:

  1. This change: https://www.wikidata.org/w/index.php?title=Special:EntityPage/Q1186451&curid=1131433&diff=627491344&oldid=459038914
  2. Result in link to: https://www.wikidata.org/wiki/%D7%93%D7%95%D7%97_%D7%A2%D7%9C_%D7%94%D7%A9%D7%99%D7%A0%D7%95%D7%99%D7%99%D7%9D_%D7%91%D7%94%D7%95%D7%9F_%D7%94%D7%A2%D7%A6%D7%9E%D7%99 (as appear in recent changes)

So we have here 2 issues:

  1. The URL in the recent changes points to wrong URL
  2. The change shouldn't propagate to the original wiki(?) as it already updated

Event Timeline

Can you please help us understand the issue better? At the moment, when I look at the given example page https://www.wikidata.org/wiki/Special:Diff/627491344, I can not find a "wrong" URL anywhere on that page.

I tried to dig into the code, starting from the message "Language link changed from $1 to $2" given in this tasks description. I did found the message key "wikibase-comment-sitelink-change" appears one time in the code, in SiteLinkCommentCreator::getSiteLinkAddRemoveParams. But all code I see there appears to be correct, and not mix up old and new sitelink.

I'm also looking at
https://he.wikipedia.org/w/index.php?title=דוח_על_השינויים_בהון_העצמי&action=history&uselang=en and
https://he.wikipedia.org/w/index.php?title=דוח_על_השינויים_בהון&action=history&uselang=en
which are the old and the new page from the example, and can not see an issue there.

Can you please help us understand the issue better? At the moment, when I look at the given example page https://www.wikidata.org/wiki/Special:Diff/627491344, I can not find a "wrong" URL anywhere on that page.

Hi @thiemowmde. I do not know when @eranroz will return to this page, so I'll answer you partially. I found the problem in the first place and told him, still I do not understand in Wikidata mechanics.
The Diff link you gave is not relevant for me, do not know aboyt Eran. I am talking about local wikipedias with "view wikidata changes" on.

  1. The URL in the recent changes points to wrong URL

I can't reproduce it (looking on Special:Logs/move to find recent moves, and looking for the relevant "Language link changed from $1 to $2" messages - seems like those are correct links. I guess this was due to different versions(?) but anyway this is not reproducible/invalid.

  1. The change shouldn't propagate to the original wiki(?) as it already updated

This can be reproduced by going to Special:Log/move (in some client wiki), select some article that is linked to wikidata, and search for it in the recent changes.

  1. The URL in the recent changes points to wrong URL

I can't reproduce it (looking on Special:Logs/move to find recent moves, and looking for the relevant "Language link changed from $1 to $2" messages - seems like those are correct links. I guess this was due to different versions(?) but anyway this is not reproducible/invalid.

I saw this indeed - the links open a page named by local wiki name, but on Wikidata.

Can you please share some links? I'm very much interested in finding and fixing this issue. But I'm not able to go and find "some" client wiki (Which one? We do have about a thousand of them!) and search for an error somewhere in local logs or recent changes.

I have no idea how to do this. I saw it in Datawiki revision 658328957, a lot of time ago. it's not on recent edits any more.

kostajh subscribed.

Moving to triaged; not something that the Growth-Team can look at in the short to medium term.

This bug is still present and was reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Watchlist_bug_with_wikidata (permanent link).

Steps to reproduce:

  1. Go to https://en.wikipedia.org/wiki/Special:Log/move and pick a mainspace page which was recently moved from X to Y.
  2. Click X and add X to your watchlist, assuming Y has a Wikidata item.
  3. Enable "Show Wikidata edits in your watchlist" at https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-watchlist.
  4. View https://en.wikipedia.org/wiki/Special:Watchlist and look for an entry for X saying "Language link changed from en:X to en:Y".
  5. Click "en:X" and "en:Y". The links should have gone to X and Y at enwiki but they go to the non-existing pages X and Y at Wikidata.

A current example is the move from https://en.wikipedia.org/wiki/Bovenschulte_senate to https://en.wikipedia.org/wiki/First_Bovenschulte_senate. The HTML for the watchlist entry says:

Language link changed from <a class="external" href="https://www.wikidata.org/wiki/Bovenschulte_senate">en:Bovenschulte senate</a> to <a class="external" href="https://www.wikidata.org/wiki/First_Bovenschulte_senate">en:First Bovenschulte senate</a>