Page MenuHomePhabricator

"For later" articles loaded twice
Open, LowPublic

Description

One way I found to reproduce this:

  • Have some pair of languages, say en->sr
  • Change target language to en. Automatic swap will give sr->en pair
  • While suggestions are loading (you don't even need to be that fast) change target language back to sr. Swapping will make the pair be en->sr.

So, while one request is pending, triggering another will give double results. List of Suggested pages (list below "For later" list) is also doubled.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2018, 8:56 PM

I suggest to triage this as "Low" or "Lowest", as this is edge case. Just showing how not canceling requests can bite us.

Pginer-WMF triaged this task as Low priority.Feb 26 2018, 9:17 AM

The description has the case of fast swapping of languages while suggestions are loading. I have just experienced following:

  • Selected language pair was sr->en.
  • I choose sr as target and languages get swapped. Since source and target languages are changed, new suggestions are loaded, but we have everything twice.

This might be bigger problem than edge case explained in description.