Maniphest T192912

Unexpected ratelimit makes Pywikibot crash
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Multichill
	Apr 24 2018, 2:03 PM

Description

Due to the hack done in T184948 Pywikibot crashed with this nice error.

pywikibot.data.api.APIError: failed-save: The save has failed. [help:See https://www.wikidata.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&gt; for notice of API deprecations and breaking changes.; messages:[{'name': 'wikibase-api-failed-save', 'parameters': [], 'html': {'*': 'The save has failed.'}}, {'name': 'actionthrottledtext', 'parameters': [], 'html': {'*': 'As an anti-abuse measure, you are limited from performing this action too many times in a short space of time, and you have exceeded this limit.\nPlease try again in a few minutes.'}}]]
<class 'pywikibot.data.api.APIError'>
CRITICAL: Closing network session.

Same hack also broke massmessage, see T192690. The hack was removed so the chance of someone running into this is much lower.

Pywikibot should be updated so that a throttle error is a recoverable error. So the usual logic should kick in: Wait a bit, try again.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[IMPR] 'actionthrottledtext' is a retryable wikibase error	pywikibot/core	master	+9 -9

Customize query in gerrit

Related Objects

Mentioned In: T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020
T253180: "ratelimited" API error does not throttle for rate limits
T223211: cfd.py throws an error after few seconds
Mentioned Here: T184948: limit page creation and edit rate on Wikidata
T192690: Mass message broken on Wikidata after ratelimit workaround

Event Timeline

Multichill created this task.Apr 24 2018, 2:03 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptApr 24 2018, 2:03 PM

Multichill triaged this task as High priority.Apr 24 2018, 2:04 PM

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Apr 24 2018, 2:35 PM

Edgars2007 subscribed.Apr 24 2018, 5:04 PM

MisterSynergy subscribed.May 14 2018, 5:09 PM

Lydia_Pintscher moved this task from consider for next sprint to monitoring on the Wikidata board.Jun 26 2018, 7:33 AM

• Vvjjkkii renamed this task from Unexpected ratelimit makes Pywikibot crash to nceaaaaaaa.Jul 1 2018, 1:14 AM

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

Mainframe98 renamed this task from nceaaaaaaa to Unexpected ratelimit makes Pywikibot crash.Jul 1 2018, 7:36 AM

Mainframe98 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Mainframe98 updated the task description. (Show Details)

Mainframe98 added a subscriber: Aklapper.

Dvorapa added a project: Pywikibot.Jul 15 2018, 4:26 PM

Cannot follow this task. Pywikibot is throttleling not to edit more than 6 (I guess) pages per minute by default. What might be the reason that the limit of 40 pages is exceeded. What was the putthrottle setting when the exception occurred?

Framawiki subscribed.Jul 18 2018, 6:11 PM

@Multichill is the error still given ? I've read somewhere that this hacky limitation was removed from wd.org

In T192912#4551136, @Framawiki wrote:

@Multichill is the error still given ? I've read somewhere that this hacky limitation was removed from wd.org

Yes and no. The ratelimit was removed again I think so we won't run into it. I changed the prio from high to low. Pywikibot should be updated that if the bot for whatever reason runs into a ratelimit error, it should be handled as a recoverable error. I'll update the task

@Xqt flagged bots on Wikidata usually edit a bit faster than one edits every six seconds, most of my bots are one edit every two seconds.

Multichill updated the task description. (Show Details)Sep 2 2018, 11:58 AM

Framawiki updated the task description. (Show Details)Sep 2 2018, 5:04 PM

Dvorapa mentioned this in T223211: cfd.py throws an error after few seconds.May 14 2019, 1:17 PM

Change 510690 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [IMPR] 'actionthrottledtext' is a retryable wikibase error

https://gerrit.wikimedia.org/r/510690

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 16 2019, 7:41 AM

Xqt claimed this task.May 16 2019, 7:41 AM

gerritbot added a project: Patch-For-Review.May 16 2019, 7:41 AM

Change 510690 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] 'actionthrottledtext' is a retryable wikibase error

https://gerrit.wikimedia.org/r/510690

Xqt closed this task as Resolved.May 16 2019, 9:50 AM

Xqt mentioned this in T253180: "ratelimited" API error does not throttle for rate limits.May 20 2020, 3:49 AM

Maintenance_bot removed a project: Patch-For-Review.May 20 2020, 4:10 AM

Multichill mentioned this in T268645: Pywikibot crashing on ratelimit after the ratelimit removal from bot group in 2020.Nov 24 2020, 4:33 PM