Maniphest T192690

Mass message broken on Wikidata after ratelimit workaround
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Multichill
	Apr 20 2018, 10:28 PM

Description

In T184948 a work around was applied that added a rate limit even to bot accounts that were previously without a rate limit (https://gerrit.wikimedia.org/r/#/c/427156/). On the task we already complained that this is not the right solution and it looks like mass message is broken because of this, see https://www.wikidata.org/w/index.php?title=Special:Log/massmessage&dir=prev&offset=20180420005019&limit=100&type=massmessage&user= for a snippet

Details

	Subject	Repo	Branch	Lines +/-
	Increase the timespan of rate limit in wikidata from 1m to 5m	operations/mediawiki-config	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T258354: remove noratelimit from bot group for Wikidata
T252091: RFC: Site-wide edit rate limiting with PoolCounter
T192912: Unexpected ratelimit makes Pywikibot crash
T184948: limit page creation and edit rate on Wikidata
Mentioned Here: T184948: limit page creation and edit rate on Wikidata
T99899: [Story] Looking up entities by external identifiers

Event Timeline

Multichill created this task.Apr 20 2018, 10:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2018, 10:28 PM

Multichill triaged this task as High priority.Apr 20 2018, 10:28 PM

Multichill added a project: Wikidata.

Multichill mentioned this in T184948: limit page creation and edit rate on Wikidata.

Lea_Lacroix_WMDE subscribed.Apr 21 2018, 7:48 AM

Xaosflux subscribed.Apr 22 2018, 9:26 PM

Liuxinyu970226 subscribed.Apr 23 2018, 4:21 AM

Lydia_Pintscher added a subscriber: hoo.Apr 24 2018, 8:08 AM

Change 428623 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/mediawiki-config@master] Increase the timespan of rate limit in wikidata from 1m to 5m

https://gerrit.wikimedia.org/r/428623

gerritbot added a project: Patch-For-Review.Apr 24 2018, 12:51 PM

https://gerrit.wikimedia.org/r/#/c/427156/

This seems inherently broken, the noratelimit right exists for a reason. I'm not really sure how to work around this in MassMessage besides disabling rate limits I suppose?

Did I miss an announcement to wikitech-l/wikidata-tech that something like this was going to happen?

Multichill updated the task description. (Show Details)Apr 24 2018, 1:39 PM

Change 428623 merged by jenkins-bot:
[operations/mediawiki-config@master] Increase the timespan of rate limit in wikidata from 1m to 5m

https://gerrit.wikimedia.org/r/428623

Mentioned in SAL (#wikimedia-operations) [2018-04-24T13:43:27Z] <ladsgroup@tin> Synchronized wmf-config/InitialiseSettings.php: [[gerrit:428623|Increase the timespan of rate limit in wikidata from 1m to 5m (T192690)]] (duration: 00m 58s)

In T192690#4153593, @Legoktm wrote:

https://gerrit.wikimedia.org/r/#/c/427156/

This seems inherently broken, the noratelimit right exists for a reason. I'm not really sure how to work around this in MassMessage besides disabling rate limits I suppose?

Did I miss an announcement to wikitech-l/wikidata-tech that something like this was going to happen?

Looks like you already found T184948 . https://gerrit.wikimedia.org/r/#/c/427156/ is the change that should be reverted

Multichill mentioned this in T192912: Unexpected ratelimit makes Pywikibot crash.Apr 24 2018, 2:03 PM

Framawiki awarded a token.Jul 18 2018, 6:07 PM

Framawiki subscribed.

This is probably not relevant any more after the limit is removed.