Page MenuHomePhabricator
Create Task
Maniphest T194271

Change config to disable new mobile behavior on all wikis except beta
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

**Motivation**

The Reading and Mobile Web team will add a proper design for the presentation of moved paragraphs. Before that, we do not want to make the changes public in production.

Task

  • Don't show any paragraph moves on mobile in any environment but beta

Todo

  • Prepare config change
  • Claim SWAT deploy window in the week from May 21st - May 25th
  • SWAT deploy the change

Details

SubjectRepoBranchLines +/-
Disable wikidiff2 inline moved paragraphs on productionoperations/mediawiki-configmaster+4 -0
Disable wikidiff2 inline moved paragraphs on productionoperations/mediawiki-configmaster+4 -0
Disable wikidiff2 inline moved paragraphs by defaultoperations/mediawiki-configmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lea_WMDE triaged this task as Medium priority.May 9 2018, 1:57 PM
• Lea_WMDE created this task.
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMay 9 2018, 1:57 PM
Tobi_WMDE_SW renamed this task from Change config to enable mobile behavior on beta only to Change config to disable new mobile behavior on all wikis except beta.May 16 2018, 10:43 AM
Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2018-05-16.
Tobi_WMDE_SW updated the task description. (Show Details)
Tobi_WMDE_SW set the point value for this task to 2.
• Lea_WMDE mentioned this in T190717: Update wikidiff2 library on the WMF production cluster.May 18 2018, 12:12 PM
WMDE-Fisch moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-05-16 board.May 20 2018, 10:28 AM
gerritbot added a comment.May 20 2018, 10:34 AM

Change 434158 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[operations/mediawiki-config@master] Disable wikidiff2 inline moved paragraphs by default

https://gerrit.wikimedia.org/r/434158

gerritbot added a project: Patch-For-Review.May 20 2018, 10:34 AM
WMDE-Fisch subscribed.May 20 2018, 10:59 AM

SWAT reserved on Wednesday 23rd:

https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1792256&oldid=1792230

WMDE-Fisch claimed this task.May 20 2018, 10:59 AM
gerritbot added a comment.May 23 2018, 1:14 PM

Change 434158 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable wikidiff2 inline moved paragraphs by default

https://gerrit.wikimedia.org/r/434158

gerritbot added a comment.May 23 2018, 1:15 PM

Change 434692 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[operations/mediawiki-config@master] Disable wikidiff2 inline moved paragraphs on production

https://gerrit.wikimedia.org/r/434692

Stashbot subscribed.May 23 2018, 1:22 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T13:22:10Z] <zfilipin@tin> Synchronized wmf-config/CommonSettings.php: SWAT: [[gerrit:434693|Revert "Disable wikidiff2 inline moved paragraphs by default" (T194271)]] (duration: 01m 19s)

gerritbot added a comment.May 23 2018, 1:30 PM

Change 434692 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable wikidiff2 inline moved paragraphs on production

https://gerrit.wikimedia.org/r/434692

Stashbot added a comment.May 23 2018, 1:32 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T13:32:19Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:434692|Disable wikidiff2 inline moved paragraphs on production (T194271)]] (duration: 01m 21s)

gerritbot added a comment.May 23 2018, 1:39 PM

Change 434697 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[operations/mediawiki-config@master] Disable wikidiff2 inline moved paragraphs on production

https://gerrit.wikimedia.org/r/434697

gerritbot added a comment.May 23 2018, 1:58 PM

Change 434697 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable wikidiff2 inline moved paragraphs on production

https://gerrit.wikimedia.org/r/434697

Stashbot added a comment.May 23 2018, 2:01 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-23T14:01:04Z] <zfilipin@tin> Synchronized wmf-config/CommonSettings.php: SWAT: [[gerrit:434697|Disable wikidiff2 inline moved paragraphs by default (T194271)]] (duration: 01m 18s)

WMDE-Fisch moved this task from Review to Done on the WMDE-QWERTY-Sprint-2018-05-16 board.May 23 2018, 2:04 PM
WMDE-Fisch added a comment.May 23 2018, 2:14 PM

So just a small writeup why so much stuff going on in this ticket:

The original patch https://gerrit.wikimedia.org/r/#/c/434158/4 made 2 changes in 2 files that depend on each other. Since recently this it not allowed in a SWAT deploy. So the patch got split up during SWAT with https://gerrit.wikimedia.org/r/#/c/434158/ being the first part and https://gerrit.wikimedia.org/r/#/c/434692/ the second.

So it seems the one part of the config change needed to happen before the other and we start off with the wrong one.

Thanks to the guys in the SWAT for handling all this :-)

ovasileva added a project: Web-Team-Backlog (Tracking).May 31 2018, 11:48 AM
Jdlrobson subscribed.Jun 15 2018, 7:48 PM

Can this task be resolved? Sounds done to me.

• Lea_WMDE closed this task as Resolved.Jun 16 2018, 8:02 AM
• Vvjjkkii renamed this task from Change config to disable new mobile behavior on all wikis except beta to wadaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed WMDE-Fisch as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed the point value for this task.
• Vvjjkkii removed subscribers: Aklapper, gerritbot.
CommunityTechBot renamed this task from wadaaaaaaa to Change config to disable new mobile behavior on all wikis except beta.Jul 2 2018, 6:02 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to WMDE-Fisch.
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot set the point value for this task to 2.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: Aklapper, gerritbot.
Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits