Page MenuHomePhabricator
Create Task
Maniphest T194272

Clean up wikidiff2 config variable handling
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To
WMDE-Fisch
Authored By
• Lea_WMDE
May 9 2018, 2:00 PM
Tags
Referenced Files
None
Subscribers
Aklapper
awight
gerritbot
• jkroll
• Lea_WMDE
Liuxinyu970226
Luke081515
View All 14 Subscribers

Description

Motivation
Right now, not all of our config variables around show changes in moved paragraphs are handled the same way. Their behavior should be unified, though

Task
Unify the treatment of the config variables we introduced to all be set via ini_set (see the config section in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/php/wikidiff2/+/refs/heads/master/README). The only current outlier is $wgWikiDiff2MovedParagraphDetectionCutoff.

  • Prepare core to use the new method signature
  • Update operations/mediawiki-config to use ini_set in addition to the PHP variable.
  • Update the wikidiff2 code to get rid of the PHP variable.
  • Release and tag wikidiff2 version 1.8.0 with change signature.
  • Deploy wikidiff2 version 1.8.0 with changed signature
  • Remove the not needed PHP variable from operations/mediawiki-config.
  • Remove the not needed PHP code from core. Remember to add it to the release notes to make backwards compatibility clear

Details

SubjectRepoBranchLines +/-
Remove deprecated wikidiff2 configurationmediawiki/coremaster+0 -15
Deprecate $wgWikiDiff2MovedParagraphDetectionCutoffmediawiki/coremaster+5 -24
Remove deprecated wikidiff2 $wmg variableoperations/mediawiki-configmaster+0 -4
Remove deprecated wikidiff2 configoperations/mediawiki-configmaster+0 -4
Remove warning for unnused 4th argument on wikidiff2mediawiki/corewmf/1.33.0-wmf.23+0 -6
Remove warning for unnused 4th argument on wikidiff2mediawiki/corewmf/1.33.0-wmf.24+0 -6
Remove warning for unnused 4th argument on wikidiff2mediawiki/coremaster+0 -6
Prepare DiffRenderer to changed parameters for wikidiff2 1.8.0mediawiki/coremaster+3 -2
Merge detection cutoff configurationmediawiki/php/wikidiff2master+18 -43
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lea_WMDE triaged this task as Medium priority.May 9 2018, 2:00 PM
• Lea_WMDE created this task.
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMay 9 2018, 2:00 PM
Tobi_WMDE_SW merged a task: T193632: Make wgWikiDiff2MovedParagraphDetectionCutoff an ini-setting.May 17 2018, 2:24 PM
Tobi_WMDE_SW subscribed.
thiemowmde moved this task from Incoming to Show changes in moved text chunks on the TCB-Team (now WMDE-TechWish) board.Jun 12 2018, 4:14 PM
• Vvjjkkii renamed this task from Clean up config variable handling to vadaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: Aklapper, gerritbot.
NicoScribe updated the task description. (Show Details)Jul 1 2018, 12:21 PM
NicoScribe added subscribers: Aklapper, gerritbot.
NicoScribe renamed this task from vadaaaaaaa to Clean up config variable handling.Jul 1 2018, 12:24 PM
NicoScribe lowered the priority of this task from High to Medium.
NicoScribe removed projects: Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
NicoScribe unsubscribed.Aug 18 2018, 1:59 PM
thiemowmde updated the task description. (Show Details)Aug 21 2018, 12:54 PM
thiemowmde updated the task description. (Show Details)Aug 21 2018, 12:56 PM
WMDE-Fisch updated the task description. (Show Details)Aug 21 2018, 12:58 PM
• Lea_WMDE updated the task description. (Show Details)Aug 21 2018, 1:05 PM
• Lea_WMDE edited projects, added WMDE-TechWish-Maintenance; removed German-Community-Wishlist.
• Lea_WMDE set the point value for this task to 8.
WMDE-Fisch mentioned this in T202301: Release and deploy wikidiff2 v1.7.3.Aug 21 2018, 3:24 PM
WMDE-Fisch claimed this task.Aug 22 2018, 1:22 PM
WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2018-08-14.
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-08-14 board.
gerritbot added a comment.Aug 22 2018, 2:33 PM

Change 454555 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/php/wikidiff2@master] Merge detection cutoff configuration

https://gerrit.wikimedia.org/r/454555

gerritbot added a project: Patch-For-Review.Aug 22 2018, 2:33 PM

Change 454556 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/core@master] Prepare DiffRenderer to changed parameters for wikidiff2 1.8.0

https://gerrit.wikimedia.org/r/454556

WMDE-Fisch added a comment.Aug 22 2018, 2:39 PM

Update operations/mediawiki-config to use ini_set in addition to the PHP variable.

Does not need to be done, since the ini settings have defaults in place and the wikidiff2 lib uses the moved paragraph detection out of the box

WMDE-Fisch updated the task description. (Show Details)Aug 22 2018, 2:40 PM
gerritbot added a comment.Aug 23 2018, 2:51 PM

Change 454555 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Merge detection cutoff configuration

https://gerrit.wikimedia.org/r/454555

gerritbot added a comment.Aug 27 2018, 8:48 AM

Change 454556 merged by WMDE-Fisch:
[mediawiki/core@master] Prepare DiffRenderer to changed parameters for wikidiff2 1.8.0

https://gerrit.wikimedia.org/r/454556

WMDE-Fisch updated the task description. (Show Details)Aug 27 2018, 8:57 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 27 2018, 9:01 AM
thiemowmde added a project: WMDE-QWERTY-Sprint-2018-08-29.Aug 29 2018, 8:41 AM
WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Nov 27 2018, 2:45 PM
WMDE-Fisch removed a project: Patch-For-Review.
• Lea_WMDE added a project: WMDE-QWERTY-X-Mas-Sprint-2018-12-18.Dec 18 2018, 12:44 PM
• Lea_WMDE added a project: WMDE-QWERTY-Sprint-2019-01-10.Jan 10 2019, 1:22 PM
WMDE-Fisch claimed this task.Jan 11 2019, 1:19 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-01-10 board.
WMDE-Fisch updated the task description. (Show Details)Jan 11 2019, 2:09 PM
WMDE-Fisch added a comment.Jan 12 2019, 10:21 AM

For release see: https://releases.wikimedia.org/wikidiff2/

WMDE-Fisch changed the status of subtask T203069: Deploy wikidiff2 v1.8.1 with changed signature from Open to Stalled.Jan 23 2019, 4:05 PM
• Lea_WMDE changed the status of subtask T203069: Deploy wikidiff2 v1.8.1 with changed signature from Stalled to Open.Mar 20 2019, 2:43 PM
gerritbot added a comment.Apr 5 2019, 4:28 PM

Change 501624 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/core@master] Remove warning for unnused 4th argument on wikidiff2

https://gerrit.wikimedia.org/r/501624

gerritbot added a project: Patch-For-Review.Apr 5 2019, 4:28 PM
gerritbot added a comment.Apr 5 2019, 4:30 PM

Change 501625 had a related patch set uploaded (by Krinkle; owner: WMDE-Fisch):
[mediawiki/core@wmf/1.33.0-wmf.24] Remove warning for unnused 4th argument on wikidiff2

https://gerrit.wikimedia.org/r/501625

gerritbot added a comment.Apr 5 2019, 4:31 PM

Change 501626 had a related patch set uploaded (by Krinkle; owner: WMDE-Fisch):
[mediawiki/core@wmf/1.33.0-wmf.23] Remove warning for unnused 4th argument on wikidiff2

https://gerrit.wikimedia.org/r/501626

WMDE-Fisch mentioned this in T220217: PHP Warning: wgWikiDiff2MovedParagraphDetectionCutoff is set WikiDiff2 does not support it.Apr 5 2019, 4:33 PM
gerritbot added a comment.Apr 5 2019, 4:53 PM

Change 501624 merged by jenkins-bot:
[mediawiki/core@master] Remove warning for unnused 4th argument on wikidiff2

https://gerrit.wikimedia.org/r/501624

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 5 2019, 5:01 PM
gerritbot added a comment.Apr 5 2019, 5:06 PM

Change 501625 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.24] Remove warning for unnused 4th argument on wikidiff2

https://gerrit.wikimedia.org/r/501625

gerritbot added a comment.Apr 5 2019, 5:17 PM

Change 501626 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.23] Remove warning for unnused 4th argument on wikidiff2

https://gerrit.wikimedia.org/r/501626

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 5 2019, 6:01 PM
MoritzMuehlenhoff closed subtask T203069: Deploy wikidiff2 v1.8.1 with changed signature as Resolved.Apr 15 2019, 9:46 AM
gerritbot added a comment.May 21 2019, 10:07 AM

Change 511667 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[operations/mediawiki-config@master] Remove deprecated wikidiff2 config

https://gerrit.wikimedia.org/r/511667

gerritbot added a comment.May 21 2019, 10:07 AM

Change 511668 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[operations/mediawiki-config@master] Remove deprecated wikidiff2 $wmg variable

https://gerrit.wikimedia.org/r/511668

awight subscribed.May 21 2019, 11:28 PM

The mediawiki-core usages make it look like we're going to invalidate a lot of cached diffs with this... https://codesearch.wmflabs.org/search/?q=WikiDiff2MovedParagraphDetectionCutoff&i=nope&files=&repos=

We've decided to go ahead with deployment anyway.

gerritbot added a comment.May 21 2019, 11:29 PM

Change 511667 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove deprecated wikidiff2 config

https://gerrit.wikimedia.org/r/511667

gerritbot added a comment.May 21 2019, 11:43 PM

Change 511668 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove deprecated wikidiff2 $wmg variable

https://gerrit.wikimedia.org/r/511668

awight updated the task description. (Show Details)May 21 2019, 11:52 PM
Alsee unsubscribed.May 22 2019, 2:43 AM
awight added a comment.May 22 2019, 1:27 PM

Minor observation: we should schedule a hard end-of-life for supporting older wikidiff2 versions, to allow us to remove special-case code.

gerritbot added a comment.May 22 2019, 1:43 PM

Change 511884 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@master] Deprecate $wgWikiDiff2MovedParagraphDetectionCutoff

https://gerrit.wikimedia.org/r/511884

gerritbot added a comment.May 22 2019, 2:50 PM

Change 511884 merged by jenkins-bot:
[mediawiki/core@master] Deprecate $wgWikiDiff2MovedParagraphDetectionCutoff

https://gerrit.wikimedia.org/r/511884

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).May 25 2019, 2:01 AM
Ladsgroup removed a project: Patch-For-Review.May 28 2019, 3:37 PM
gerritbot added a comment.Oct 9 2019, 1:58 PM

Change 541821 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/core@master] Remove deprecated wikidiff2 configuration

https://gerrit.wikimedia.org/r/541821

gerritbot added a project: Patch-For-Review.Oct 9 2019, 1:58 PM
gerritbot added a comment.Oct 22 2019, 12:05 PM

Change 541821 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated wikidiff2 configuration

https://gerrit.wikimedia.org/r/541821

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2019, 12:11 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 22 2019, 2:13 PM
awight renamed this task from Clean up config variable handling to Clean up wikidiff2 config variable handling.Oct 22 2019, 2:27 PM
awight closed this task as Resolved.
awight updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits