Page MenuHomePhabricator
Create Task
Maniphest T194732

Edit Form Statements using API
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As an API user I want to be able to edit statements on Forms through wbeditentity in order to quickly add/modify/remove data.

Problem:
Currently editing of statements on Forms is not supported via wbeditentity.

Example:
see P7373

BDD

GIVEN I make a `wbeditentity` API request with the `"claims"` key set within a form's JSON
WHEN I submit the request
THEN the form's statements are modified accordingly

Acceptance criteria:

  • statements are saved persistently
  • edit summary shows up in recent changes/Lexeme history/watchlist

Open questions:
* What parts of it are already working? wbsetclaim works, wbeditentity doesn't work at all.

Technical Notes
In theory, once T201389 is solved, the only thing left to make wbeditentity work, is to add the existing ChangeOpDeserializer for Forms.

Info

Details

SubjectRepoBranchLines +/-
Form statement GUIDs: generate on clonemediawiki/extensions/WikibaseLexememaster+52 -58
Enable form statement editing through wbeditentitymediawiki/extensions/WikibaseLexememaster+638 -400
Enable form statement editing through wbeditentitymediawiki/extensions/WikibaseLexememaster+508 -396
Form statement GUIDs: generate on clonemediawiki/extensions/WikibaseLexememaster+52 -58
Form: do not validate at construction timemediawiki/extensions/WikibaseLexememaster+8 -15
Do not validate a new statement's GUIDmediawiki/extensions/Wikibasemaster+2 -2
EditEntity: form statements not supportedmediawiki/extensions/WikibaseLexememaster+44 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Lucas_Werkmeister_WMDE added a comment.Jul 18 2018, 11:18 AM

What currently happens is that the statements are thrown away when creating a form via wbeditentity. For example, this lexeme was created with the following data (based on L50):

P7373 Lexeme data for testwikidata:L88
1{
2 "type": "lexeme",
3 "lemmas": {
4 "de": {
5 "language": "de",
6 "value": "Wissen"
7 }
8 },
9 "lexicalCategory": "Q92595",
10 "language": "Q348",
11 "claims": {
12 "P75607": [
13 {
14 "mainsnak": {
15 "snaktype": "value",
16 "property": "P75607",
17 "datavalue": {
18 "value": {
19 "entity-type": "lexeme",
20 "numeric-id": 51,
21 "id": "L51"
22 },
23 "type": "wikibase-entityid"
24 },
25 "datatype": "wikibase-lexeme"
26 },
27 "type": "statement",
28 "rank": "normal"
29 },
30 {
31 "mainsnak": {
32 "snaktype": "value",
33 "property": "P75607",
34 "datavalue": {
35 "value": {
36 "entity-type": "lexeme",
37 "numeric-id": 52,
38 "id": "L52"
39 },
40 "type": "wikibase-entityid"
41 },
42 "datatype": "wikibase-lexeme"
43 },
44 "type": "statement",
45 "rank": "normal"
46 }
47 ],
48 "P82": [
49 {
50 "mainsnak": {
51 "snaktype": "value",
52 "property": "P82",
53 "datavalue": {
54 "value": {
55 "entity-type": "item",
56 "numeric-id": 163015,
57 "id": "Q163015"
58 },
59 "type": "wikibase-entityid"
60 },
61 "datatype": "wikibase-item"
62 },
63 "type": "statement",
64 "rank": "normal"
65 }
66 ],
67 "P75610": [
68 {
69 "mainsnak": {
70 "snaktype": "value",
71 "property": "P75610",
72 "datavalue": {
73 "value": "foo",
74 "type": "string"
75 },
76 "datatype": "string"
77 },
78 "type": "statement",
79 "rank": "normal"
80 }
81 ]
82 },
83 "forms": [
84 {
85 "add": "",
86 "representations": {
87 "de": {
88 "language": "de",
89 "value": "Wissen"
90 }
91 },
92 "grammaticalFeatures": [
93 "Q163012",
94 "Q163014"
95 ],
96 "claims": {
97 "P75609": [
98 {
99 "mainsnak": {
100 "snaktype": "value",
101 "property": "P75609",
102 "datavalue": {
103 "value": {
104 "entity-type": "form",
105 "id": "L53-F1"
106 },
107 "type": "wikibase-entityid"
108 }
109 },
110 "type": "statement",
111 "rank": "normal"
112 }
113 ],
114 "P75608": [
115 {
116 "mainsnak": {
117 "snaktype": "value",
118 "property": "P75608",
119 "datavalue": {
120 "value": {
121 "entity-type": "form",
122 "id": "L54-F1"
123 },
124 "type": "wikibase-entityid"
125 }
126 },
127 "type": "statement",
128 "rank": "normal"
129 }
130 ]
131 }
132 },
133 {
134 "add": "",
135 "representations": {
136 "de": {
137 "language": "de",
138 "value": "Wissens"
139 }
140 },
141 "grammaticalFeatures": [
142 "Q163013",
143 "Q163014"
144 ],
145 "claims": []
146 },
147 {
148 "add": "",
149 "representations": {
150 "de": {
151 "language": "de",
152 "value": "Wissen"
153 }
154 },
155 "grammaticalFeatures": [
156 "Q163014",
157 "Q163016"
158 ],
159 "claims": []
160 },
161 {
162 "add": "",
163 "representations": {
164 "de": {
165 "language": "de",
166 "value": "Wissen"
167 }
168 },
169 "grammaticalFeatures": [
170 "Q163014",
171 "Q163017"
172 ],
173 "claims": []
174 }
175 ]
176}

The first form should have a statement, but doesn’t.

Lydia_Pintscher moved this task from features/bugs for next release (editor experience improvements) to features/bugs for later releases on the Wikidata Lexicographical data board.Aug 3 2018, 8:05 AM
gerritbot subscribed.Aug 3 2018, 3:03 PM

Change 449252 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] EditEntity: form statements not supported

https://gerrit.wikimedia.org/r/449252

gerritbot added a project: Patch-For-Review.Aug 3 2018, 3:03 PM
• Pablo-WMDE mentioned this in rEWLE3fb94989808d: EditEntity: form statements not supported.Aug 3 2018, 3:03 PM
• Pablo-WMDE mentioned this in rEWLEcf6fd63f7179: EditEntity: form statements not supported.Aug 6 2018, 8:04 AM
Lydia_Pintscher added a subtask: T201389: Possibility to add statements to forms that are not yet persisted (and do not have an ID).Aug 7 2018, 8:10 AM
Lydia_Pintscher updated the task description. (Show Details)Aug 7 2018, 8:18 AM
Lydia_Pintscher moved this task from features/bugs for later releases to features/bugs for next release (editor experience improvements) on the Wikidata Lexicographical data board.
Lydia_Pintscher removed the point value for this task.
Jakob_WMDE updated the task description. (Show Details)Aug 7 2018, 10:00 AM
Jakob_WMDE updated the task description. (Show Details)Aug 7 2018, 10:07 AM
• Pablo-WMDE mentioned this in rEWLEf906c5ab3c52: EditEntity: form statements not supported.Aug 7 2018, 10:31 AM
WMDE-leszek set the point value for this task to 5.Aug 7 2018, 12:37 PM
gerritbot added a comment.Aug 7 2018, 2:45 PM

Change 449252 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] EditEntity: form statements not supported

https://gerrit.wikimedia.org/r/449252

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 7 2018, 3:00 PM
KaMan subscribed.Aug 24 2018, 3:59 PM
• Pablo-WMDE closed subtask T201389: Possibility to add statements to forms that are not yet persisted (and do not have an ID) as Resolved.Aug 29 2018, 1:04 PM
• Pablo-WMDE updated the task description. (Show Details)Sep 13 2018, 7:42 AM
• Pablo-WMDE updated the task description. (Show Details)Sep 13 2018, 8:05 AM
Jakob_WMDE claimed this task.Sep 17 2018, 2:33 PM
Jakob_WMDE added a project: Wikidata-Editor-Experience-Improvements-Iteration7.
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration7 board.
gerritbot added a comment.Sep 17 2018, 3:17 PM

Change 460917 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Enable form statement editing through wbeditentity

https://gerrit.wikimedia.org/r/460917

Jakob_WMDE mentioned this in rEWLE8fa65e36115c: Enable form statement editing through wbeditentity.Sep 17 2018, 3:19 PM
Jakob_WMDE mentioned this in rEWLEd2677d1b26e5: Enable form statement editing through wbeditentity.Sep 17 2018, 4:23 PM
Jakob_WMDE mentioned this in rEWLE21bf9b4b6736: Enable form statement editing through wbeditentity.Sep 18 2018, 1:23 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Sep 18 2018, 2:25 PM
WMDE-leszek added a project: Wikidata-Editor-Experience-Improvements-Iteration8.Sep 19 2018, 9:26 AM
WMDE-leszek moved this task from To Do to Doing on the Wikidata-Editor-Experience-Improvements-Iteration8 board.
gerritbot added a comment.Sep 19 2018, 11:31 AM

Change 461157 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Do not validate a new statement's GUID

https://gerrit.wikimedia.org/r/461157

gerritbot added a comment.Sep 20 2018, 12:34 PM

Change 461630 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Form: do not validate of construction time

https://gerrit.wikimedia.org/r/461630

• Pablo-WMDE mentioned this in rEWLEf57a3c157adc: Form: do not validate of construction time.Sep 20 2018, 12:36 PM
• Pablo-WMDE mentioned this in rEWLE2b70b7a60348: Form: do not validate of construction time.Sep 20 2018, 4:21 PM
• Pablo-WMDE mentioned this in T204541: Drop EntityId from statement GUID.Sep 21 2018, 6:45 AM
• Pablo-WMDE mentioned this in rEWLE1bd4cc079e9e: Form: do not validate at construction time.Sep 21 2018, 12:05 PM
gerritbot added a comment.Sep 24 2018, 9:16 AM

Change 461157 abandoned by Jakob:
Do not validate a new statement's GUID

https://gerrit.wikimedia.org/r/461157

Jakob_WMDE mentioned this in rEWLEdf5a3e4e407a: Form: do not validate at construction time.Sep 24 2018, 9:48 AM
Jakob_WMDE mentioned this in rEWLE2ebd4aad96cb: Enable form statement editing through wbeditentity.
Jakob_WMDE mentioned this in rEWLE49778391f17d: Enable form statement editing through wbeditentity.Sep 24 2018, 10:06 AM
Jakob_WMDE mentioned this in rEWLE80dbde6272e6: Enable form statement editing through wbeditentity.Sep 24 2018, 10:41 AM
Jakob_WMDE mentioned this in rEWLE144367e8999c: Enable form statement editing through wbeditentity.Sep 24 2018, 3:03 PM
Jakob_WMDE mentioned this in rEWLEb66ac99a9251: Enable form statement editing through wbeditentity.Sep 24 2018, 3:20 PM
Jakob_WMDE mentioned this in rEWLEebc403b8747e: Enable form statement editing through wbeditentity.Sep 24 2018, 4:15 PM
Jakob_WMDE mentioned this in rEWLEf1650dc1eadb: Enable form statement editing through wbeditentity.Sep 25 2018, 9:15 AM
Jakob_WMDE mentioned this in rEWLE49d896d30413: Enable form statement editing through wbeditentity.Sep 25 2018, 9:18 AM
Jakob_WMDE mentioned this in rEWLE93dda604128a: Enable form statement editing through wbeditentity.Sep 26 2018, 1:05 PM
Jakob_WMDE mentioned this in rEWLEab7b82cbee93: Enable form statement editing through wbeditentity.Sep 26 2018, 1:18 PM
Jakob_WMDE mentioned this in rEWLEbc4ac413a5ac: Enable form statement editing through wbeditentity.Sep 26 2018, 1:30 PM
Jakob_WMDE mentioned this in rEWLEd1222696f0da: Enable form statement editing through wbeditentity.Sep 26 2018, 2:23 PM
Jakob_WMDE mentioned this in rEWLE8f3db4cc9d15: Enable form statement editing through wbeditentity.Sep 26 2018, 3:22 PM
Jakob_WMDE mentioned this in rEWLE5186fe771bc6: Enable form statement editing through wbeditentity.Sep 27 2018, 12:43 PM
Jakob_WMDE mentioned this in rEWLE59a002b0b522: Enable form statement editing through wbeditentity.Sep 27 2018, 1:11 PM
Jakob_WMDE mentioned this in rEWLE18beca2dc7d0: Enable form statement editing through wbeditentity.Sep 27 2018, 3:28 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Editor-Experience-Improvements-Iteration8 board.Sep 27 2018, 4:02 PM
gerritbot added a comment.Oct 1 2018, 11:09 AM

Change 463727 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Form statement GUIDs: generate on clone

https://gerrit.wikimedia.org/r/463727

• Pablo-WMDE mentioned this in rEWLEe40883a620be: Form statement GUIDs: generate on clone.Oct 1 2018, 11:16 AM
• Pablo-WMDE mentioned this in rEWLE1c3d25cfea32: Form statement GUIDs: generate on clone.Oct 1 2018, 11:29 AM
Jakob_WMDE mentioned this in rEWLE7a478516cd4b: Enable form statement editing through wbeditentity.Oct 1 2018, 12:50 PM
Jakob_WMDE mentioned this in rEWLEca02a295b1c2: Enable form statement editing through wbeditentity.Oct 1 2018, 1:26 PM
Jakob_WMDE mentioned this in rEWLE70a6fb7fa816: Enable form statement editing through wbeditentity.Oct 1 2018, 1:54 PM
• Pablo-WMDE mentioned this in rEWLE74dfd4c0b27d: Form statement GUIDs: generate on clone.Oct 1 2018, 1:57 PM
gerritbot added a comment.Oct 1 2018, 1:58 PM

Change 461630 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Form: do not validate at construction time

https://gerrit.wikimedia.org/r/461630

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)); removed MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Oct 1 2018, 2:00 PM
Jakob_WMDE mentioned this in rEWLEdabf48e16bd7: Enable form statement editing through wbeditentity.Oct 1 2018, 2:12 PM
• Pablo-WMDE mentioned this in rEWLE5e79f1845088: Form statement GUIDs: generate on clone.Oct 1 2018, 2:14 PM
gerritbot added a comment.Oct 2 2018, 10:33 AM

Change 460917 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Enable form statement editing through wbeditentity

https://gerrit.wikimedia.org/r/460917

Jakob_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration8 board.Oct 2 2018, 10:42 AM
gerritbot added a comment.Oct 2 2018, 10:51 AM

Change 463727 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Form statement GUIDs: generate on clone

https://gerrit.wikimedia.org/r/463727

Jakob_WMDE moved this task from Test (Product Review) to Doing on the Wikidata-Editor-Experience-Improvements-Iteration8 board.Oct 2 2018, 3:20 PM
gerritbot added a comment.Oct 2 2018, 6:49 PM

Change 464015 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Enable form statement editing through wbeditentity

https://gerrit.wikimedia.org/r/464015

• Pablo-WMDE mentioned this in rEWLE21a026715758: Enable form statement editing through wbeditentity.Oct 2 2018, 6:50 PM
• Pablo-WMDE mentioned this in rEWLEda2dbc7f286e: Enable form statement editing through wbeditentity.Oct 2 2018, 7:12 PM
• Pablo-WMDE mentioned this in rEWLEc9b50238a7c1: Enable form statement editing through wbeditentity.Oct 2 2018, 7:15 PM
• Pablo-WMDE mentioned this in rEWLE1cc14d5438bb: Enable form statement editing through wbeditentity.Oct 4 2018, 7:01 AM
• Pablo-WMDE mentioned this in rEWLEa51617e24492: Enable form statement editing through wbeditentity.Oct 4 2018, 7:04 AM
• Pablo-WMDE mentioned this in rEWLEc668dacf5e7e: Enable form statement editing through wbeditentity.Oct 4 2018, 7:08 AM
• Pablo-WMDE mentioned this in rEWLEe3ba384ced45: Enable form statement editing through wbeditentity.Oct 4 2018, 8:30 AM
• Pablo-WMDE mentioned this in rEWLEefc9d667cf4c: Enable form statement editing through wbeditentity.Oct 4 2018, 11:31 AM
• Pablo-WMDE mentioned this in rEWLE057318ac262b: Enable form statement editing through wbeditentity.Oct 4 2018, 11:36 AM
gerritbot added a comment.Oct 4 2018, 11:49 AM

Change 464515 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Form statement GUIDs: generate on clone

https://gerrit.wikimedia.org/r/464515

• Pablo-WMDE mentioned this in rEWLEcb090072e4a5: Form statement GUIDs: generate on clone.Oct 4 2018, 11:51 AM
Jakob_WMDE mentioned this in rEWLE7af18156c103: Enable form statement editing through wbeditentity.Oct 4 2018, 1:02 PM
• Pablo-WMDE mentioned this in rEWLE1d8988c9f32e: Enable form statement editing through wbeditentity.Oct 4 2018, 3:31 PM
• Pablo-WMDE mentioned this in rEWLE07941d59d45c: Form statement GUIDs: generate on clone.
• Pablo-WMDE mentioned this in rEWLE0fe8d918ec31: Enable form statement editing through wbeditentity.Oct 4 2018, 4:03 PM
• Pablo-WMDE mentioned this in rEWLEc0adbac76512: Form statement GUIDs: generate on clone.
gerritbot added a comment.Oct 5 2018, 12:14 PM

Change 464015 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Enable form statement editing through wbeditentity

https://gerrit.wikimedia.org/r/464015

gerritbot added a comment.Oct 5 2018, 12:14 PM

Change 464515 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Form statement GUIDs: generate on clone

https://gerrit.wikimedia.org/r/464515

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 5 2018, 1:00 PM
Jakob_WMDE moved this task from Doing to Test (Product Review) on the Wikidata-Editor-Experience-Improvements-Iteration8 board.Oct 5 2018, 1:38 PM
Jakob_WMDE added a comment.Oct 5 2018, 1:40 PM

For product review: This works on beta now.
https://wikidata.beta.wmflabs.org/wiki/Special:ApiSandbox#action=wbeditentity&format=json&new=form&token=%2B%5C&data=%7B%0A%20%20%22lexemeId%22%3A%20%22L1%22%2C%0A%20%20%22representations%22%3A%20%7B%20%22en%22%3A%20%7B%20%22language%22%3A%20%22en%22%2C%20%22value%22%3A%20%22potato%22%20%7D%20%7D%2C%0A%20%20%22claims%22%3A%20%5B%0A%20%20%20%20%7B%0A%20%20%20%20%20%20%22mainsnak%22%3A%20%7B%20%22snaktype%22%3A%20%22novalue%22%2C%20%22property%22%3A%20%22P694%22%20%7D%2C%0A%20%20%20%20%20%20%22type%22%3A%20%22statement%22%2C%0A%20%20%20%20%20%20%22rank%22%3A%20%22normal%22%0A%20%20%20%20%7D%0A%20%20%5D%0A%7D

wbeditentity request with new: "form" and data:

{
  "lexemeId": "L1",
  "representations": { "en": { "language": "en", "value": "potato" } },
  "claims": [
    {
      "mainsnak": { "snaktype": "novalue", "property": "P694" },
      "type": "statement",
      "rank": "normal"
    }
  ]
}

produced the following edit: https://wikidata.beta.wmflabs.org/w/index.php?title=Lexeme%3AL1&type=revision&diff=1069991&oldid=1069534

WMDE-leszek closed this task as Resolved.Oct 15 2018, 4:24 PM
WMDE-leszek moved this task from Test (Product Review) to Done on the Wikidata-Editor-Experience-Improvements-Iteration8 board.

Tested a few different cases more, seems all to be working well!

Lydia_Pintscher mentioned this in T199896: API: Support editing statements on senses via wbeditentity.Feb 23 2021, 9:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL